Peter Rabbitson [Wed, 21 Nov 2012 11:38:43 +0000]
Fix self-referential resultset update/delete on MySQL (aggravated by
31073ac7)
MySQL is unable to figure out it needs a temp-table when it is trying
to update a table with a condition it derived from that table. So what
we do here is give it a helpful nudge by rewriting any "offending"
subquery to a double subquery post-sql-generation.
Performance seems to be about the same for moderately large sets. If it
becomes a problem later we can always revisit and add the ability to
induce "row-by-row" update/deletion instead.
The implementation sucks, but is rather concise and most importantly
contained to the MySQL codepath only - it does not affect the rest of
the code flow in any way.
Peter Rabbitson [Mon, 19 Nov 2012 09:11:11 +0000]
Fix proper handling of composite resultset heads (e.g. as_subselect_rs)
Solves http://lists.scsys.co.uk/pipermail/dbix-class/2012-July/010650.html
Peter Rabbitson [Fri, 11 Jan 2013 18:00:20 +0000]
Move the *preliminary* multicol IN support to the sqlmaker
It really does not belong in ResultSet.pm, but we do not have an API
either. Take a first stab at a sketch, DQ will need to wrangle it to
completion.
Peter Rabbitson [Thu, 10 Jan 2013 21:35:51 +0000]
Flip quoting in all of t/71mysql.t (no test changes)
Peter Rabbitson [Mon, 7 Jan 2013 18:45:05 +0000]
Simplify dbh_do invocation, and only alias @_ when needed
Peter Rabbitson [Mon, 7 Jan 2013 18:43:40 +0000]
Scope::Upper somehow confuses pseudofork on older perls - investigation pending
View the patch with -w, lots of reindentation
Peter Rabbitson [Sat, 12 Jan 2013 17:35:36 +0000]
Reign in (a little bit) the sprawling CRLF insanity on Win32
In the process join the notabs/eol tests into one file, and tighten
the WS checks even more
Peter Rabbitson [Thu, 10 Jan 2013 18:32:19 +0000]
Ensure the testddl is regenerated at Makefile and distdir times
This will stop things constantly getting out of sync
Peter Rabbitson [Thu, 10 Jan 2013 18:08:31 +0000]
Regenerate SQLite testschema ddl with explicit quoting and generate FKs
We *do not* yet turn on FK checking in sqlite - many tests will need tweaking
Peter Rabbitson [Thu, 10 Jan 2013 17:15:52 +0000]
SQLT got a lot better lately - bump min version
Remove a large number of workarounds in the process
Peter Rabbitson [Mon, 7 Jan 2013 21:50:23 +0000]
Remove SQLA namespace pollution fixer - this is no longer the case since 1.73
Peter Rabbitson [Thu, 10 Jan 2013 14:03:05 +0000]
deployment_statements() is not storage-dependent - only sqlt_type() is
This fixes maint/gen_schema erroring out after
75d3bdb243
Peter Rabbitson [Mon, 7 Jan 2013 13:14:34 +0000]
Reduce amount of calls to $rsrc->columns_info where possible
Peter Rabbitson [Mon, 7 Jan 2013 13:09:29 +0000]
_resolve_bindattrs already expects colinfo - just pass it in where we forgot
Peter Rabbitson [Thu, 13 Dec 2012 06:40:13 +0000]
Fix some pessimizations spotted here and there (no functional changes)
Mainly remove a number of unused @_ unpackings, and remove the hideous
_resolved_attrs_copy pessimizer
Peter Rabbitson [Thu, 10 Jan 2013 13:13:21 +0000]
Remove apparent pessimization introduced in
6a588797
There is no conceivable reason why the attrs need to be recalculated on cursor
reset. All tests seem to pass as well. Removing it as the calculation is quite
expensive - if problems arise bisection will hopefully lead us here
Peter Rabbitson [Sun, 23 Dec 2012 11:45:16 +0000]
Optimize populate(), especially bind handling in complex populate cases
Instead of recalculating the data slice positions on every loop, we
do it only once during the "proto bind" generation. This is because
even though all bind values can and will change (even ones supplied
via \[ ... ]), their number will always remain constant.
Peter Rabbitson [Fri, 21 Dec 2012 11:41:54 +0000]
Simplify/cleanup parsing of search() arguments
Peter Rabbitson [Thu, 27 Dec 2012 05:43:53 +0000]
Ensure _dbi_attrs_for_bind/bind_attribute_by_data_type are called after connecting
This way a user does not have to worry about the particular DBI/DBD being
loaded before accessing its constants
Peter Rabbitson [Wed, 26 Dec 2012 19:50:57 +0000]
Remove support for source_bind_attributes() as promised in
0e773352a
Original deprecation was put in place almost 2 years ago
Peter Rabbitson [Thu, 10 Jan 2013 13:39:08 +0000]
Deprecate emulate_limit() - can not be sanely supported by DQ
Peter Rabbitson [Thu, 27 Dec 2012 09:43:08 +0000]
Reorganize travis test script, I *think* no functional changes
Peter Rabbitson [Sat, 5 Jan 2013 22:18:17 +0000]
List::Util got fixed and is again installable on 5.8
Peter Rabbitson [Wed, 26 Dec 2012 10:36:23 +0000]
Move Travis Data::Dumper installation earlier, before its dependents
Peter Rabbitson [Wed, 26 Dec 2012 10:34:01 +0000]
Install Carp.pm separately on Travis
Otherwise when the timing is right it trips up installation of the parallel job
Peter Rabbitson [Wed, 26 Dec 2012 09:50:33 +0000]
Reorganize MSSQL/DBD::Sybase TODOs on MAS+txn tests
Brendan Byrd [Thu, 22 Mar 2012 01:10:08 +0000]
Fix TODO tests to only mark exactly the failing tests as TODO
and run the passing tests as real tests.
Peter Rabbitson [Wed, 26 Dec 2012 09:06:54 +0000]
No reason to run this test at all until MC is rewritten
Peter Rabbitson [Wed, 26 Dec 2012 09:02:20 +0000]
Promote leaky rscond todo to a smoke-fail - try to establish a pattern
Peter Rabbitson [Wed, 19 Dec 2012 13:04:55 +0000]
Fix broken DBICTest::RunMode::is_smoker() (riba got pwned by precedence)
Peter Rabbitson [Wed, 19 Dec 2012 11:22:45 +0000]
Attempt to build a dist on travis if all tests pass
Peter Rabbitson [Mon, 17 Dec 2012 08:19:00 +0000]
Fixup possible crlf in generated files
Peter Rabbitson [Wed, 19 Dec 2012 10:36:33 +0000]
Tighten notab/eol checks even more
Peter Rabbitson [Tue, 18 Dec 2012 12:08:08 +0000]
Switch rm to rm -f - we do not care about failure
Peter Rabbitson [Mon, 17 Dec 2012 08:07:02 +0000]
Move generated README to maint/.Generated_Pod as well - simplifies cleanup
Peter Rabbitson [Mon, 17 Dec 2012 07:52:13 +0000]
Use plain old file concat for the dbicadmin pod-injection
Lose the oneliner for more sanity and better cross-platform support
Peter Rabbitson [Sun, 16 Dec 2012 11:53:20 +0000]
Create distinct lib/ subdir in maint/.Generated_Pod (no functional changes)
Peter Rabbitson [Sun, 16 Dec 2012 07:39:42 +0000]
Rewrite all Makefile oneliners in terms of EU::MM::oneliner
Alexander Hartmaier [Wed, 7 Nov 2012 16:17:55 +0000]
Improve the populate docs in ::Schema and ::ResultSet
Peter Rabbitson [Sun, 16 Dec 2012 21:07:06 +0000]
Expand notabs/eol testing to .pod and some files at the root
Peter Rabbitson [Mon, 17 Dec 2012 12:50:27 +0000]
Explicitly specify Scalar::Util dep, and work around RT#80646 on travis
The inability to install Scalar::Util did not abort the cpan runs, and
therefore revealed a nasty bug in first() that is present on all perl-bundled
List::Utils until 5.8.8
Peter Rabbitson [Mon, 17 Dec 2012 12:48:41 +0000]
Fix silly thinko in travis_prepare_env's extract_prereqs()
Peter Rabbitson [Fri, 14 Dec 2012 08:28:44 +0000]
New Pod::Inherit now works on 5.8 (still needs Pod::Tree, RT#81896)
Peter Rabbitson [Sat, 15 Dec 2012 08:29:18 +0000]
I was wrong about
2d12a809 - the crash is real
Switch remaining problematic tests to skip away in is_plain (enduser
installation) mode, keep failing for the time being for authors until
a cause is found.
Please *DO NOT* quietly skip inconvenient tests
Peter Rabbitson [Sat, 15 Dec 2012 06:55:23 +0000]
Run t/storage/global_destruction.t using SQLite as well
Peter Rabbitson [Sat, 15 Dec 2012 04:32:46 +0000]
Add JSON::DWIW to authordeps, so more tests run
Peter Rabbitson [Sat, 15 Dec 2012 04:32:46 +0000]
Revert skip from
a0361822 and fix tests to work correctly
Hand-assembling JSON is prone to error - the $dsn would end up containing
a backslash on Win32 which the simple catenation would not escape.
Peter Rabbitson [Fri, 14 Dec 2012 13:33:22 +0000]
Force xt/ tests to run on anything involving a create_distdir
Peter Rabbitson [Fri, 14 Dec 2012 09:10:14 +0000]
Since .generated_pod is no longer shipped in-dist, move it to maint/
Peter Rabbitson [Thu, 13 Dec 2012 10:37:37 +0000]
Make pod generation more palatable to the existing toolchain
While the installation toolchain seems to understand the concept of
PMLIBDIRS/PMLIBPARENTDIRS rather well, it turns out that both s.c.o.
and metacpan hav great troubles displaying the results. While there
is work underway to fix metacpan, the intermittency of the failures
prompted a rethink of how to handle all of this.
So instead we turn (ab)use of ExtUtils::MakeMaker to 11. The generation
scripts still dump their contents into .generated_pod/ as before.
However afterwards we hook the create_distdir EUMM target and split it
into several targets:
create_distdir : clonedir_generate_files clonedir_post_generate_files fresh_manifest create_distdir_copy_manifested clonedir_cleanup_generated_files
Then we use the pre-existing EUMM install facility to copy the generated
POD directly to lib/, create a manifest and a distdir, and then delete
everything we just copied from lib/, leaving the clone-dir as pristine
as it was before we started.
Peter Rabbitson [Thu, 13 Dec 2012 08:48:52 +0000]
Merge all pod generation into one inc snippet, cleanup the poddir beforehand
Peter Rabbitson [Thu, 13 Dec 2012 09:54:20 +0000]
Do not mask Makefile.PL errors in END block
Rafael Kitover [Tue, 27 Mar 2012 04:08:37 +0000]
Minor clarifications to POD
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
More documentation improvements in the spirit of
fb13a49f
Clarify new/new_result/search relations
Clarify return of update/delete
Some trivial readability fixes
Peter Rabbitson [Wed, 12 Dec 2012 15:50:34 +0000]
Boy that's a lot of emails ;)
Brendan Byrd [Mon, 10 Dec 2012 22:43:06 +0000]
Add linkback to ResultSource::resultset_attributes
Also clarify problems related to its use
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Relationship::Base documentation fixes in the spirit of
fb13a49f
Peter Rabbitson [Fri, 30 Nov 2012 14:44:26 +0000]
Some dependency bumps
- CAG 0.10008 causes DBIC test fails
- D::GD before 0.09 is broken on threads in pure-perl mode
- Latest MRO::Compat will upgrade Class::C3 and Class::C3::XS automatically
- Older Module::Find will not go follow symlinks, upgrade to avoid deployment differences
- Older namespace::clean is too complex - use one where complexity lives in B::Hooks::EndOfScope
- Bump Try::Tiny API
Peter Rabbitson [Tue, 11 Dec 2012 11:47:42 +0000]
Fix incorrect handling of $? in travis preconf script
Peter Rabbitson [Tue, 11 Dec 2012 11:33:35 +0000]
Temporarily stop requiring podinherit on < 5.10.1, until we fix it
Peter Rabbitson [Sat, 3 Nov 2012 17:50:18 +0000]
Fix RT#78436 - a replicated storage does not have a conninfo as such
Peter Rabbitson [Mon, 3 Dec 2012 11:46:24 +0000]
Smoke bleadperl as well
Peter Rabbitson [Tue, 11 Dec 2012 11:01:25 +0000]
Stop using deprecated regex syntax
Peter Rabbitson [Tue, 11 Dec 2012 11:00:18 +0000]
Partial fix for the hash randomization issues in 5.17.6+
NOTE: this is *not* a complete fix. There are at least two other places
which do not manifest themselves due to lack of tests. Work underway...
Peter Rabbitson [Tue, 11 Dec 2012 10:51:20 +0000]
Revert
50e6c52e0 - the crash was most likely due to old Moo (same as dfd722ef)
Peter Rabbitson [Tue, 11 Dec 2012 10:47:38 +0000]
DBIC::Carp not primetime ready - hide
Peter Rabbitson [Tue, 11 Dec 2012 10:28:52 +0000]
Do not grab a global lock if test won't run
Brendan Byrd [Mon, 10 Dec 2012 22:10:26 +0000]
Fill gaps in documentation: alias ($rs attr), table_alias, result_class
Brendan Byrd [Mon, 10 Dec 2012 17:41:23 +0000]
FINALLY document DBIC @bind_vals
Peter Rabbitson [Tue, 11 Dec 2012 10:11:40 +0000]
Clarify purpose and deprecation of search_literal
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Various other POD fixes
Change docs to reflect new Manual::ResultClass
Stop using "moniker"
There is no Row; there is only Zuul.
Arguments, Return Values, and Linking -will- be enforced!
Brendan Byrd [Tue, 27 Mar 2012 01:31:45 +0000]
Utilize Pod::Inherit to add an INHERITED METHODS section to docs
Brendan Byrd [Fri, 23 Mar 2012 15:09:04 +0000]
Various method POD changes
Apply very small doc correction to search_related
Add "official" method entries for $rel and $col
Add more doc clarification changes to ::Row
Fix incorrect last_modified / update comparison in ::Row/update
Peter Rabbitson [Sun, 9 Dec 2012 05:25:10 +0000]
Turn the CLEANTEST smokes into full blown CPAN-based installs with testing
Not considering doing cpanreporting because the reporter installation itself
would violate the CLEANTEST idea
Peter Rabbitson [Wed, 5 Dec 2012 10:30:23 +0000]
More information about the test env we are about to use
Peter Rabbitson [Sun, 9 Dec 2012 05:25:10 +0000]
Firebird apt configuration can't be made to cooperate - skip when it fails
Peter Rabbitson [Sun, 9 Dec 2012 05:25:04 +0000]
Reorganize travis preconfig script - better tracing and handling of failures
Peter Rabbitson [Sun, 9 Dec 2012 13:38:26 +0000]
Move generated POD to its own dir
Peter Rabbitson [Sun, 9 Dec 2012 16:51:35 +0000]
Use legacy File::Path API - avoid a dependency (see next commit)
Peter Rabbitson [Mon, 10 Dec 2012 08:05:32 +0000]
While permanentising meta/
62628242 did not properly noindex it
Peter Rabbitson [Sun, 9 Dec 2012 12:45:57 +0000]
Forgotten no-longer-needed dependency after
d6b39e46
Brendan Byrd [Thu, 9 Aug 2012 14:45:54 +0000]
AUTHORS mass update; mst doesn't have to take credit for -everything- :)
Peter Rabbitson [Mon, 3 Dec 2012 10:30:35 +0000]
Relax FB reconfig timings even more
Peter Rabbitson [Mon, 3 Dec 2012 10:29:58 +0000]
Truly clean CLEANTEST
Peter Rabbitson [Mon, 3 Dec 2012 10:23:40 +0000]
Disable travis list notifications until things stabilize
Peter Rabbitson [Sun, 2 Dec 2012 06:53:46 +0000]
Add comprehensive Firebird smoking to travis
Peter Rabbitson [Sun, 2 Dec 2012 06:53:46 +0000]
Expand comments, move core dep install before RDBMS setup (no func. changes)
Peter Rabbitson [Sun, 2 Dec 2012 08:13:54 +0000]
Do not spam the mailing lists - only notify once per branchfail
Peter Rabbitson [Fri, 30 Nov 2012 18:34:30 +0000]
Add MOAR meta
Peter Rabbitson [Fri, 30 Nov 2012 15:45:07 +0000]
Throw away suboptimal travis CPANM env-option and tighten plans more
Peter Rabbitson [Thu, 29 Nov 2012 13:57:30 +0000]
More extensive travis testing plan
Peter Rabbitson [Fri, 30 Nov 2012 14:44:26 +0000]
Fix the leaktracer rewrite in
218b7c12 which broke under 5.10
Reduce the amount of shuffling happening in CLONE - use a fresh hashref
instead
Peter Rabbitson [Thu, 29 Nov 2012 13:50:36 +0000]
Some podlator stacks do not like multi-word =begin
Brendan Byrd [Mon, 12 Nov 2012 21:06:28 +0000]
Update .travis.yml with faster deps and DBICTESTs
Peter Rabbitson [Mon, 19 Nov 2012 07:49:45 +0000]
Stop stripping table name qualifier on complex $rs->update/delete
RT#80015, RT#78844
Peter Rabbitson [Sun, 18 Nov 2012 20:17:09 +0000]
Back out frivolous loading of threads.pm
Not only was this an unsuccesful attempt to mask out a bug introduced
in Moo's inlining of Devel::GlobalDestruction (since fixed), but it
broke a test under older win32 perls.
Revert
8bab2062, bump Moo dep
Peter Rabbitson [Sun, 18 Nov 2012 22:32:57 +0000]
Rewrite
461c7168 solving Oracle silent connection failures
The patch incorrectly masks the underlying issue - during the refactor
of
584ea6e4 a bunch of exception traps were introduced which were never
there in the first place. _dbh_get_info() should always be throwing an
error if one takes place (the only place before
584ea6e4 was in the
FreeTDS version determination, and that one made no sense anyway).
_server_info() OTOH is indeed an opportunistic routine - leave the
"rethrow if determining driver" escape as-is
Peter Rabbitson [Sun, 18 Nov 2012 20:08:58 +0000]
Rename and expand false-value prefetch test
Peter Rabbitson [Sun, 18 Nov 2012 19:59:44 +0000]
While the TODO was solved in
b11221ff the source of confusion was not
Peter Rabbitson [Sat, 25 Aug 2012 22:45:30 +0000]
List of what needs undoing since 0.08196