14 years agoAdd assertions about there being no leftover scopes when enter perl_destruct.
Gerard Goossen [Mon, 2 Nov 2009 15:27:42 +0000]
Add assertions about there being no leftover scopes when enter perl_destruct.

14 years agopad_findmy APIification
Zefram [Sun, 8 Nov 2009 13:25:38 +0000]
pad_findmy APIification

Since Nicholas made pad_findmy() part of the public API
(f8f98e0a8bdbde83a9cdc3573d818f69d0a64c78), here's a consequential
change to XS::APItest::KeywordRPN.

14 years agoCorrectly document export of I18N::Langinfo
Kevin Ryde [Sun, 8 Nov 2009 11:36:03 +0000]
Correctly document export of I18N::Langinfo

[perl #70303] I18N::Langinfo docs "nothing exported"

14 years agoMerge branch 'blead' of ssh://perl5.git.perl.org/gitroot/perl into blead
Steffen Mueller [Sun, 8 Nov 2009 11:36:15 +0000]
Merge branch 'blead' of ssh://perl5.git.perl.org/gitroot/perl into blead

14 years agos/AvLEN/AvMAX/ in perlguts
Eric Brine [Sun, 8 Nov 2009 04:53:38 +0000]
s/AvLEN/AvMAX/ in perlguts

14 years agos/AvLEN/AvMAX/ in perlguts
Eric Brine [Sun, 8 Nov 2009 04:53:38 +0000]
s/AvLEN/AvMAX/ in perlguts

14 years agoDefine specially handled chars; and clean-up ebcdic vs unicode
Karl Williamson [Sun, 8 Nov 2009 00:36:55 +0000]
Define specially handled chars; and clean-up ebcdic vs unicode

14 years agoAdd mingw-w64 non-crosscompiling config files
David Golden [Sun, 8 Nov 2009 03:02:41 +0000]
Add mingw-w64 non-crosscompiling config files

Files provided by Sisyphus with this comment: "Attached are the 2
addtional files that we need in the win32 folder. (I did a dos2unix on
them so, hopefully the line endings will be right.) These files are
needed to accommodate the particular 64-bit mingw compiler that
Strawberry Perl will be using. They'll actually be used as the default
64-bit mingw templates."

14 years agoSkip some Pod::Simple tests on VMS that think case is always preserved.
Craig A. Berry [Sat, 7 Nov 2009 04:13:22 +0000]
Skip some Pod::Simple tests on VMS that think case is always preserved.

Already in the upstream queue at:

https://rt.cpan.org/Ticket/Display.html?id=51184

14 years agonote that release engineers need to make sure graham is aware of them
Jesse Vincent [Sat, 7 Nov 2009 20:01:41 +0000]
note that release engineers need to make sure graham is aware of them

14 years agoAdd length and flags arguments to Perl_pad_findmy(), moving it to the public API.
Nicholas Clark [Sat, 7 Nov 2009 13:37:12 +0000]
Add length and flags arguments to Perl_pad_findmy(), moving it to the public API.

Currently no flags bits are used, and the length is cross-checked against
strlen() on the pointer, but the intent is to re-work the entire pad API to be
UTF-8 aware, from the current situation of char * pointers only.

14 years agoPlacate a warning from Borland's compiler.
Nicholas Clark [Sat, 7 Nov 2009 11:11:27 +0000]
Placate a warning from Borland's compiler.

14 years agoMerge commit 'origin/blead' into blead
Steve Hay [Sat, 7 Nov 2009 15:03:56 +0000]
Merge commit 'origin/blead' into blead

14 years agoAvoid circularity in $(LIBBASEFILES) definition in Win32 dmake makefile
Steve Hay [Sat, 7 Nov 2009 14:51:44 +0000]
Avoid circularity in $(LIBBASEFILES) definition in Win32 dmake makefile

14 years agoC++ fail with KeywordRPN
Zefram [Sat, 7 Nov 2009 13:02:33 +0000]
C++ fail with KeywordRPN

A smoke using g++ has revealed:

>KeywordRPN.c: In function 'void XS_XS__APItest__KeywordRPN_import(CV*)':
>KeywordRPN.c:320: error: expected unqualified-id before 'class'
>KeywordRPN.c:320: error: expected initializer before 'class'
>KeywordRPN.c: In function 'void XS_XS__APItest__KeywordRPN_unimport(CV*)':
>KeywordRPN.c:357: error: expected unqualified-id before 'class'
>KeywordRPN.c:357: error: expected initializer before 'class'
>make[1]: *** [KeywordRPN.o] Error 1
>Unsuccessful make(ext/XS-APItest-KeywordRPN): code=512 at make_ext.pl line 449.
>make: *** [lib/auto/XS/APItest/KeywordRPN/KeywordRPN.so] Error 25

I used "class" as a variable name, but in C++ it's a keyword.  Patch
attached.  Someone should also add a note about C++ compatibility to
perlhack.pod.

-zefram

Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

14 years agorefine Carp caller() fix and add tests
David Golden [Sat, 7 Nov 2009 04:38:27 +0000]
refine Carp caller() fix and add tests

14 years agoAdd legacy.pm to Maintainers
Rafael Garcia-Suarez [Fri, 6 Nov 2009 23:19:11 +0000]
Add legacy.pm to Maintainers

14 years agoMerge branch 'legacy-pragma' into blead
Rafael Garcia-Suarez [Fri, 6 Nov 2009 22:54:29 +0000]
Merge branch 'legacy-pragma' into blead

Conflicts:
MANIFEST

14 years agobump Carp version number
David Golden [Fri, 6 Nov 2009 19:05:29 +0000]
bump Carp version number

14 years agoAddded a pointer to the documentation on how Configure is maintained
Jesse Vincent [Fri, 6 Nov 2009 18:04:01 +0000]
Addded a pointer to the documentation on how Configure is maintained

14 years agoAdd a line directive to op.c and perl.c such that error messages refer to the origina...
Gerard Goossen [Thu, 5 Nov 2009 21:57:20 +0000]
Add a line directive to op.c and perl.c such that error messages refer to the original files insted of to the copied files perlmini.c and opmini.c

14 years agoAdd a "return NORMAL" to a DIE at the end of a function to prevent compiler warnings...
Gerard Goossen [Fri, 6 Nov 2009 15:02:22 +0000]
Add a "return NORMAL" to a DIE at the end of a function to prevent compiler warnings (the "return NORMAL"s are never reached).

14 years agoCheck to see if there was a body which needs freeing using the old_type instead of...
Gerard Goossen [Mon, 2 Nov 2009 09:32:31 +0000]
Check to see if there was a body which needs freeing using the old_type instead of the arena flag, which is not set with PURIFY

14 years agoComplete the fix for Win32 link following commits 88e1f1a and 406ca27
Steve Hay [Fri, 6 Nov 2009 13:39:42 +0000]
Complete the fix for Win32 link following commits 88e1f1a and 406ca27

14 years agomove JMPENV_JUMP to die_where and mark it as "noreturn"
Gerard Goossen [Thu, 29 Oct 2009 11:27:49 +0000]
move JMPENV_JUMP to die_where and mark it as "noreturn"

14 years agoHave Carp respect CORE::GLOBAL::caller if it exists
David Golden [Wed, 4 Nov 2009 22:33:11 +0000]
Have Carp respect CORE::GLOBAL::caller if it exists

Carp frequently gets loaded very early, before tools that want to
override caller().  Previously, caller() was only in Carp::Heavy,
which was only loaded on demand (thus after any CORE::GLOBAL::caller
override).  This patch unbreaks anything expecting the old behavior.

14 years agoPartially fix Win32 link following commit 88e1f1a
Steve Hay [Fri, 6 Nov 2009 10:32:18 +0000]
Partially fix Win32 link following commit 88e1f1a

There is currently still a linker error about PL_keyword_plugin.

14 years agoDescribe how Configure patches should be done
H.Merijn Brand [Fri, 6 Nov 2009 07:20:01 +0000]
Describe how Configure patches should be done

14 years agoDetection (and warning) of char size in bits
H.Merijn Brand [Fri, 6 Nov 2009 06:56:01 +0000]
Detection (and warning) of char size in bits

14 years agoSvREFCNT_dec already checks if the SV is non-NULL
Vincent Pit [Thu, 5 Nov 2009 20:55:35 +0000]
SvREFCNT_dec already checks if the SV is non-NULL

14 years agoMention git resources in header
H.Merijn Brand [Thu, 5 Nov 2009 20:05:14 +0000]
Mention git resources in header
Use $cpp instead of cpp

14 years agoregen generated files changed by the previous patch - facility to plug in syntax...
Jesse Vincent [Thu, 5 Nov 2009 15:04:18 +0000]
regen generated files changed by the previous patch -  facility to plug in syntax triggered by keywords

14 years agoImplement facility to plug in syntax triggered by keywords
Jesse Vincent [Thu, 5 Nov 2009 16:14:45 +0000]
Implement facility to plug in syntax triggered by keywords

Date: Tue, 27 Oct 2009 01:29:40 +0000
From: Zefram <zefram@fysh.org>
To: perl5-porters@perl.org
Subject: bareword sub lookups

Attached is a patch that changes how the tokeniser looks up subroutines,
when they're referenced by a bareword, for prototype and const-sub
purposes.  Formerly, it has looked up bareword subs directly in the
package, which is contrary to the way the generated op tree looks up
the sub, via an rv2cv op.  The patch makes the tokeniser generate the
rv2cv op earlier, and dig around in that.

The motivation for this is to allow modules to hook the rv2cv op
creation, to affect the name->subroutine lookup process.  Currently,
such hooking affects op execution as intended, but everything goes wrong
with a bareword ref where the tokeniser looks at some unrelated CV,
or a blank space, in the package.  With the patch in place, an rv2cv
hook correctly affects the tokeniser and therefore the prototype-based
aspects of parsing.

The patch also changes ck_subr (which applies the argument context and
checking parts of prototype behaviour) to handle subs referenced by an
RV const op inside the rv2cv, where formerly it would only handle a gv
op inside the rv2cv.  This is to support the most likely kind of modified
rv2cv op.

[This commit includes the Makefile.PL for XS-APITest-KeywordRPN missing
from the original patch, as well as updates to perldiag.pod and a
MANIFEST sort]

14 years agoUpdated CPANPLUS::Dist::Build to cpan version 0.41_01
Chris Williams [Thu, 5 Nov 2009 14:41:01 +0000]
Updated CPANPLUS::Dist::Build to cpan version 0.41_01

14 years agoUpdated CPANPLUS to cpan version 0.89_07
Chris Williams [Thu, 5 Nov 2009 14:38:29 +0000]
Updated CPANPLUS to cpan version 0.89_07

14 years agoDocument qr overloading in perldelta
Rafael Garcia-Suarez [Wed, 4 Nov 2009 17:54:31 +0000]
Document qr overloading in perldelta

14 years agoDeprecate use of := to mean an empty attribute list in my $pi := 4;
Nicholas Clark [Wed, 4 Nov 2009 11:33:12 +0000]
Deprecate use of := to mean an empty attribute list in my $pi := 4;

An accident of Perl's parser meant that my $pi := 4; was parsed as an empty
attribute list. Empty attribute lists are ignored, hence the above is
equivalent to my $pi = 4; However, the fact that it is currently valid syntax
means that := cannot be used as new token, without silently changing the
meaning of existing code.

Hence it is now deprecated, so that it can subsequently be removed, allowing
the possibility of := to be used as a new token with new semantics.

14 years ago[PATCH] [perl #20321] Non-destructive Perl_av_make
Bo Borgerson [Mon, 2 Nov 2009 17:25:23 +0000]
[PATCH] [perl #20321] Non-destructive Perl_av_make

Don't let sv_setsv swipe temps in av_make, since the source array
might have multiple references to the same temp scalar (e.g. from
a list slice).

14 years agoSlow down split in scalar context :-)
Father Chrysostomos [Sun, 1 Nov 2009 20:28:45 +0000]
Slow down split in scalar context :-)

Here’s a patch to include the bug number in the test script.

And 68971 can be resolved, too. Sorry for the duplicate!

Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

14 years agoS_utf16_textfilter() was not returning EOF correctly in some situations.
Nicholas Clark [Sun, 1 Nov 2009 20:47:47 +0000]
S_utf16_textfilter() was not returning EOF correctly in some situations.

14 years agoTweak the filename regexp in parser.t so that ./TEST -utf16 op/parser.t passes.
Nicholas Clark [Sun, 1 Nov 2009 17:29:03 +0000]
Tweak the filename regexp in parser.t so that ./TEST -utf16 op/parser.t passes.

14 years agoRemove Perl_pmflag() from the public API, and mark it as deprecated.
Nicholas Clark [Sun, 1 Nov 2009 16:43:22 +0000]
Remove Perl_pmflag() from the public API, and mark it as deprecated.

regcomp.c stopped using it before 5.10, leaving only toke.c. The only code on
CPAN that uses it is copies of regcomp.c. Replace it with a static function,
with a cleaner interface.

14 years agoImprovements to qr-overload tests
Rafael Garcia-Suarez [Sun, 1 Nov 2009 15:42:47 +0000]
Improvements to qr-overload tests

- Fix test for error message
- Add negative test cases
- Remove unneeded evals

14 years agoBump overload.pm's VERSION (plus some spelling nits)
Rafael Garcia-Suarez [Sun, 1 Nov 2009 15:29:58 +0000]
Bump overload.pm's VERSION (plus some spelling nits)

14 years agoDocumentation for the 'qr' overload.
Ben Morrow [Tue, 27 Oct 2009 16:12:36 +0000]
Documentation for the 'qr' overload.

14 years agoImplement the 'qr' overload type.
Ben Morrow [Tue, 27 Oct 2009 15:55:36 +0000]
Implement the 'qr' overload type.

If this is defined, it will be called instead of stringification
whenever an object is used as a regexp or interpolated into a regexp.
This will fall back to stringification even without C<fallback => 1>,
for compatibility.

An overloaded 'qr' must return either a REGEXP or a ref to a REGEXP
(such as created by qr//). Any further overloading on the return value
will be ignored.

14 years agoAdd a new overload type, "qr".
Ben Morrow [Sat, 24 Oct 2009 13:58:33 +0000]
Add a new overload type, "qr".

14 years agoUse of SV* instead of message, msglen, utf8 to contain error message
Gerard Goossen [Thu, 29 Oct 2009 10:05:11 +0000]
Use of SV* instead of message, msglen, utf8 to contain error message

14 years agoRevert "Re: [perl #38809][PATCH] loss of stack elements with a do block inside a...
Steve Peters [Sun, 1 Nov 2009 00:52:35 +0000]
Revert "Re: [perl #38809][PATCH] loss of stack elements with a do block inside a return"

This reverts commit 60aa6a1aa894dd62b8194841a6d6c80c15079dba.

14 years agoRe: [perl #38809][PATCH] loss of stack elements with a do block inside a return
Vincent Pit [Sun, 1 Nov 2009 00:49:59 +0000]
Re: [perl #38809][PATCH] loss of stack elements with a do block inside a return

14 years ago[PATCH] Todo test for [perl #38133] (was: [regex] backref problem with quantified...
Bram via RT [Sun, 1 Nov 2009 00:33:04 +0000]
[PATCH] Todo test for [perl #38133] (was: [regex] backref problem with quantified groups)

This patch was modified to work with the updated file locations.

14 years ago[PATCH] extra tests for t/op/tie.t (was RE: [perl #53482] I believe I found a bug...
Bram [Sun, 1 Nov 2009 00:17:57 +0000]
[PATCH] extra tests for t/op/tie.t (was RE: [perl #53482] I believe I found a bug with Readonly::XS that might actually be a guts bug.)

14 years agoAdds additional tests with undef for smartmatch.
Yuval Kogman [Sun, 1 Nov 2009 00:02:00 +0000]
Adds additional tests with undef for smartmatch.

Updated plan count missing in the original patch.

14 years agoAdd assertion to JMPENV_POP to assert that the jumplevel popped is the top level...
Gerard Goossen [Fri, 30 Oct 2009 14:03:45 +0000]
Add assertion to JMPENV_POP to assert that the jumplevel popped is the top level jumplevel

14 years ago[perl #69875] Slow down split in scalar context :-)
Father Chrysostomos [Sat, 31 Oct 2009 15:15:08 +0000]
[perl #69875] Slow down split in scalar context :-)

The patch to speed up split in scalar context broke Font::GlyphNames,
because it stops scalar(@array = split) from working. The attached
patch fixes this, and ineluctably slows it down slightly.

(Patch amended by replacing the 2nd GIMME_V macro call by the gimme
variable)

14 years agoImprove warnings about known issues in (?{...}) blocks in the regex engine
Gerard Goossen [Tue, 27 Oct 2009 20:59:34 +0000]
Improve warnings about known issues in (?{...}) blocks in the regex engine

14 years agoremove all references to patching.pod
Dave Rolsky [Fri, 30 Oct 2009 16:13:10 +0000]
remove all references to patching.pod

14 years agoRefer to perlrepository.pod instead of patching.pod
Dave Rolsky [Fri, 30 Oct 2009 16:12:48 +0000]
Refer to perlrepository.pod instead of patching.pod

14 years agoFix another reference to the now-gone patching.pod
Dave Rolsky [Fri, 30 Oct 2009 16:11:51 +0000]
Fix another reference to the now-gone patching.pod

14 years agoRemove obsolete details on how to format a patch. Just point to perlrepository instead.
Dave Rolsky [Fri, 30 Oct 2009 16:10:10 +0000]
Remove obsolete details on how to format a patch. Just point to perlrepository instead.

14 years agoClarify relationship of pattern modifiers and named subpatterns
Dave Rolsky [Fri, 30 Oct 2009 16:09:08 +0000]
Clarify relationship of pattern modifiers and named subpatterns

14 years agoUpdated ExtUtils::CBuilder to 0.27
David Golden [Fri, 30 Oct 2009 01:40:33 +0000]
Updated ExtUtils::CBuilder to 0.27

0.27 - Thu Oct 29 21:29:56 EDT 2009

 Other:
 - Removed Build.PL to avoid creating a circular dependency
 - Added version numbers to Windows compiler driver modules

0.26_05 - Sun Oct 25 17:29:02 EDT 2009

 Bugs fixed:
 - Fixed t/02link.t failures on cygwin with Perl 5.8 [David Golden]

 Other:
 - Made have_compiler (and have_cplusplus) quiet without echoing
   the test command to STDOUT [David Golden]

0.26_04 - Mon Oct 19 21:57:46 EDT 2009

 Enhancements:
 - Added 'have_cplusplus()' method to check for C++ support
 - Added patches for building Perl with mingw64 [Sisyphus]
 - Allow CC environment variable to override $Config{cc}

 Bugs fixed:
 - Fixed link executable command for Win32 MSVC (RT#40819) [Cosimo
   Streppone]
 - Removed MSVC version check when embedding a manifest file
   (RT #43002) [Steve Hay]

 Other:
 - Split Windows compiler driver packages into individual *.pm files

14 years agoPropagate LDLIBPTH into run_tests - Fixes 5.12 blocker [perl #70057]
Jesse Vincent [Fri, 30 Oct 2009 01:37:44 +0000]
Propagate LDLIBPTH into run_tests - Fixes 5.12 blocker [perl #70057]

I'm leaving the bug open as it sounds like there's a better fix that
could go into Configure that Andy mentioned wanting to make. But I'm
removing the 5.12 blocking nature of the bug;

14 years ago[PATCH] perlcommunity.pod: add information about OSDC.fr
Philippe Bruhat (BooK) [Thu, 29 Oct 2009 20:59:07 +0000]
[PATCH] perlcommunity.pod: add information about OSDC.fr

14 years agoAllow syswrite with offset same as length of string [perl #70095]
Gisle Aas [Thu, 29 Oct 2009 20:30:02 +0000]
Allow syswrite with offset same as length of string [perl #70095]

You are not really outside of the string then, but the effect will
always be a noop since the number of bytes written will be capped
to not exceed the length of the string as for other offsets.

14 years agoUpdate CPANPLUS to cpan version 0.89_06
Chris Williams [Thu, 29 Oct 2009 15:09:29 +0000]
Update CPANPLUS to cpan version 0.89_06

  Changes for 0.89_06     Thu Oct 29 14:55:25 2009
  ================================================
  * Fool the installer into replacing our scripts that were installed
    by core with versiononly set.
  * Handle PREREQS being mentioned twice in Makefile. Use _vcmp()
    to compare the versions, take the highest.

14 years agoRemove unused variable
Rafael Garcia-Suarez [Thu, 29 Oct 2009 09:52:53 +0000]
Remove unused variable

14 years agoremove unnecessary (always true) condition in S_vdie
Gerard Goossen [Wed, 28 Oct 2009 17:46:06 +0000]
remove unnecessary (always true) condition in S_vdie

14 years agoUpdate Module::Load::Conditional to cpan version 0.34
Chris Williams [Thu, 29 Oct 2009 09:30:42 +0000]
Update Module::Load::Conditional to cpan version 0.34

  Changes for 0.34    Thu Oct 29 09:22:48 GMT 2009
  =================================================
  * Remove DOS line endings from test files RT#50926
    reported by Steve Hay

14 years agoConvert all Pod::Simple files to Unix line endings.
David E. Wheeler [Wed, 28 Oct 2009 19:34:00 +0000]
Convert all Pod::Simple files to Unix line endings.

In response to Steve Hay's report in
[RT #50922](https://rt.cpan.org/Ticket/Display.html?id=50922).

14 years agoBump Exporter's version in blead after last patch
Rafael Garcia-Suarez [Wed, 28 Oct 2009 21:20:17 +0000]
Bump Exporter's version in blead after last patch

14 years agoTest exported arrays and hashes without using defined()
Jerry D. Hedden [Tue, 27 Oct 2009 17:25:51 +0000]
Test exported arrays and hashes without using defined()

14 years agoAdd missing files
Rafael Garcia-Suarez [Wed, 28 Oct 2009 10:34:46 +0000]
Add missing files

14 years agoBring Pod::Simple up to 3.09 as on CPAN.
David E. Wheeler [Tue, 27 Oct 2009 19:09:33 +0000]
Bring Pod::Simple up to 3.09 as on CPAN.

14 years ago$#array should be accepted as a lvalue sub return value.
Rafael Garcia-Suarez [Wed, 28 Oct 2009 09:44:31 +0000]
$#array should be accepted as a lvalue sub return value.

The OPpMAYBE_LVSUB flag wasn't set for OP_AV2ARYLEN, but the
new implementation of pp_av2arylen introduced by the previous
patch was relying on it. So, now, set this flag. Also add tests for
STORESIZE.

14 years agoAvoid adding magic with rvalue $#a
Eric Brine [Fri, 23 Oct 2009 23:05:40 +0000]
Avoid adding magic with rvalue $#a

14 years agoUpdate CPANPLUS to cpan version 0.89_05
Chris Williams [Tue, 27 Oct 2009 10:07:35 +0000]
Update CPANPLUS to cpan version 0.89_05

  Changes for 0.89_05     Tue Oct 27 09:24:55 2009
  ================================================
  * Change the way editing config files is called. This fixes RT #50832,
    reported by Dave Golden
  * Issue a warning in the shell if we are on MSWin32, don't have IPC::Run
    installed and are writing a log file.
  * Apply several patches from Alexandr Ciornii (CHORNY) RT #48636 that
    add toolchain versions listing to tester reports.

14 years agoBetter wording for the hash ~~ array docs
Rafael Garcia-Suarez [Tue, 27 Oct 2009 08:58:58 +0000]
Better wording for the hash ~~ array docs

(suggested by Aristotle Pagaltzis -- see [perl #69957])

14 years agoadd an elipses to string/ref warnings when str longer than 32 chars
Yves Orton [Mon, 26 Oct 2009 20:52:05 +0000]
add an elipses to string/ref warnings when str longer than 32 chars

Wasted a few minutes more than necessary trying to work out why the
string was truncated when in fact it was the error message that was
truncating the string.

14 years agorefine the documentation for deleting branches and altering history
Yves Orton [Mon, 26 Oct 2009 21:50:24 +0000]
refine the documentation for deleting branches and altering history

14 years agoHashed out a prose description of the (largely existing) branching and topic branch...
Jesse Vincent [Mon, 26 Oct 2009 20:08:19 +0000]
Hashed out a prose description of the (largely existing) branching and topic branch policy.

Wrote down the existing "no, don't mess with blead's history, bozo"
setup

14 years agomg.c uses a fixed NGROUPS contant
perlbug-followup@perl.org [Fri, 23 Oct 2009 15:20:38 +0000]
mg.c uses a fixed NGROUPS contant

# New Ticket Created by  casper.dik@sun.com
# Please include the string:  [perl #69977]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=69977 >

This is a bug report for perl from casper.dik@sun.com,
generated with the help of perlbug 1.36 running under perl 5.10.0.

-----------------------------------------------------------------
[Please enter your report here]

In mg.c NGROUPS is defined as follows:

#if defined(HAS_SETGROUPS)
#  ifndef NGROUPS
#    define NGROUPS 32
#  endif
#endif

and uses it later here:

  2632  #ifdef HAS_SETGROUPS
  2633          {
  2634              const char *p = SvPV_const(sv, len);
  2635              Groups_t *gary = NULL;
  2636
  2637              while (isSPACE(*p))
  2638                  ++p;
  2639              PL_egid = Atol(p);
  2640              for (i = 0; i < NGROUPS; ++i) {
  2641                  while (*p && !isSPACE(*p))
  2642                      ++p;
  2643                  while (isSPACE(*p))
  2644                      ++p;
  2645                  if (!*p)
  2646                      break;
  2647                  if(!gary)
  2648                      Newx(gary, i + 1, Groups_t);
  2649                  else
  2650                      Renew(gary, i + 1, Groups_t);
  2651                  gary[i] = Atol(p);
  2652              }
  2653              if (i)
  2654                  (void)setgroups(i, gary);
  2655              Safefree(gary);
  2656          }
  2657  #else  /* HAS_SETGROUPS */

This should be changed as follows

14 years agodisable non-unicode case insensitive trie matching
Yves Orton [Sun, 25 Oct 2009 19:37:08 +0000]
disable non-unicode case insensitive trie matching

Also revert 8902bb05b18c9858efa90229ca1ee42b17277554 as it merely
masked one symptom of the deeper problems.

Also fixes RT #69973, which was a segfault which was exposed by
8902bb05, see the ticket for further details.

http://rt.perl.org/rt3//Public/Bug/Display.html?id=69973

At the code of this is the problem that in unicode matching a bunch
of code points have case folding rules beyond just A-Z/a-z. Since
the case folding rules are decided at runtime by the string, we cant
use the same TRIE tables for both unicode/non-unicode matching.

Until this is reconciled or some other solution is found case insensitive
matching only gets the TRIE optimisation when the pattern is uniocde.

From CaseFolding.txt:

00B5; C; 03BC; # MICRO SIGN
00C0; C; 00E0; # LATIN CAPITAL LETTER A WITH GRAVE
00C1; C; 00E1; # LATIN CAPITAL LETTER A WITH ACUTE
00C2; C; 00E2; # LATIN CAPITAL LETTER A WITH CIRCUMFLEX
00C3; C; 00E3; # LATIN CAPITAL LETTER A WITH TILDE
00C4; C; 00E4; # LATIN CAPITAL LETTER A WITH DIAERESIS
00C5; C; 00E5; # LATIN CAPITAL LETTER A WITH RING ABOVE
00C6; C; 00E6; # LATIN CAPITAL LETTER AE
00C7; C; 00E7; # LATIN CAPITAL LETTER C WITH CEDILLA
00C8; C; 00E8; # LATIN CAPITAL LETTER E WITH GRAVE
00C9; C; 00E9; # LATIN CAPITAL LETTER E WITH ACUTE
00CA; C; 00EA; # LATIN CAPITAL LETTER E WITH CIRCUMFLEX
00CB; C; 00EB; # LATIN CAPITAL LETTER E WITH DIAERESIS
00CC; C; 00EC; # LATIN CAPITAL LETTER I WITH GRAVE
00CD; C; 00ED; # LATIN CAPITAL LETTER I WITH ACUTE
00CE; C; 00EE; # LATIN CAPITAL LETTER I WITH CIRCUMFLEX
00CF; C; 00EF; # LATIN CAPITAL LETTER I WITH DIAERESIS
00D0; C; 00F0; # LATIN CAPITAL LETTER ETH
00D1; C; 00F1; # LATIN CAPITAL LETTER N WITH TILDE
00D2; C; 00F2; # LATIN CAPITAL LETTER O WITH GRAVE
00D3; C; 00F3; # LATIN CAPITAL LETTER O WITH ACUTE
00D4; C; 00F4; # LATIN CAPITAL LETTER O WITH CIRCUMFLEX
00D5; C; 00F5; # LATIN CAPITAL LETTER O WITH TILDE
00D6; C; 00F6; # LATIN CAPITAL LETTER O WITH DIAERESIS
00D8; C; 00F8; # LATIN CAPITAL LETTER O WITH STROKE
00D9; C; 00F9; # LATIN CAPITAL LETTER U WITH GRAVE
00DA; C; 00FA; # LATIN CAPITAL LETTER U WITH ACUTE
00DB; C; 00FB; # LATIN CAPITAL LETTER U WITH CIRCUMFLEX
00DC; C; 00FC; # LATIN CAPITAL LETTER U WITH DIAERESIS
00DD; C; 00FD; # LATIN CAPITAL LETTER Y WITH ACUTE
00DE; C; 00FE; # LATIN CAPITAL LETTER THORN
00DF; F; 0073 0073; # LATIN SMALL LETTER SHARP S

14 years agoRename to Porting/perldelta_template.pod so that t/porting/podcheck.t covers it.
Nicholas Clark [Sat, 24 Oct 2009 11:14:31 +0000]
Rename to Porting/perldelta_template.pod so that t/porting/podcheck.t covers it.

14 years agoNote that F<ext/> has become F<cpan/>, F<dist/> and F<ext/>
Nicholas Clark [Sat, 24 Oct 2009 11:12:42 +0000]
Note that F<ext/> has become F<cpan/>, F<dist/> and F<ext/>

14 years agoIn S_pending_ident(), only call gv_fetchpvn_flags() if the warning is enabled.
Nicholas Clark [Sat, 24 Oct 2009 11:57:18 +0000]
In S_pending_ident(), only call gv_fetchpvn_flags() if the warning is enabled.

ckWARN(WARN_AMBIGUOUS) is cheaper than Perl_gv_fetchpvn_flags().

14 years agoMake defined %hash on a non-lexical (also) generate a deprecated warning.
Nicholas Clark [Sat, 24 Oct 2009 09:25:28 +0000]
Make defined %hash on a non-lexical (also) generate a deprecated warning.

Tk has been fixed, and no longer uses defined %stash:: to determine if a package
has been loaded.

14 years agoAdd perl5112delta, and change 5111delta from being "the" perldelta.
Nicholas Clark [Sat, 24 Oct 2009 09:23:05 +0000]
Add perl5112delta, and change 5111delta from being "the" perldelta.

14 years agoIn Locale::Maketext, avoid using defined @array and defined %hash.
Nicholas Clark [Fri, 23 Oct 2009 20:30:43 +0000]
In Locale::Maketext, avoid using defined @array and defined %hash.

14 years agoIn I18N::LangTags::Detect, avoid using defined @array and defined %hash.
Nicholas Clark [Fri, 23 Oct 2009 20:33:27 +0000]
In I18N::LangTags::Detect, avoid using defined @array and defined %hash.

14 years agoAvoid using defined @array in core tests.
Nicholas Clark [Fri, 23 Oct 2009 20:30:18 +0000]
Avoid using defined @array in core tests.

14 years agoAvoid using defined %hash in core code and tests.
Nicholas Clark [Fri, 23 Oct 2009 20:29:49 +0000]
Avoid using defined %hash in core code and tests.

14 years agoUpdated Module::Load::Conditional to cpan version 0.32
Chris Williams [Fri, 23 Oct 2009 21:00:37 +0000]
Updated Module::Load::Conditional to cpan version 0.32

14 years agoCap the exit code of the bisecting script
Vincent Pit [Fri, 23 Oct 2009 20:34:04 +0000]
Cap the exit code of the bisecting script

Segfaults cause $? to be set to 139 on my machine, which stops the bisect
process.

14 years ago"-x ./foo" isn't a shell command, but "[ -x ./foo ]" is
Vincent Pit [Fri, 23 Oct 2009 20:26:57 +0000]
"-x ./foo" isn't a shell command, but "[ -x ./foo ]" is

14 years agoConvert the 2 Storable tests that use Test to use Test::More.
Nicholas Clark [Fri, 23 Oct 2009 19:58:28 +0000]
Convert the 2 Storable tests that use Test to use Test::More.

14 years agoConvert the Pod::Perldoc tests from Test to Test::More.
Nicholas Clark [Fri, 23 Oct 2009 19:52:39 +0000]
Convert the Pod::Perldoc tests from Test to Test::More.

Not that they test much, other than require of the various modules.

14 years agoConvert the odd Locale::Maketext test out from Test to Test::More.
Nicholas Clark [Fri, 23 Oct 2009 19:44:42 +0000]
Convert the odd Locale::Maketext test out from Test to Test::More.

All the others were using Test::More already.

14 years agoConvert File/CheckTree.t from Test to Test::More.
Nicholas Clark [Fri, 23 Oct 2009 18:37:25 +0000]
Convert File/CheckTree.t from Test to Test::More.

14 years agoConvert tests in ext/ from Test to Test::More.
Nicholas Clark [Fri, 23 Oct 2009 17:32:22 +0000]
Convert tests in ext/ from Test to Test::More.