15 years ago * Removed dead code (sub _RowNumberOver).
Norbert Buchmuller [Tue, 11 Nov 2008 06:00:44 +0000]
 * Removed dead code (sub _RowNumberOver).

15 years ago * Removed a wrong TODO test: "order_by with quoting needs fixing (ash/castaway)...
Norbert Buchmuller [Tue, 11 Nov 2008 06:00:18 +0000]
 * Removed a wrong TODO test: "order_by with quoting needs fixing (ash/castaway)" (asked by mst).
 * Made a TODO test non-TODO: "select attr with star needs fixing (mst/nate)" (works with SQLA 1.50).

15 years ago * Converted some of the test cases to use SQL::Abstract::Test.
Norbert Buchmuller [Tue, 11 Nov 2008 05:59:32 +0000]
 * Converted some of the test cases to use SQL::Abstract::Test.
 * Added the parens for the join condition (SQL::Abstract::Test can't cope with it, and, besides, they help readability there; plus this gives the same output that older SQLA generated).

15 years agochanged the way we get the DSN for debugging in replication
John Napiorkowski [Mon, 10 Nov 2008 16:12:28 +0000]
changed the way we get the DSN for debugging in replication

15 years agoSwitch schema management version calls from VERSION() to schema_version()
Peter Rabbitson [Sun, 9 Nov 2008 20:19:39 +0000]
Switch schema management version calls from VERSION() to schema_version()

15 years agoDon't rely on connect_info(), instead fetch the dsn from _dbi_connect_info (which...
Peter Rabbitson [Sun, 9 Nov 2008 16:02:05 +0000]
Don't rely on connect_info(), instead fetch the dsn from _dbi_connect_info (which is stable no matter which connect_info() flavor is used)
todo: ping jnpiorkowski about Replicated::Pool and Replicated::Replicant - it blindly assumes that connect_info->[0] contains the dsn, which might not be the case. Even when using _dbi_connect_info, the first element might be a coderef

15 years agoFix detection of multiple rows being returned for single(): calling fetchrow_array...
Peter Rabbitson [Sun, 9 Nov 2008 15:35:30 +0000]
Fix detection of multiple rows being returned for single(): calling fetchrow_array in scalar context leads to indefined results (search.cpan.org/~timb/DBI/DBI.pm#fetchrow_array)

15 years agoSome testdb changes and alignment, preparing for test refactor branch
Peter Rabbitson [Sun, 9 Nov 2008 15:29:34 +0000]
Some testdb changes and alignment, preparing for test refactor branch

15 years agoSQLT behaves sanely in scalar context, no need for stupid version detections (ribasus...
Peter Rabbitson [Sun, 9 Nov 2008 15:27:40 +0000]
SQLT behaves sanely in scalar context, no need for stupid version detections (ribasushi--)

15 years agoMore TODO items
Peter Rabbitson [Sun, 9 Nov 2008 13:35:57 +0000]
More TODO items

16 years agoOne extra multicreate test and some cleanup
Peter Rabbitson [Fri, 7 Nov 2008 09:42:48 +0000]
One extra multicreate test and some cleanup

16 years agoFix loss of objects on multicreate over several 1:M relations
Peter Rabbitson [Fri, 7 Nov 2008 07:30:49 +0000]
Fix loss of objects on multicreate over several 1:M relations

16 years agoFinal insanification of the multicreate test
Peter Rabbitson [Fri, 7 Nov 2008 07:29:21 +0000]
Final insanification of the multicreate test

16 years agounhide SQL::Translator::Parser::DBIx::Class from pause indexer
Steffen Schwigon [Thu, 6 Nov 2008 21:59:42 +0000]
unhide SQL::Translator::Parser::DBIx::Class from pause indexer

16 years agopod documentation for SQL::Translator::Parser::DBIx::Class
Steffen Schwigon [Thu, 6 Nov 2008 20:23:22 +0000]
pod documentation for SQL::Translator::Parser::DBIx::Class

16 years agoA little indentation clean up
Michael G Schwern [Thu, 6 Nov 2008 12:44:36 +0000]
A little indentation clean up

Test the result of an eval directly.

discard the changes to $sandl to quiet an "object destroyed with changes"
warning.

16 years agomk_group_accessor() is sometimes called internally when inflating a column
Michael G Schwern [Thu, 6 Nov 2008 12:44:27 +0000]
mk_group_accessor() is sometimes called internally when inflating a column
and with an array ref field spec, but the accessor and column names are
the same.  Special case that to go through the usual accessor_name_for stuff.

16 years ago[rt.cpan.org 36863]
Michael G Schwern [Tue, 4 Nov 2008 18:26:41 +0000]
[rt.cpan.org 36863]
Fix mk_group_accessors() to handle [$field, $name].  It ignores
accessor/mutator_name_for() because if you pass in your own accessor
name you probably mean it.

16 years agoNormalize indentation
Michael G Schwern [Tue, 4 Nov 2008 18:26:29 +0000]
Normalize indentation

16 years agoAnd now really untabify
Michael G Schwern [Tue, 4 Nov 2008 18:26:19 +0000]
And now really untabify

16 years agonormalize the indentation and detabify
Michael G Schwern [Tue, 4 Nov 2008 18:26:09 +0000]
normalize the indentation and detabify

16 years agofixed 73oracle.t
Johannes Plunien [Tue, 4 Nov 2008 16:22:51 +0000]
fixed 73oracle.t

16 years agoTest prompted by discussion about tasty stuff
Peter Rabbitson [Sun, 2 Nov 2008 16:55:31 +0000]
Test prompted by discussion about tasty stuff

16 years agoBetter linking in Relatiomship POD
Peter Rabbitson [Sun, 2 Nov 2008 16:54:46 +0000]
Better linking in Relatiomship POD

16 years agoMore svn:ignore
Peter Rabbitson [Sun, 2 Nov 2008 13:32:26 +0000]
More svn:ignore

16 years agoClarify Relationship POD
Peter Rabbitson [Sun, 2 Nov 2008 13:30:49 +0000]
Clarify Relationship POD

16 years agorefactor of t/96multi_create.t:
Peter Rabbitson [Sun, 2 Nov 2008 12:28:02 +0000]
refactor of t/96multi_create.t:
- simplify test case submitted by wreis
- incorporate it into the large multicreate at the end
- eval{} independent sections of the test so more output can be gathered

16 years agoAugment commit r5037 - the column_info feature on SQLite is not buggy but partially...
Peter Rabbitson [Sat, 1 Nov 2008 20:58:07 +0000]
Augment commit r5037 - the column_info feature on SQLite is not buggy but partially unimplemented

16 years agorolling back my last change, waiting until new sqlt is on cpan
Johannes Plunien [Sun, 2 Nov 2008 01:59:49 +0000]
rolling back my last change, waiting until new sqlt is on cpan

16 years agofixed next warnings
Johannes Plunien [Sun, 2 Nov 2008 01:37:21 +0000]
fixed next warnings

16 years agoupdated Changes
Johannes Plunien [Sun, 2 Nov 2008 01:22:09 +0000]
updated Changes

16 years agosplit sql statements for deploy only if SQLT::Producer returned a scalar
Johannes Plunien [Sun, 2 Nov 2008 01:19:09 +0000]
split sql statements for deploy only if SQLT::Producer returned a scalar

16 years agoTODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite...
Peter Rabbitson [Sat, 1 Nov 2008 14:23:15 +0000]
TODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite versions

16 years agoadded failing test case for multi create
Wallace Reis [Sat, 1 Nov 2008 00:42:56 +0000]
added failing test case for multi create

16 years agoKill the install process at the MakeMaker stage if a dodgy DBD::SQLite is detected
Peter Rabbitson [Fri, 31 Oct 2008 23:36:02 +0000]
Kill the install process at the MakeMaker stage if a dodgy DBD::SQLite is detected

16 years ago68inflate_has_a.t tests the cdbi-compat shim and thus belongs in t/cdbi-t
Peter Rabbitson [Fri, 31 Oct 2008 20:34:27 +0000]
68inflate_has_a.t tests the cdbi-compat shim and thus belongs in t/cdbi-t
bumped up the version of DBD::SQLite required for testing

16 years agoAdjust MANIFEST.SKIP
Peter Rabbitson [Fri, 31 Oct 2008 11:22:38 +0000]
Adjust MANIFEST.SKIP

16 years agoCleanup TODO, delete implemented VERSIONING.SKETCH
Peter Rabbitson [Fri, 31 Oct 2008 11:21:41 +0000]
Cleanup TODO, delete implemented VERSIONING.SKETCH

16 years agoIt seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which...
Peter Rabbitson [Fri, 31 Oct 2008 00:26:58 +0000]
It seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which return unexpected column info - fixing. Should take care of:
http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525124.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525137.html

16 years agoDev-Release 0.08099_05
Peter Rabbitson [Thu, 30 Oct 2008 21:30:47 +0000]
Dev-Release 0.08099_05

16 years agoFinal set of DBI docfixes
Peter Rabbitson [Thu, 30 Oct 2008 21:26:00 +0000]
Final set of DBI docfixes

16 years agoDocumentation fixups, still needs standardising though
Jess Robinson [Thu, 30 Oct 2008 21:10:05 +0000]
Documentation fixups, still needs standardising though

16 years agoFix some lapses in Storage::DBI pod
Peter Rabbitson [Thu, 30 Oct 2008 15:26:36 +0000]
Fix some lapses in Storage::DBI pod

16 years agoadd some things to castaway's rewrite
Peter Rabbitson [Thu, 30 Oct 2008 12:41:04 +0000]
add some things to castaway's rewrite

16 years agoAdd new TODO items
Peter Rabbitson [Thu, 30 Oct 2008 12:36:54 +0000]
Add new TODO items

16 years agoTest direct sql passed to ResultSetColumn
Peter Rabbitson [Thu, 30 Oct 2008 12:26:05 +0000]
Test direct sql passed to ResultSetColumn

16 years agoMassive cleanup of Storage::DBI::connect_info, based on patches from Oleg Kostyk
Peter Rabbitson [Thu, 30 Oct 2008 11:20:09 +0000]
Massive cleanup of Storage::DBI::connect_info, based on patches from Oleg Kostyk

16 years agoStandardising and improving Row's docs. Added cross linking etc.
Jess Robinson [Wed, 29 Oct 2008 21:09:49 +0000]
Standardising and improving Row's docs. Added cross linking etc.

16 years agoMinor chaining patch + test by Norbert Buchmuller (chaining needs a massive cleanup...
Peter Rabbitson [Wed, 29 Oct 2008 11:18:44 +0000]
Minor chaining patch + test by Norbert Buchmuller (chaining needs a massive cleanup, delayed until next release)

16 years agoYet more RH perf bug test tweaks
Nigel Metheringham [Tue, 28 Oct 2008 13:37:02 +0000]
Yet more RH perf bug test tweaks

16 years agoReworked RH perf test to be more targetted
Nigel Metheringham [Tue, 28 Oct 2008 13:07:44 +0000]
Reworked RH perf test to be more targetted

16 years agoFix an obscure bug in the DBI exception handler, clobbering the exception contents...
Peter Rabbitson [Tue, 28 Oct 2008 12:32:52 +0000]
Fix an obscure bug in the DBI exception handler, clobbering the exception contents when the same $dbh is used outside of dbic code

16 years agoSkip tests if DateTime is not installed.
Tom Hukins [Tue, 28 Oct 2008 11:11:20 +0000]
Skip tests if DateTime is not installed.

16 years agoMerge 'doc_mods' into 'trunk'
Nigel Metheringham [Tue, 28 Oct 2008 09:22:42 +0000]
Merge 'doc_mods' into 'trunk'

Merged in changes to StartupCheck, documentation and tests for Red Hat perl performance issues

16 years agoMerge 'doc_mods' into 'trunk'
Nigel Metheringham [Tue, 28 Oct 2008 09:21:33 +0000]
Merge 'doc_mods' into 'trunk'

Merged in documentation modifications for Intro and Example to use load_namespaces syntax

16 years agoMissing semicolon
Nigel Metheringham [Tue, 28 Oct 2008 09:08:29 +0000]
Missing semicolon

16 years agoMinor RH perf bug test tweaks including internal documentation
Nigel Metheringham [Tue, 28 Oct 2008 09:00:31 +0000]
Minor RH perf bug test tweaks including internal documentation

16 years agoMinor tweaks to RH perf issue stuff following suggestions from ribasushi>
Nigel Metheringham [Mon, 27 Oct 2008 21:55:55 +0000]
Minor tweaks to RH perf issue stuff following suggestions from ribasushi>

16 years agoReworked information on RH perl performance issues
Nigel Metheringham [Mon, 27 Oct 2008 21:42:51 +0000]
Reworked information on RH perl performance issues

16 years agodirty_column detection in set_column() should not depend on the (undocumented) return...
Peter Rabbitson [Mon, 27 Oct 2008 17:27:40 +0000]
dirty_column detection in set_column() should not depend on the (undocumented) return value of store_column()

16 years agoupdated last changes of InflateColumn::DateTime
Johannes Plunien [Sun, 26 Oct 2008 23:38:27 +0000]
updated last changes of InflateColumn::DateTime

16 years agoImprove IC::DT timezone checker POD, add note explaining code weirdness
Peter Rabbitson [Sun, 26 Oct 2008 17:32:11 +0000]
Improve IC::DT timezone checker POD, add note explaining code weirdness

16 years agotypo in pod
Johannes Plunien [Sun, 26 Oct 2008 21:32:29 +0000]
typo in pod

16 years agoreferencing DateTime/Floating_DateTimes
Johannes Plunien [Sun, 26 Oct 2008 21:31:17 +0000]
referencing DateTime/Floating_DateTimes

16 years agousing local on SIG handler
Johannes Plunien [Sun, 26 Oct 2008 21:24:18 +0000]
using local on SIG handler

16 years agofloating timezone warning
Johannes Plunien [Sun, 26 Oct 2008 20:57:28 +0000]
floating timezone warning

16 years agoReworked Manual::Intro to use load_namecpaces
Nigel Metheringham [Sun, 26 Oct 2008 12:47:10 +0000]
Reworked Manual::Intro to use load_namecpaces

16 years agoUpdated example to use load_namespace
Nigel Metheringham [Sun, 26 Oct 2008 12:13:17 +0000]
Updated example to use load_namespace

16 years agoModified example to use load_namespace with default naming rather than load_classes
Nigel Metheringham [Sun, 26 Oct 2008 11:59:35 +0000]
Modified example to use load_namespace with default naming rather than load_classes

16 years agorafl refactored last changes
Johannes Plunien [Sat, 25 Oct 2008 03:11:43 +0000]
rafl refactored last changes

16 years agoadded myself to CONTRIBUTORS
Johannes Plunien [Sat, 25 Oct 2008 02:39:36 +0000]
added myself to CONTRIBUTORS

16 years agopossible to explicitly skip inflation, again rafl++
Johannes Plunien [Sat, 25 Oct 2008 02:33:59 +0000]
possible to explicitly skip inflation, again rafl++

16 years agoadded new option to enforce Date or DateTime inflation, no matter what type the colum...
Johannes Plunien [Sat, 25 Oct 2008 02:05:00 +0000]
added new option to enforce Date or DateTime inflation, no matter what type the column is, rafl++ for having this idea

16 years agocomplete a test
Peter Rabbitson [Fri, 24 Oct 2008 14:32:17 +0000]
complete a test

16 years agoMassive multi-create testing, with two regression fixes:
Peter Rabbitson [Fri, 24 Oct 2008 13:29:08 +0000]
Massive multi-create testing, with two regression fixes:
- An uninserted row must be passed to find_or_create_related with all uninserted objects on which it depends. Since currently we store those in {_inflated_column} as opposed to {_relationship_data} as we should, a simple ->get_inflated_columns will suffice
- We must find_or_create related rows, as find_or_new might queue multiple identical objects for insertions, which will subsequently violate existing unique constraints

16 years agoMore test schema relations for future tests
Peter Rabbitson [Fri, 24 Oct 2008 13:23:33 +0000]
More test schema relations for future tests

16 years agoCount warnings differently, as SQLT produces some weird stuff under 5.10. All of...
Peter Rabbitson [Fri, 24 Oct 2008 13:21:40 +0000]
Count warnings differently, as SQLT produces some weird stuff under 5.10. All of this will be fixed after the test refactor

16 years agoAnnoying DBD::SQLite warning is tripping up Test::NoWarnings.
Michael G Schwern [Fri, 24 Oct 2008 03:00:57 +0000]
Annoying DBD::SQLite warning is tripping up Test::NoWarnings.
Work around it.

16 years agoUsing DBIx::Class as a parent causes Class::Accessor::Grouped to be
Michael G Schwern [Fri, 24 Oct 2008 02:54:25 +0000]
Using DBIx::Class as a parent causes Class::Accessor::Grouped to be
introduced to the hierarchy too early and thus CDBICompat::AccessorMapping's
own mk_group_accessor() not get called.

The only reason we're inheriting from DBIx::Class is to get mk_classdata().
Get it from Class::Data::Inheritable instead.  mk_classdata() should be
moved out of DBIx::Class into a role to avoid this problem.

16 years agoAdded warnning to $rs->delete which fires if delete is done on a joined/chained resultset
Nigel Metheringham [Thu, 23 Oct 2008 15:00:06 +0000]
Added warnning to $rs->delete which fires if delete is done on a joined/chained resultset

16 years agoMinor wording fix
Nigel Metheringham [Thu, 23 Oct 2008 14:53:17 +0000]
Minor wording fix

16 years agoFailing tests for multicreate over m2m (passes with 0.08010)
Peter Rabbitson [Thu, 16 Oct 2008 18:29:38 +0000]
Failing tests for multicreate over m2m (passes with 0.08010)

16 years agopatch ->delete to die if args
Simon Elliott [Thu, 16 Oct 2008 13:41:18 +0000]
patch ->delete to die if args

16 years agoFix omission in pg test
Peter Rabbitson [Sun, 12 Oct 2008 21:56:50 +0000]
Fix omission in pg test

16 years agoDowngrading multi-prefetch exception to a warning as per Moritz Onken, adjusting...
Peter Rabbitson [Sun, 12 Oct 2008 21:54:53 +0000]
Downgrading multi-prefetch exception to a warning as per Moritz Onken, adjusting tests

16 years agoTODOify the 'upgrade twice within a second' problem in Schema::Versioned
Peter Rabbitson [Sun, 12 Oct 2008 21:26:54 +0000]
TODOify the 'upgrade twice within a second' problem in Schema::Versioned

16 years agoModernised and rearranged docs massively into a saner order.
Jess Robinson [Sat, 11 Oct 2008 17:07:00 +0000]
Modernised and rearranged docs massively into a saner order.

16 years agoModernise docs
Jess Robinson [Sat, 11 Oct 2008 14:56:14 +0000]
Modernise docs

16 years agoAdd new column with a default to Artist, adjust tests as necessary (no functional...
Peter Rabbitson [Thu, 9 Oct 2008 11:47:39 +0000]
Add new column with a default to Artist, adjust tests as necessary (no functional changes)

16 years agoRegenerate (finally\!) t/lib/sqlite.sql
Peter Rabbitson [Thu, 9 Oct 2008 11:19:28 +0000]
Regenerate (finally\!) t/lib/sqlite.sql
Fix maint/gen-schema to work correctly with newer SQL::Translators

16 years agoMinor documentation patch by Flavio Poletti - remove useless prefetch from examples
Peter Rabbitson [Wed, 8 Oct 2008 09:46:18 +0000]
Minor documentation patch by Flavio Poletti - remove useless prefetch from examples

16 years agoAdd documentation to indicate that calling find, find_or_new, find_or_create or updat...
Jess Robinson [Tue, 7 Oct 2008 22:17:14 +0000]
Add documentation to indicate that calling find, find_or_new, find_or_create or update_or_create with primary key values of undef, is a bad idea.

16 years agoincrease Test::Warn dependency
Matt S Trout [Tue, 7 Oct 2008 17:32:00 +0000]
increase Test::Warn dependency

16 years agoSilence SQLite ->disconnect warnings
Peter Rabbitson [Tue, 7 Oct 2008 14:15:03 +0000]
Silence SQLite ->disconnect warnings

16 years agoMerge 'warnfree' into 'trunk'
Peter Rabbitson [Tue, 7 Oct 2008 14:02:04 +0000]
Merge 'warnfree' into 'trunk'

Another round of warning-squashing:
Fix source registration/unregistration in several places
Accomodate postgres being really load on CREATE
Move the taint tests to a non-mainstream schema - hopefully this one will not be disturbed for a while
Fix warning due to File::Copy being sloppy
Test for TxnScopeGuard warnings
Test for multiple register_class warnings
Blindly silence a weird warning within a TODO in t/47bind_attribute.t. Hopefully when the TODO is resolved, it will be obvious what was causing it

16 years agoduh
Peter Rabbitson [Tue, 7 Oct 2008 12:51:09 +0000]
duh

16 years agoSchema::Versioned test cleanups:
Peter Rabbitson [Tue, 7 Oct 2008 10:25:36 +0000]
Schema::Versioned test cleanups:
- Add a test exposing a lapse in design resulting in intermittent test failures
- Add a number of tests to trap expected warnings
- Cleanup the temp dir after the test, set DBICTEST_KEEP_VERSIONING_DDL to override

16 years agoRemove superfluous TODO test
Marc Mims [Mon, 6 Oct 2008 20:04:50 +0000]
Remove superfluous TODO test

16 years agocosmincx's patch to show relationship attr filtering in cookbook
Jess Robinson [Mon, 6 Oct 2008 18:16:07 +0000]
cosmincx's patch to show relationship attr filtering in cookbook

16 years agoUse DBI->last_insert_id for ODBC base class.
Marc Mims [Mon, 6 Oct 2008 16:43:06 +0000]
Use DBI->last_insert_id for ODBC base class.

This closes RT #21260: Problem with last_insert_rowid:
http://rt.cpan.org/Public/Bug/Display.html?id=21260