Rafael Kitover [Thu, 11 Feb 2010 22:48:01 +0000]
test that anon classes are the same for instances having the same roles applied in the same order
Dave Rolsky [Wed, 10 Feb 2010 20:57:42 +0000]
Fix changes description to accurately reflect the bug
Dave Rolsky [Wed, 10 Feb 2010 20:43:03 +0000]
bump version to 0.98
Dave Rolsky [Wed, 10 Feb 2010 20:40:54 +0000]
Add Rafael's bug fix
Rafael Kitover [Wed, 10 Feb 2010 20:09:19 +0000]
Merge branch 'master' of jules.scsys.co.uk:Moose
Rafael Kitover [Wed, 10 Feb 2010 20:04:33 +0000]
update t/030_roles/010_run_time_role_composition.t to check for ToInstance anon class caching bug
Matt S Trout [Wed, 10 Feb 2010 17:10:51 +0000]
add DBIx::Class to dependents to ensure the Moose components are happy
Rafael Kitover [Wed, 10 Feb 2010 17:09:28 +0000]
use "roles" when creating anon class for applying a role to instance
Dave Rolsky [Wed, 10 Feb 2010 00:30:34 +0000]
bump version to 0.97
Dave Rolsky [Tue, 9 Feb 2010 23:35:30 +0000]
Fix changelog, reinit fix is in 0.97
Florian Ragwitz [Wed, 10 Feb 2010 00:17:09 +0000]
Fix changelog.
Dave Rolsky [Tue, 9 Feb 2010 22:41:12 +0000]
Fix reinitializing anon metaclasses.
The fix is to explicitly check to see if an anon class being reinitialized is
in the anon class cache. If it is, we remove the old metaclass and replace it
with the new one.
Dave Rolsky [Tue, 9 Feb 2010 15:54:05 +0000]
Update deprecation policy to match current reality
Dave Rolsky [Tue, 9 Feb 2010 15:51:14 +0000]
Update info on smolder script to talk about xt/author/test-my-dependents.t
franck cuny [Tue, 9 Feb 2010 08:11:00 +0000]
fix POD typo
Florian Ragwitz [Mon, 8 Feb 2010 19:34:40 +0000]
Make clear that ScalarRef can now be parameterized.
Dave Rolsky [Mon, 8 Feb 2010 16:36:35 +0000]
Use the already-existing anon class caching in MM::Class, rather than implementing a separate cache in Application::ToInstance.
Dave Rolsky [Sun, 7 Feb 2010 18:36:33 +0000]
Document that apply_metaroles returns a metaclass object
Florian Ragwitz [Sat, 6 Feb 2010 22:03:58 +0000]
We stopped subnaming role methods when being composed. Fix a TODO tests that expects we still do that.
Florian Ragwitz [Sat, 6 Feb 2010 21:42:37 +0000]
Version 0.96.
Florian Ragwitz [Fri, 5 Feb 2010 18:57:04 +0000]
Make ScalarRef accept references to references.
Florian Ragwitz [Fri, 5 Feb 2010 18:49:08 +0000]
Make ScalarRef parameterized.
Florian Ragwitz [Fri, 5 Feb 2010 17:23:56 +0000]
Fix pod typo.
Hans Dieter Pearcey [Fri, 5 Feb 2010 00:35:06 +0000]
add (TODO) tests for RT#46347 from Vince Veselosky
gregor herrmann [Thu, 4 Feb 2010 15:24:59 +0000]
Fix pod spelling.
Ansgar Burchardt [Sat, 26 Sep 2009 09:29:51 +0000]
Add a couple of missing package descriptions.
Florian Ragwitz [Thu, 4 Feb 2010 04:15:03 +0000]
Version 0.95.
Florian Ragwitz [Thu, 4 Feb 2010 03:54:58 +0000]
Force authors to run some more tests.
Florian Ragwitz [Thu, 4 Feb 2010 02:11:37 +0000]
Unfuck Makefile.PL.
Florian Ragwitz [Thu, 4 Feb 2010 02:09:33 +0000]
Revert "add stubs for BUILD and DEMOLISH to Moose::Object"
This reverts commit
c310bfa05ac3defa413ad464e0c0350cab908995.
Conflicts:
Changes
Florian Ragwitz [Sun, 31 Jan 2010 23:05:16 +0000]
Add execute_method to Native::Trait::Code.
Dylan William Hardison [Thu, 28 Jan 2010 13:52:56 +0000]
Added name to changelog entry per standaards.
Dylan William Hardison [Wed, 27 Jan 2010 23:31:54 +0000]
Behavior for method modifiers with non-regexp refs
The code:
before ['foo', 'bar'] => sub { }
Was previously silently ignored. Now it means the same as:
before ('foo', 'bar') => sub { }
This means that method modifiers can now be:
* a list
* a regexp ref.
* an arrayref
Anything else results in an error message.
Patrick Donelan [Tue, 26 Jan 2010 02:03:33 +0000]
Fixed typos in Recipe9.pod
Patrick Donelan [Tue, 26 Jan 2010 01:54:50 +0000]
Fixed typo in Recipe7.pod
Dave Rolsky [Mon, 25 Jan 2010 15:43:41 +0000]
Really fix the basics recipe 4 code to remove unneeded code, and update the narrative text.
Patrick Donelan [Mon, 25 Jan 2010 04:29:11 +0000]
Removed confusing/unnecessary code in Recipe4 POD
Florian Ragwitz [Fri, 22 Jan 2010 19:32:16 +0000]
Tell user to upgrade Catalyst if necessary.
Hans Dieter Pearcey [Fri, 22 Jan 2010 15:14:45 +0000]
remove conflict marker
Jesse Luehrs [Thu, 21 Jan 2010 08:59:30 +0000]
add stubs for BUILD and DEMOLISH to Moose::Object
Jesse Luehrs [Thu, 21 Jan 2010 08:23:05 +0000]
don't check class_precedence_list in does, since does_role already does
Florian Ragwitz [Wed, 20 Jan 2010 19:35:13 +0000]
Make it easier to see where the changes for one version start and stop.
Chia-liang Kao [Wed, 20 Jan 2010 06:08:10 +0000]
Fix Moose::Meta::Method pod that mentioned Class::MOP::Class.
Jesse Luehrs [Mon, 18 Jan 2010 23:46:54 +0000]
use consistent formatting
Jesse Luehrs [Mon, 18 Jan 2010 23:43:39 +0000]
indicate that the example method providers aren't a full list
Dave Rolsky [Mon, 18 Jan 2010 17:52:19 +0000]
Add release date (and fix previous 2010 release dates)
Dave Rolsky [Mon, 18 Jan 2010 16:47:02 +0000]
Also refer to MM::Delta
Dave Rolsky [Mon, 18 Jan 2010 04:26:20 +0000]
Add prominent reference to API changes in 0.93_01, since 0.94 is the first stable release with those changes.
Dave Rolsky [Mon, 18 Jan 2010 04:25:19 +0000]
More space between versions in changes
Dave Rolsky [Mon, 18 Jan 2010 04:21:46 +0000]
Require CMOP 0.98
Dave Rolsky [Mon, 18 Jan 2010 04:21:35 +0000]
set version to 0.94
Dave Rolsky [Mon, 18 Jan 2010 04:20:18 +0000]
Bug fixes for handling attr names like "@foo"
Squashed commit of the following:
commit
7607ae11345e64bbb5e1b2aa6ac50b2a4fde2154
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 11:18:38 2010 -0600
Add changes for bug fix
commit
bc41986f83d549a00b9b1eb2b50590a41546d3dc
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 11:07:09 2010 -0600
Quotemeta one last name
commit
4a5cc686e344c2dedbf15d9c91536edb1f0e40b5
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 11:06:00 2010 -0600
start fixing use of non-alpha names and remove more unused vars
commit
8beb437913f2f1c194e78597da4af48cf22dba23
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 11:04:43 2010 -0600
More type fixes for values
commit
ff707cbf2bdb2adfc2c9100fc0cc6e4a24b6c1b6
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 11:03:57 2010 -0600
Fix value for has spaces
commit
b2dc594248b2f7c88afce07c9561b5059806ccd0
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 11:03:30 2010 -0600
Add reader for !req
commit
85fe6c1e51c2e53483312a41090430df3c26916c
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 10:59:52 2010 -0600
Improve non-alpha attr tests. Need to include constraints and required attrs to smoke out bugs.
Also use with_immutable for tests
commit
3c3def7dc1347edf8b0316467c3c2439fa7fc6f6
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 10:58:04 2010 -0600
Remove unused variables from the environment for accessors when evaling code
commit
4510a53ce87a440ed9bb9a2a028053e6c93ad0f3
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 10:56:21 2010 -0600
Remove more unused variables
commit
6c40837349c828f159ea8dd752d847991e43ddf1
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 10:51:30 2010 -0600
Remove unused variable
Dave Rolsky [Mon, 18 Jan 2010 04:18:15 +0000]
Squashed commit of the following:
Improved support for anon roles by allowing meta role object wherever role name is allowed
commit
8b20238f2e370635548437ff49835db07a6debfb
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 17 11:46:01 2010 -0600
Allow role meta objects to be supplied wherever we currently take a role name.
Dave Rolsky [Sun, 17 Jan 2010 16:29:00 +0000]
Add conflict on MX::Attribute::Prototype <= 0.10
Dave Rolsky [Thu, 7 Jan 2010 21:44:43 +0000]
New style change log for 0.93_01 - _03
Patrick Donelan [Wed, 6 Jan 2010 08:01:48 +0000]
Minor POD improvements
* POD Typo in TypeConstraint.pm
* Typo in Types.pod
* Synchronises 'break' example in Concepts.pod with Roles.pod
* Typo in Attributes.pod
* Added repo URIs to Contributing.pod
Dave Rolsky [Wed, 6 Jan 2010 05:37:13 +0000]
Add conflict on MX::Role::WithOverloading 0.04
Dave Rolsky [Tue, 5 Jan 2010 19:08:43 +0000]
bump version to 0.93_03
Dave Rolsky [Tue, 5 Jan 2010 19:07:54 +0000]
Add XS changes
Florian Ragwitz [Tue, 5 Jan 2010 16:16:29 +0000]
Be portable across perls with different MGVTBL definitions.
Dave Rolsky [Tue, 5 Jan 2010 15:26:51 +0000]
bump version to 0.93_02
Dave Rolsky [Tue, 5 Jan 2010 15:26:28 +0000]
Add Changes for 0.93_02
Dave Rolsky [Tue, 5 Jan 2010 15:25:31 +0000]
Require CMOP 0.97_01
Dave Rolsky [Mon, 4 Jan 2010 18:07:53 +0000]
Add lc unimporting
Dave Rolsky [Mon, 4 Jan 2010 18:07:13 +0000]
Conflict with MX::Role::Cmd <= 0.06
Dave Rolsky [Mon, 4 Jan 2010 18:05:25 +0000]
Do the $XS_VERSION trick to make XSLoader happy with a dev version
Dave Rolsky [Mon, 4 Jan 2010 18:01:07 +0000]
List CABAL alphabetically
Dave Rolsky [Mon, 4 Jan 2010 18:00:29 +0000]
Add mention of mailing list & IRC to BUGS
Dave Rolsky [Mon, 4 Jan 2010 17:59:47 +0000]
bump version to 0.93_01
Dave Rolsky [Mon, 4 Jan 2010 17:59:34 +0000]
Add release date
Dave Rolsky [Mon, 4 Jan 2010 17:58:56 +0000]
add BUGS section to docs without one
Dave Rolsky [Mon, 4 Jan 2010 17:55:29 +0000]
Change BUGS so it always tells people to look at Moose/BUGS rather than telling them to email "me"
Dave Rolsky [Mon, 4 Jan 2010 17:37:05 +0000]
bump copyright year to 2010
Dave Rolsky [Mon, 4 Jan 2010 17:35:32 +0000]
Merged topic/metarole-distinguishes-role-meta (which includes topic/roles-have-real-attributes as well).
This adds real attributes to roles, and makes some changes to the
Moose::Util::MetaRole API so that users must specify roles for class
metaclasses separately from those for role metaclasses.
Squashed commit of the following:
commit
a6f4f4f4743cc87e8aadbed00312761af15c6822
Merge: 0ed066c 9cc63d2
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Jan 4 11:35:25 2010 -0600
merge master
commit
0ed066c7e278e360d4b7d857ddad84681be9e8ce
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Jan 4 11:02:55 2010 -0600
add docs for Moose::Meta::Mixin::AttributeCore
commit
5ac94c7e9ee3e0d5bd14f82d62ed90176812afa6
Merge: daf482a 301a2fc
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Jan 4 11:01:52 2010 -0600
Merge branch 'master' into topic/metarole-distinguishes-role-meta
Conflicts:
Changes
commit
daf482a1ca9af2de141e8c7c03c9fc6cbddd5feb
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Jan 4 11:00:13 2010 -0600
Add docs for Moose::Meta::Role::Attribute
commit
6b8b7a05f80ce96a0ecb3bf3962fc6ebd6d1e2e3
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Jan 4 10:50:47 2010 -0600
Add exclusions for new methods that don't need docs
commit
61917ede2a286042153f2bd058e90af6274b597b
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Jan 4 10:48:52 2010 -0600
Add metaroles to spelling whitelist
commit
5f242ef82a127bea0fa2b630f7a278b02ac5a49e
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 3 00:04:56 2010 -0600
Remove 0.94 versoin # in the wrong place
commit
7a89f4e0c62338622e2573508e41469bf61f5f4b
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 3 00:04:42 2010 -0600
Changes for next version
commit
ae9042be1aca7d300f67ddccf57833f80dada106
Author: Dave Rolsky <autarch@urth.org>
Date: Sun Jan 3 00:03:17 2010 -0600
Changes for next version
commit
9559e5012a59abe4fb13d255de413122beb80528
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 23:59:47 2010 -0600
Tweak docs for new MetaRole api
commit
806f607b78a1eac6ca588101e8cb0b747a3034f9
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 23:58:14 2010 -0600
Update MetaRole docs
commit
2bbe680397f1474d2099a6f05c805b3f07ba3513
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 17:12:03 2010 -0600
More conflicts
commit
e821045d525f71ebba74389887b612cab71a5913
Merge: 109ab37 8fa582b
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 16:58:10 2010 -0600
Merge branch 'master' into topic/metarole-distinguishes-role-meta
commit
109ab377fcb4636f9052015b752bed588da63d20
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 16:15:37 2010 -0600
update conflicts list
commit
5aafe28556af230278fe7bd631c40b0aaf55452b
Author: Dave Rolsky <autarch@urth.org>
Date: Fri Jan 1 12:54:48 2010 -0600
New MetaRole API to distinguish role & class metaroles.
Made ->reinitialize always preserve existing helper metaclasses for both MMC and MMR.
commit
5f4bdda79ff5bd89dd0f8763f4c313d9e2f4fff8
Author: Dave Rolsky <autarch@urth.org>
Date: Wed Dec 30 11:24:39 2009 -0600
Distinguish between metaroles for a class metaclass and role metaclass.
This means prefixing the options for MetaRole with "role_" -
"role_metaclass_roles", "role_attribute_metaclass_roles", etc.
commit
bed6f91f547d5f335c51434dbf0694cc06d103fb
Merge: 9addd62 4701cef
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Dec 28 16:41:06 2009 -0600
Merge branch 'master' into topic/roles-have-real-attributes
Conflicts:
lib/Moose/Meta/Role.pm
t/050_metaclasses/030_metarole_combination.t
commit
9addd624375d5fe4b11a8e8022e19a116eda78c4
Merge: 05c1cb1 c5e3151
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Dec 28 14:21:54 2009 -0600
Merge branch 'master' into topic/roles-have-real-attributes
commit
05c1cb1dccaeb28231972d5d08396f2c4bb64fd0
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Dec 28 11:21:51 2009 -0600
When comparing attributes during role summation, we need to compare them with an API, not just by comparing their refaddrs.
Added an ->is_same_as method to MMR::Attribute. This compares the values of ->original_options for the two objects.
commit
1fc6c93bbdee6e07f3c06f46f33a717e5eb85d85
Author: Dave Rolsky <autarch@urth.org>
Date: Mon Dec 28 11:08:09 2009 -0600
rename AttributeBase -> AttributeCore
commit
f1eba6b3caa8244c3d831fbc220bb0357fded304
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Dec 26 13:58:53 2009 -0600
Redid role attrs to be their own class.
Role attrs are cloned when added to other roles (and in role summation).
Added tests for role attrs
commit
d1f0dd763dfb2ab8a21e7b3533b60fbd056712e0
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Dec 26 13:11:32 2009 -0600
Roles have real attributes take 2.
Now role attributes a separate attribute-like class which knows how to make "real" attributes.
commit
428fc71e564cf97dfdfe805b37441dfe5e4ea728
Merge: 1fcc19c 1050527
Author: Dave Rolsky <autarch@urth.org>
Date: Fri Dec 25 10:40:08 2009 -0600
Merge branch 'master' into topic/roles-have-real-attributes
commit
10505278de61bec9021b8e64614dbde5840f6954
Author: Dave Rolsky <autarch@urth.org>
Date: Fri Dec 25 10:39:41 2009 -0600
add segfault workaround to pod spelling test
commit
1fcc19ca705350013ba219b1181965b2e87b9e10
Author: Dave Rolsky <autarch@urth.org>
Date: Thu Dec 17 14:16:07 2009 -0600
Remove some debugging cruft
commit
721b5f293969f5cf1b6863fb4cc1361f4bfbb9d8
Author: Dave Rolsky <autarch@urth.org>
Date: Thu Dec 17 11:29:55 2009 -0600
Real attribute objects in roles is now working, with a few hacks and changes to the core code.
This will need serious review before merging.
Dave Rolsky [Mon, 4 Jan 2010 17:28:10 +0000]
Reorder changes to put most interesting ones first
Dave Rolsky [Mon, 4 Jan 2010 17:27:24 +0000]
Document no "+foo" for role attrs, and related composition_class_roles change
Dave Rolsky [Mon, 4 Jan 2010 17:10:56 +0000]
Doc unimport handling of re-exports
Dave Rolsky [Mon, 4 Jan 2010 17:09:57 +0000]
Docs for Moose::Exporter unimport changes in Delta
Dave Rolsky [Mon, 4 Jan 2010 16:32:08 +0000]
Changes for recipe fix
Dave Rolsky [Mon, 4 Jan 2010 16:31:25 +0000]
Fix extending recipe 2 to actually work, and add tests
Jesse Luehrs [Sun, 3 Jan 2010 00:10:34 +0000]
clean up Changes formatting
Dave Rolsky [Sat, 2 Jan 2010 22:56:08 +0000]
Squashed commit of the following:
commit
2899131f4e9ca70dbb54ba6a24b2330074a28cbf
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 16:53:42 2010 -0600
Changes for Exporter fix
commit
88aa1e9bb23ceb54e5fb140c582bde805aa00e5f
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 16:52:13 2010 -0600
Add a missing aTHX_ declaration
commit
f40761d2dfbd0d7352bd0ad4a9e1a4ab89e7c077
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 16:26:25 2010 -0600
various renamings and tidyings
commit
542b4394f15cc12769c82999c871614710b2db3b
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 16:18:59 2010 -0600
Run code through tidy
commit
ced9c00db6abe4f86c0dc4eeb381c072cee0380a
Author: Dave Rolsky <autarch@urth.org>
Date: Sat Jan 2 16:17:21 2010 -0600
Remove a tab
commit
74f49e7b12718386ad40fb614568ceff6bda05e1
Author: Florian Ragwitz <rafl@debian.org>
Date: Sat Jan 2 21:24:42 2010 +0100
Stop wrapping exports. Use sv magic to tag the exports instead.
Florian Ragwitz [Mon, 28 Dec 2009 21:01:06 +0000]
Turn composition_class_roles into a plain method.
Dave Rolsky [Mon, 28 Dec 2009 20:21:41 +0000]
test just a subset of our deps by default (list taken from cpan stable smolder)
Dave Rolsky [Fri, 25 Dec 2009 16:39:41 +0000]
add segfault workaround to pod spelling test
Chris Prather [Tue, 20 Oct 2009 05:12:43 +0000]
update docs and Changes
in #moose
04:40 <@doy> perigrin: you have a typo in the docs (Age vs ValidAge), and you
should add a Changes entry
Chris Prather [Mon, 19 Oct 2009 04:55:20 +0000]
add Moose::Util::TypeConstraints to oose.pm
Someone came into #moose today trying to test out a question with
subtypes. I remembered that it had always annoyed me that I had to
include -MMoose::Util::TypeConstraints when using oose.pm. This should
fix that, with documentation.
Shawn M Moore [Fri, 18 Dec 2009 18:05:42 +0000]
Make the release steps less prone to interpretation :)
Dave Rolsky [Thu, 17 Dec 2009 20:35:43 +0000]
Doc Sam's regex change
Dave Rolsky [Thu, 17 Dec 2009 20:34:19 +0000]
Small changes formatting fixes
Sam Vilain [Wed, 16 Dec 2009 22:23:34 +0000]
TypeConstraints: update the type notation parser to avoid back-tracking
The regex might be slow due to character-by-character back-tracking.
However, there are few if any abiguous forms here; it is almost LL(1), save
for the '$any' rule. We can therefore limit backtracking by surrounding
all "tokens" in the 5.8+ (?>) independent sub-expression construct.
Dave Rolsky [Thu, 17 Dec 2009 17:31:06 +0000]
remove a lying comment
Shlomi Fish [Wed, 16 Dec 2009 16:14:53 +0000]
Fix a typo.
We (accidently) the Role...
Florian Ragwitz [Tue, 1 Dec 2009 16:08:38 +0000]
Disable warnings for t/010_basics/009_import_unimport.t so we won't warn under Test::Harness.
Florian Ragwitz [Tue, 1 Dec 2009 13:09:44 +0000]
Unimport blessed and confess unless they've been replaced by something else.
Dave Rolsky [Mon, 14 Dec 2009 23:11:17 +0000]
add an opt-in test using Test::DependentModules
Dave Rolsky [Mon, 14 Dec 2009 18:56:10 +0000]
More clarification on deprecation changes for get_*_map methods
Dave Rolsky [Mon, 14 Dec 2009 18:51:01 +0000]
Don't start a sentence with lower case
Shawn M Moore [Mon, 14 Dec 2009 18:33:38 +0000]
Instead of mentioning a vague "these", clarify =]
Chris Prather [Mon, 14 Dec 2009 18:29:49 +0000]
add documentation to Moose::Manual::Delta for the deprecation of get_attribute_map