15 years agothis fix of just checking of GV-ness to determine if a class has methods defined...
Dave Rolsky [Sun, 8 Feb 2009 14:46:45 +0000]
this fix of just checking of GV-ness to determine if a class has methods defined seems to fix 5.8.8 with an XS MOP. it still is not quite the same as what the pure Perl version is doing. I think we are missing some tests for all this

15 years agoAdd get_all_method_names
Shawn M Moore [Thu, 5 Feb 2009 21:11:13 +0000]
Add get_all_method_names

15 years agoDocument that initialize() returns a cached metaclass if it exists.
Dave Rolsky [Sat, 31 Jan 2009 17:21:11 +0000]
Document that initialize() returns a cached metaclass if it exists.

15 years agoMake the pure-perl test generation compatible with bsd make implementations.
Florian Ragwitz [Fri, 23 Jan 2009 10:42:25 +0000]
Make the pure-perl test generation compatible with bsd make implementations.

Courtesy of Stoned Elipot.

15 years agoRun the pure perl tests on the smokers.
Florian Ragwitz [Fri, 23 Jan 2009 07:38:32 +0000]
Run the pure perl tests on the smokers.

15 years agodoh, forgot to add a date
Dave Rolsky [Thu, 22 Jan 2009 22:39:23 +0000]
doh, forgot to add a date

15 years agoupdate the manifest 0.76
Dave Rolsky [Thu, 22 Jan 2009 22:24:44 +0000]
update the manifest

15 years agobump all the versions to 0.76
Dave Rolsky [Thu, 22 Jan 2009 22:22:30 +0000]
bump all the versions to 0.76

15 years agoupdate changes
Dave Rolsky [Thu, 22 Jan 2009 22:21:43 +0000]
update changes

15 years agodocument USING_XS constant
Dave Rolsky [Thu, 22 Jan 2009 22:17:42 +0000]
document USING_XS constant

15 years agorephrase skip_all test
Dave Rolsky [Thu, 22 Jan 2009 22:17:25 +0000]
rephrase skip_all test

15 years agoremove a useless comment
Dave Rolsky [Thu, 22 Jan 2009 22:04:45 +0000]
remove a useless comment

15 years agotry to make t/306_is_class_loaded.t skip except when it is meaningful
Dave Rolsky [Thu, 22 Jan 2009 21:52:37 +0000]
try to make t/306_is_class_loaded.t skip except when it is meaningful

15 years agoSkip all the tests unless using XS and Perl < 5.10.
Dave Rolsky [Thu, 22 Jan 2009 21:44:48 +0000]
Skip all the tests unless using XS and Perl < 5.10.

Clarify what needs to be fixed.

15 years agoAdd a line break for readability(-ishness)
Dave Rolsky [Thu, 22 Jan 2009 21:38:26 +0000]
Add a line break for readability(-ishness)

15 years agoReformat _eval_closure a bit and don't use q!! (used q[] instead).
Dave Rolsky [Thu, 22 Jan 2009 21:34:33 +0000]
Reformat _eval_closure a bit and don't use q!! (used q[] instead).

15 years agoMerge method_generation_cleanup branch
Yuval Kogman [Sat, 17 Jan 2009 22:59:55 +0000]
Merge method_generation_cleanup branch

15 years agoadd _compile_code, a wrapper for _eval_closure and _add_line_directive
Yuval Kogman [Sat, 17 Jan 2009 22:36:34 +0000]
add _compile_code, a wrapper for _eval_closure and _add_line_directive

15 years agoMerge from trunk to method_generation_cleanup branch (all tests pass)
Dave Rolsky [Wed, 14 Jan 2009 08:46:12 +0000]
Merge from trunk to method_generation_cleanup branch (all tests pass)

15 years agoOops, needed that voodoo
Dave Rolsky [Wed, 14 Jan 2009 08:43:07 +0000]
Oops, needed that voodoo

15 years agoRemove some useless voodoo, and tidy
Dave Rolsky [Wed, 14 Jan 2009 08:42:32 +0000]
Remove some useless voodoo, and tidy

15 years agoFix test description to match names used in test
Dave Rolsky [Wed, 14 Jan 2009 08:41:45 +0000]
Fix test description to match names used in test

15 years agoget_method_map, find_method_by_name, and remove_method deal with Class::MOP::Method...
Jesse Luehrs [Wed, 14 Jan 2009 08:26:17 +0000]
get_method_map, find_method_by_name, and remove_method deal with Class::MOP::Method instances, not CODE refs

15 years agoTODO test showing differences between xs and pp versions of Class::MOP::is_class_loaded
Tomas Doran [Mon, 12 Jan 2009 17:31:58 +0000]
TODO test showing differences between xs and pp versions of Class::MOP::is_class_loaded

15 years agoadd definition_context
Yuval Kogman [Mon, 12 Jan 2009 06:45:08 +0000]
add definition_context

This is used to generate #line declarations for evaled code.

Currently only in use for accessors, should be added to constructor as
well.

15 years agoRemove commented-out bit of code
Dave Rolsky [Sun, 11 Jan 2009 11:20:02 +0000]
Remove commented-out bit of code

15 years agoInstead of appending to the pp test file, replace it.
Shawn M Moore [Wed, 7 Jan 2009 15:00:18 +0000]
Instead of appending to the pp test file, replace it.

15 years agoMetaclass-cache documentation cleanups
Shawn M Moore [Wed, 7 Jan 2009 14:53:00 +0000]
Metaclass-cache documentation cleanups

15 years agoTypo fix
Shawn M Moore [Wed, 7 Jan 2009 14:49:25 +0000]
Typo fix

15 years agoTurn generation of pure perl tests into a makefile target.
Florian Ragwitz [Wed, 7 Jan 2009 06:59:23 +0000]
Turn generation of pure perl tests into a makefile target.

15 years agoRemove shebangs from tests.
Florian Ragwitz [Wed, 7 Jan 2009 06:59:05 +0000]
Remove shebangs from tests.

15 years agoOops, today is Wednesday
Dave Rolsky [Wed, 31 Dec 2008 16:47:46 +0000]
Oops, today is Wednesday

15 years agofix tests broken by the fix to make immutable transformers unique per class 0.75
Dave Rolsky [Wed, 31 Dec 2008 16:36:43 +0000]
fix tests broken by the fix to make immutable transformers unique per class

15 years agoTidy this file
Dave Rolsky [Wed, 31 Dec 2008 16:28:15 +0000]
Tidy this file

15 years agobump version to 0.75
Dave Rolsky [Wed, 31 Dec 2008 16:24:10 +0000]
bump version to 0.75

15 years agoFix a bug where a class made immutable and then mutable would end up
Dave Rolsky [Wed, 31 Dec 2008 16:23:50 +0000]
Fix a bug where a class made immutable and then mutable would end up
sharing an immutable transformer with other classes, leading to
bizarro bugs later.

15 years agoFix wording of a change
Dave Rolsky [Tue, 30 Dec 2008 14:55:14 +0000]
Fix wording of a change

15 years agoRemove prototypes from MOP.xs. The pure perl implementations don't have prototypes...
Florian Ragwitz [Thu, 25 Dec 2008 14:41:24 +0000]
Remove prototypes from MOP.xs. The pure perl implementations don't have prototypes either.

The prototype for get_code_info remains as Sub::Identify::get_code_info, which
is used if we couldn't load our xs code, also has a prototype.

15 years agobump version and update changes 0.74
Dave Rolsky [Thu, 25 Dec 2008 13:56:23 +0000]
bump version and update changes

15 years agoChangelogging.
Florian Ragwitz [Thu, 25 Dec 2008 13:46:18 +0000]
Changelogging.

15 years agoAvoid macro expansion of 'name' in PREHASH_KEY.
Florian Ragwitz [Thu, 25 Dec 2008 13:39:35 +0000]
Avoid macro expansion of 'name' in PREHASH_KEY.

15 years agoWhops. s/VALUE/VERSION/;
Florian Ragwitz [Thu, 25 Dec 2008 13:22:20 +0000]
Whops. s/VALUE/VERSION/;

15 years agoDon't require the hash key to be specified twice in case name and the value are the...
Florian Ragwitz [Thu, 25 Dec 2008 10:49:07 +0000]
Don't require the hash key to be specified twice in case name and the value are the same.

15 years agoMake it easier to add new prehashed hash keys.
Florian Ragwitz [Wed, 24 Dec 2008 23:35:39 +0000]
Make it easier to add new prehashed hash keys.

15 years agoStop gcc from warning.
Florian Ragwitz [Mon, 22 Dec 2008 21:18:11 +0000]
Stop gcc from warning.

15 years agoPrecompute hashes for VERSION and ISA.
Florian Ragwitz [Mon, 22 Dec 2008 20:16:11 +0000]
Precompute hashes for VERSION and ISA.

15 years agoAdd an xs implementation of Class::MOP::is_class_loaded.
Florian Ragwitz [Mon, 22 Dec 2008 20:06:36 +0000]
Add an xs implementation of Class::MOP::is_class_loaded.

Based on patch by Goro Fuji <gfuji@cpan.org> (RT#41862).

15 years agoShow around on both sides of primary (it is around, after all)
Dave Rolsky [Fri, 19 Dec 2008 15:45:44 +0000]
Show around on both sides of primary (it is around, after all)

15 years agobump version 0.73
Dave Rolsky [Tue, 16 Dec 2008 15:09:00 +0000]
bump version

15 years agoUpdate changes for next release
Dave Rolsky [Tue, 16 Dec 2008 15:08:34 +0000]
Update changes for next release

15 years agotypo fix
Todd Hepler [Mon, 15 Dec 2008 17:30:30 +0000]
typo fix

15 years agoRevert "Allow attribute defaults to be objects with overloaded codification."
Florian Ragwitz [Sun, 14 Dec 2008 20:10:47 +0000]
Revert "Allow attribute defaults to be objects with overloaded codification."

This reverts commit 7070.

17:09:35 < stevan> overloaded stuff is not the same as regular stuff
17:09:59 < stevan> Perl's overloading sucks ass basically
17:10:39 < stevan> and I dont think we should have support for it in the core
17:10:52 < stevan> it is too fragile and unreliable
17:11:16 < stevan> I dont want to get into the edge case hell that it creates
20:14:59 < stevan> rafl: additionally, I dont think that this is a correct use case in the test
20:15:07 < stevan> default take a sub ref, not a method
20:15:14 < stevan> for methods, you use build
20:15:22 < stevan> anything else is incorrect usage

15 years agoMore changelogging.
Florian Ragwitz [Sat, 13 Dec 2008 13:14:31 +0000]
More changelogging.

15 years agoChangelogging.
Florian Ragwitz [Sat, 13 Dec 2008 13:12:26 +0000]
Changelogging.

15 years agoAllow attribute defaults to be objects with overloaded codification.
Florian Ragwitz [Sat, 13 Dec 2008 13:12:12 +0000]
Allow attribute defaults to be objects with overloaded codification.

Tests by rhesa++.

15 years agoMake mop_check_package_cache_flag work on 5.10, even if Perl_mro_meta_init isn't...
Florian Ragwitz [Sat, 13 Dec 2008 09:07:03 +0000]
Make mop_check_package_cache_flag work on 5.10, even if Perl_mro_meta_init isn't available.

15 years agoonly close over the default values, don't actually need the meta-attributes
Matt S Trout [Fri, 12 Dec 2008 08:54:33 +0000]
only close over the default values, don't actually need the meta-attributes

15 years agoMerge 'trunk' into 'method_generation_cleanup'
Matt S Trout [Fri, 12 Dec 2008 08:26:36 +0000]
Merge 'trunk' into 'method_generation_cleanup'

r26247@agaton (orig r6868):  rafl | 2008-12-05 06:19:54 +0000
Factor a c function doing all the hard work out of get_all_package_symbols.
r26248@agaton (orig r6869):  rafl | 2008-12-05 06:20:10 +0000
Make get_all_package_symbols return a hashref in scalar context.

Also deprecate usage in list context with a warning.
r26249@agaton (orig r6870):  rafl | 2008-12-05 06:20:19 +0000
Factor out a c version of get_code_info. Make get_method_map use that and the c
version of get_all_package_symbols.
r26250@agaton (orig r6871):  rafl | 2008-12-05 06:20:28 +0000
Don't check if the xs version of get_method_map is called as a class method.

The pure perl version doesn't do that either.
r26251@agaton (orig r6872):  rafl | 2008-12-05 06:20:37 +0000
A few simplifications to xs get_method_map.
r26252@agaton (orig r6873):  rafl | 2008-12-05 06:20:45 +0000
Make the c get_code_info static.
r26253@agaton (orig r6874):  rafl | 2008-12-05 06:20:54 +0000
use style; in MOP.xs.
r26254@agaton (orig r6875):  rafl | 2008-12-05 06:21:02 +0000
Fail if hv_store fails.
r26255@agaton (orig r6876):  rafl | 2008-12-05 06:28:17 +0000
get_method_map already is xsified.
r26256@agaton (orig r6877):  rafl | 2008-12-05 06:39:33 +0000
0.71_01 is already released. Move changelog entries for unreleased things to 0.72.
r26257@agaton (orig r6878):  rafl | 2008-12-05 06:39:42 +0000
Changelogging.
r26277@agaton (orig r6898):  autarch | 2008-12-05 19:21:07 +0000
bump version to 0.71_02 and update Changes
r26279@agaton (orig r6900):  autarch | 2008-12-05 19:23:55 +0000
add typemap to MANIFEST
r26283@agaton (orig r6904):  rafl | 2008-12-05 19:57:17 +0000
Tell ppport.h that we need newRV_noinc.
r26284@agaton (orig r6905):  rafl | 2008-12-05 20:35:57 +0000
Fix a few more style issues in MOP.xs.
r26536@agaton (orig r6927):  sartak | 2008-12-07 01:31:27 +0000
 r76628@onn:  sartak | 2008-12-06 20:30:24 -0500
 Pass options to Class::MOP::Package->_new (fixes failing Moose tests)

r26537@agaton (orig r6928):  sartak | 2008-12-07 01:59:43 +0000
 r76631@onn:  sartak | 2008-12-06 20:58:53 -0500
 Changelog entry

r26538@agaton (orig r6929):  sartak | 2008-12-07 02:03:21 +0000
 r76632@onn:  sartak | 2008-12-06 20:59:23 -0500
 Rename the test class from "Base" because case insensitive file systems try to subclass 'base'. Whee.

r26558@agaton (orig r6949):  autarch | 2008-12-07 18:47:04 +0000
No, Sartak, you cannot retroactively add code to a released tarball ;)

r26564@agaton (orig r6955):  sartak | 2008-12-08 01:08:40 +0000
 r76668@onn:  sartak | 2008-12-07 20:07:27 -0500
 Doc fix for CMOP::Method from sorear

r26565@agaton (orig r6956):  sartak | 2008-12-08 01:09:04 +0000
 r76670@onn:  sartak | 2008-12-07 20:08:30 -0500
 Put this change under the correct version

r26577@agaton (orig r6968):  autarch | 2008-12-08 14:49:13 +0000
Very small grammar tweak.

r26578@agaton (orig r6969):  autarch | 2008-12-08 14:49:52 +0000
Clarify change

r26584@agaton (orig r6975):  autarch | 2008-12-08 17:05:43 +0000
Add release date

r26585@agaton (orig r6976):  autarch | 2008-12-08 17:07:40 +0000
 bump version to 0.72
r26605@agaton (orig r6996):  perigrin | 2008-12-09 00:58:39 +0000
add breadcrumbs to describe the Inheritance hierarchy of Class -> Module -> Package -> Object so people can find methods a little easier
r26635@agaton (orig r7026):  shlomif | 2008-12-09 16:48:42 +0000
Fixed some of the tests under perl -d.

    * t/082_get_code_info.t
      - Add $^P &= ~0x200; (per Ovid's suggestion) in order to not munger
        anonymous subs when under -d and so making the tests succeed
        in that case.

15 years agoswitch to hashref-based _eval_closure
Matt S Trout [Fri, 12 Dec 2008 08:16:01 +0000]
switch to hashref-based _eval_closure

15 years agoFixed some of the tests under perl -d.
Shlomi Fish [Tue, 9 Dec 2008 16:48:42 +0000]
Fixed some of the tests under perl -d.

    * t/082_get_code_info.t
      - Add $^P &= ~0x200; (per Ovid's suggestion) in order to not munger
        anonymous subs when under -d and so making the tests succeed
        in that case.

15 years agoadd breadcrumbs to describe the Inheritance hierarchy of Class -> Module -> Package...
Chris Prather [Tue, 9 Dec 2008 00:58:39 +0000]
add breadcrumbs to describe the Inheritance hierarchy of Class -> Module -> Package -> Object so people can find methods a little easier

15 years ago bump version to 0.72 0.72
Dave Rolsky [Mon, 8 Dec 2008 17:07:40 +0000]
 bump version to 0.72

15 years agoAdd release date
Dave Rolsky [Mon, 8 Dec 2008 17:05:43 +0000]
Add release date

15 years agoClarify change
Dave Rolsky [Mon, 8 Dec 2008 14:49:52 +0000]
Clarify change

15 years agoVery small grammar tweak.
Dave Rolsky [Mon, 8 Dec 2008 14:49:13 +0000]
Very small grammar tweak.

15 years agoPut this change under the correct version
Shawn M Moore [Mon, 8 Dec 2008 01:09:04 +0000]
Put this change under the correct version

15 years agoDoc fix for CMOP::Method from sorear
Shawn M Moore [Mon, 8 Dec 2008 01:08:40 +0000]
Doc fix for CMOP::Method from sorear

15 years agoNo, Sartak, you cannot retroactively add code to a released tarball ;)
Dave Rolsky [Sun, 7 Dec 2008 18:47:04 +0000]
No, Sartak, you cannot retroactively add code to a released tarball ;)

15 years agoRename the test class from "Base" because case insensitive file systems try to subcla...
Shawn M Moore [Sun, 7 Dec 2008 02:03:21 +0000]
Rename the test class from "Base" because case insensitive file systems try to subclass 'base'. Whee.

15 years agoChangelog entry
Shawn M Moore [Sun, 7 Dec 2008 01:59:43 +0000]
Changelog entry

15 years agoPass options to Class::MOP::Package->_new (fixes failing Moose tests)
Shawn M Moore [Sun, 7 Dec 2008 01:31:27 +0000]
Pass options to Class::MOP::Package->_new (fixes failing Moose tests)

15 years agoFix a few more style issues in MOP.xs.
Florian Ragwitz [Fri, 5 Dec 2008 20:35:57 +0000]
Fix a few more style issues in MOP.xs.

15 years agoTell ppport.h that we need newRV_noinc.
Florian Ragwitz [Fri, 5 Dec 2008 19:57:17 +0000]
Tell ppport.h that we need newRV_noinc.

15 years agoadd typemap to MANIFEST 0.71_02
Dave Rolsky [Fri, 5 Dec 2008 19:23:55 +0000]
add typemap to MANIFEST

15 years agobump version to 0.71_02 and update Changes
Dave Rolsky [Fri, 5 Dec 2008 19:21:07 +0000]
bump version to 0.71_02 and update Changes

15 years agoChangelogging.
Florian Ragwitz [Fri, 5 Dec 2008 06:39:42 +0000]
Changelogging.

15 years ago0.71_01 is already released. Move changelog entries for unreleased things to 0.72.
Florian Ragwitz [Fri, 5 Dec 2008 06:39:33 +0000]
0.71_01 is already released. Move changelog entries for unreleased things to 0.72.

15 years agoget_method_map already is xsified.
Florian Ragwitz [Fri, 5 Dec 2008 06:28:17 +0000]
get_method_map already is xsified.

15 years agoFail if hv_store fails.
Florian Ragwitz [Fri, 5 Dec 2008 06:21:02 +0000]
Fail if hv_store fails.

15 years agouse style; in MOP.xs.
Florian Ragwitz [Fri, 5 Dec 2008 06:20:54 +0000]
use style; in MOP.xs.

15 years agoMake the c get_code_info static.
Florian Ragwitz [Fri, 5 Dec 2008 06:20:45 +0000]
Make the c get_code_info static.

15 years agoA few simplifications to xs get_method_map.
Florian Ragwitz [Fri, 5 Dec 2008 06:20:37 +0000]
A few simplifications to xs get_method_map.

15 years agoDon't check if the xs version of get_method_map is called as a class method.
Florian Ragwitz [Fri, 5 Dec 2008 06:20:28 +0000]
Don't check if the xs version of get_method_map is called as a class method.

The pure perl version doesn't do that either.

15 years agoFactor out a c version of get_code_info. Make get_method_map use that and the c
Florian Ragwitz [Fri, 5 Dec 2008 06:20:19 +0000]
Factor out a c version of get_code_info. Make get_method_map use that and the c
version of get_all_package_symbols.

15 years agoMake get_all_package_symbols return a hashref in scalar context.
Florian Ragwitz [Fri, 5 Dec 2008 06:20:10 +0000]
Make get_all_package_symbols return a hashref in scalar context.

Also deprecate usage in list context with a warning.

15 years agoFactor a c function doing all the hard work out of get_all_package_symbols.
Florian Ragwitz [Fri, 5 Dec 2008 06:19:54 +0000]
Factor a c function doing all the hard work out of get_all_package_symbols.

15 years agobreak out method generation into an _eval_closure method
Matt S Trout [Fri, 5 Dec 2008 02:24:05 +0000]
break out method generation into an _eval_closure method

15 years agocreate MOP branch for method generation cleanup
Matt S Trout [Fri, 5 Dec 2008 01:39:09 +0000]
create MOP branch for method generation cleanup

15 years agoMake inlined_constructor return an actual method, not just a
Dave Rolsky [Thu, 4 Dec 2008 22:33:53 +0000]
Make inlined_constructor return an actual method, not just a
boolean. This will make my Moose changes much simpler.

15 years agoAdd an attribute to CMOP::Immutable, inlined_constructor, which will
Dave Rolsky [Thu, 4 Dec 2008 22:22:58 +0000]
Add an attribute to CMOP::Immutable, inlined_constructor, which will
be used by Moose::Meta::Method::Constructor.

15 years agoIf replace_constructor is true we do not check whether the constructor
Dave Rolsky [Thu, 4 Dec 2008 21:21:31 +0000]
If replace_constructor is true we do not check whether the constructor
can be inlined.

15 years agoAdd a can_be_inlined method to CMOP::Method::Constructor which we
Dave Rolsky [Thu, 4 Dec 2008 20:35:53 +0000]
Add a can_be_inlined method to CMOP::Method::Constructor which we
check in CMOP::Immutable.

We will override this in Moose to only inline the constructor if our
class wants to use the one from Moose::Object.

15 years agoadd a description to a test which did not have one
Dave Rolsky [Thu, 4 Dec 2008 20:35:04 +0000]
add a description to a test which did not have one

15 years agoFix comment which totally disagreed with code it commented on
Dave Rolsky [Thu, 4 Dec 2008 17:52:03 +0000]
Fix comment which totally disagreed with code it commented on

15 years agoMore refactorings to break down immutabilization into smaller (mostly
Dave Rolsky [Thu, 4 Dec 2008 17:24:17 +0000]
More refactorings to break down immutabilization into smaller (mostly
private) methods.

15 years agoFix a method name to actually reflect what it does
Dave Rolsky [Thu, 4 Dec 2008 17:13:16 +0000]
Fix a method name to actually reflect what it does

15 years agoSort the lists we iterate through to make finding a specific test in
Dave Rolsky [Thu, 4 Dec 2008 17:08:29 +0000]
Sort the lists we iterate through to make finding a specific test in
the output a little easier.

15 years agoThese tests reversed the got/expected order to is_deeply in most cases.
Dave Rolsky [Thu, 4 Dec 2008 17:06:43 +0000]
These tests reversed the got/expected order to is_deeply in most cases.

15 years agoMore refactorings - short circuit out of various methods if we're not
Dave Rolsky [Thu, 4 Dec 2008 16:59:27 +0000]
More refactorings - short circuit out of various methods if we're not
going to do them (inline constructor, destructor, etc)

15 years agoRefactor the make_metaclass_immutable method into a bunch of smaller
Dave Rolsky [Thu, 4 Dec 2008 16:56:57 +0000]
Refactor the make_metaclass_immutable method into a bunch of smaller
methods for each thing being made immutable.