From: Bram Date: Sun, 10 Aug 2008 20:36:27 +0000 (+0200) Subject: Avoid a potential testing race condition in lib/Dirhandle.ttest. X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ffe4764e6903def60304ff584612fb863707cd05;p=p5sagit%2Fp5-mst-13.2.git Avoid a potential testing race condition in lib/Dirhandle.ttest. Message-ID: <20080810203627.vj786wb688skc44w@horde.wizbit.be> Date: Sun, 10 Aug 2008 20:36:27 +0200 p4raw-id: //depot/perl@34196 --- diff --git a/lib/DirHandle.t b/lib/DirHandle.t index b654f6d..35a7ea8 100755 --- a/lib/DirHandle.t +++ b/lib/DirHandle.t @@ -15,6 +15,15 @@ require './test.pl'; plan(5); +# Fetching the list of files in two different ways and expecting them +# to be the same is a race condition when tests are running in parallel. +# So go somewhere quieter. +my $chdir; +if ($ENV{PERL_CORE} && -d 'uni') { + chdir 'uni'; + $chdir++; +}; + $dot = new DirHandle ($^O eq 'MacOS' ? ':' : '.'); ok(defined($dot)); @@ -33,3 +42,7 @@ cmp_ok(+(join("\0", @b), 'eq', join("\0", @c))); $dot->close; $dot->rewind; ok(!defined($dot->read)); + +if ($chdir) { + chdir ".."; +}