From: Matt S Trout <mst@shadowcat.co.uk>
Date: Fri, 1 Nov 2013 15:16:59 +0000 (+0000)
Subject: _extract_order_criteria can now handle ident only or full criteria
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=fe386563d35a0e019c70500e1fd01b3514942eed;p=dbsrgits%2FDBIx-Class.git

_extract_order_criteria can now handle ident only or full criteria
---

diff --git a/lib/DBIx/Class/Storage/DBIHacks.pm b/lib/DBIx/Class/Storage/DBIHacks.pm
index 7d26a4a..b4c5231 100644
--- a/lib/DBIx/Class/Storage/DBIHacks.pm
+++ b/lib/DBIx/Class/Storage/DBIHacks.pm
@@ -811,7 +811,7 @@ sub _inner_join_to_node {
 }
 
 sub _extract_order_criteria {
-  my ($self, $order_by, $sql_maker) = @_;
+  my ($self, $order_by, $sql_maker, $ident_only) = @_;
 
   $sql_maker ||= $self->sql_maker;
 
@@ -825,11 +825,15 @@ sub _extract_order_criteria {
 
   delete local @{$sql_maker}{qw(quote_char renderer converter)};
 
-  my @by_ident;
-
-  scan_dq_nodes({ DQ_IDENTIFIER ,=> sub { push @by_ident, $_[0] } }, @by);
-
-  return map { [ $sql_maker->_render_dq($_) ] } @by_ident;
+  return map { [ $sql_maker->_render_dq($_) ] } do {
+    if ($ident_only) {
+      my @by_ident;
+      scan_dq_nodes({ DQ_IDENTIFIER ,=> sub { push @by_ident, $_[0] } }, @by);
+      @by_ident
+    } else {
+      @by
+    }
+  };
 
   my $parser = sub {
     my ($sql_maker, $order_by, $orig_quote_chars) = @_;
@@ -877,7 +881,7 @@ sub _order_by_is_stable {
   my ($self, $ident, $order_by, $where) = @_;
 
   my $colinfo = $self->_resolve_column_info($ident, [
-    (map { $_->[0] } $self->_extract_order_criteria($order_by)),
+    (map { $_->[0] } $self->_extract_order_criteria($order_by, undef, 1)),
     $where ? @{$self->_extract_fixed_condition_columns($where)} :(),
   ]);