From: Jarkko Hietaniemi <jhi@iki.fi>
Date: Mon, 30 Jul 2001 23:11:10 +0000 (+0000)
Subject: Explain in more detail why -pipe and -fno-common are good.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=faf52077314b44c5bedc5d7fe06835bf98c07f69;p=p5sagit%2Fp5-mst-13.2.git

Explain in more detail why -pipe and -fno-common are good.

p4raw-id: //depot/perl@11507
---

diff --git a/hints/darwin.sh b/hints/darwin.sh
index de5857c..c2e7606 100644
--- a/hints/darwin.sh
+++ b/hints/darwin.sh
@@ -51,8 +51,12 @@ if [ "x$optimize" = 'x' ]; then
     optimize='-O3'
 fi
 
-# XXX Unclear why we require -pipe and -fno-common here. --Andy Dougherty
-# We don't like commons. --Fred Sánchez
+# -pipe: makes compilation go faster.
+# -fno-common: we don't like commons.  Common symbols are not allowed
+# in MH_DYLIB binaries, which is what libperl.dylib is.  You will fail
+# to link without that option, unless you otherwise eliminate all commons
+# by, for example, initializing all globals.
+# --Fred Sánchez
 ccflags="${ccflags} -pipe -fno-common"
 
 # At least on Darwin 1.3.x: