From: Stepan Kasal <skasal@redhat.com>
Date: Mon, 23 Nov 2009 11:14:06 +0000 (+0100)
Subject: fix logic for a workaround in POSIX.xs
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=fabb67aac748c1bf94bbc4a173a67dbd9a00b4df;p=p5sagit%2Fp5-mst-13.2.git

fix logic for a workaround in POSIX.xs

There is the assignment "RETVAL = 0" to silence the compiler in case
it incorrectly reports return of an undefined value.
This assignment should be present whenever *any* of the symbols is
not defined.  But the code was written so that the assignment was
compiled only when *none* of the symbols was defined.
---

diff --git a/ext/POSIX/POSIX.xs b/ext/POSIX/POSIX.xs
index d30a752..7bdd633 100644
--- a/ext/POSIX/POSIX.xs
+++ b/ext/POSIX/POSIX.xs
@@ -887,8 +887,8 @@ WEXITSTATUS(status)
 	POSIX::WSTOPSIG = 4
 	POSIX::WTERMSIG = 5
     CODE:
-#if !(defined(WEXITSTATUS) || defined(WIFEXITED) || defined(WIFSIGNALED) \
-      || defined(WIFSTOPPED) || defined(WSTOPSIG) || defined (WTERMSIG))
+#if !defined(WEXITSTATUS) || !defined(WIFEXITED) || !defined(WIFSIGNALED) \
+      || !defined(WIFSTOPPED) || !defined(WSTOPSIG) || !defined(WTERMSIG)
         RETVAL = 0; /* Silence compilers that notice this, but don't realise
 		       that not_here() can't return.  */
 #endif