From: Ton Voon <ton.voon@opsera.com>
Date: Tue, 16 Aug 2011 16:02:39 +0000 (+0100)
Subject: Remove stderr hiding from PAR::Packer
X-Git-Tag: 1.35~5
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=f42008bbeac1134900261212ee96b3448c050766;p=catagits%2FCatalyst-Devel.git

Remove stderr hiding from PAR::Packer
---

diff --git a/lib/Module/Install/Catalyst.pm b/lib/Module/Install/Catalyst.pm
index 4c47bff..9df9b3f 100644
--- a/lib/Module/Install/Catalyst.pm
+++ b/lib/Module/Install/Catalyst.pm
@@ -370,8 +370,8 @@ EOF
 
     # Create package
     local $SIG{__WARN__} = sub { };
-    open my $olderr, '>&STDERR';
-    open STDERR, '>', File::Spec->devnull;
+
+    # STDERR used to be redirected to null, but this hid errors from PAR::Packer
     my %opt = (
         %{$PAROPTS},
         # take user defined options first and override them with harcoded defaults
@@ -391,8 +391,6 @@ EOF
         args      => ['par.pl'],
     )->go;
 
-    open STDERR, '>&', $olderr;
-
     unlink $par_pl;
     chdir $root;
     rmove( File::Spec->catfile( 'blib', $par ), $par );