From: Peter Rabbitson <ribasushi@cpan.org>
Date: Thu, 21 Oct 2010 14:49:18 +0000 (+0200)
Subject: Make sure t/storage/debug.t passes with DBIC_TRACE_PROFILE set
X-Git-Tag: v0.08124~31
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=f410ea47d00b415ebb9b277be6417d724c9a643f;p=dbsrgits%2FDBIx-Class.git

Make sure t/storage/debug.t passes with DBIC_TRACE_PROFILE set
---

diff --git a/t/storage/debug.t b/t/storage/debug.t
index cc27599..37003ba 100644
--- a/t/storage/debug.t
+++ b/t/storage/debug.t
@@ -2,6 +2,7 @@ use strict;
 use warnings;
 
 use Test::More;
+use Test::Exception;
 use lib qw(t/lib);
 use DBICTest;
 use DBIC::DebugObj;
@@ -10,6 +11,8 @@ use Path::Class qw/file/;
 
 my $schema = DBICTest->init_schema();
 
+# make sure we are testing the vanilla debugger and not ::PrettyPrint
+$schema->storage->debugobj(DBIx::Class::Storage::Statistics->new);
 
 ok ( $schema->storage->debug(1), 'debug' );
 $schema->storage->debugfh(file('t/var/sql.log')->openw);
@@ -21,7 +24,7 @@ $rs->count();
 my $log = file('t/var/sql.log')->openr;
 my $line = <$log>;
 $log->close();
-ok($line =~ /^SELECT COUNT/, 'Log success');
+like($line, qr/^SELECT COUNT/, 'Log success');
 
 $schema->storage->debugfh(undef);
 $ENV{'DBIC_TRACE'} = '=t/var/foo.log';
@@ -30,17 +33,18 @@ $rs->count();
 $log = file('t/var/foo.log')->openr;
 $line = <$log>;
 $log->close();
-ok($line =~ /^SELECT COUNT/, 'Log success');
+like($line, qr/^SELECT COUNT/, 'Log success');
 $schema->storage->debugobj->debugfh(undef);
 delete($ENV{'DBIC_TRACE'});
+
 open(STDERRCOPY, '>&STDERR');
 stat(STDERRCOPY); # nop to get warnings quiet
 close(STDERR);
-eval {
+dies_ok {
     $rs = $schema->resultset('CD')->search({});
     $rs->count();
-};
-ok($@, 'Died on closed FH');
+} 'Died on closed FH';
+
 open(STDERR, '>&STDERRCOPY');
 
 # test trace output correctness for bind params