From: Stevan Little <stevan.little@iinteractive.com>
Date: Wed, 12 Jul 2006 13:55:58 +0000 (+0000)
Subject: foo
X-Git-Tag: 0_11^0
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=f1d29725f9f544f10257de608133fc99138bf510;p=gitmo%2FMoose.git

foo
---

diff --git a/Changes b/Changes
index 00740c1..6e6defc 100644
--- a/Changes
+++ b/Changes
@@ -1,9 +1,10 @@
 Revision history for Perl extension Moose
 
-0.11 
+0.11 Wed. July 12, 2006
     * Moose
       - added an &unimport method to remove all the keywords
-        that Moose will import
+        that Moose will import, simply add 'no Moose' to the 
+        bottom of your class file. 
         
     * t/
       - fixed some test failures caused by a forgotten test 
@@ -21,7 +22,6 @@ Revision history for Perl extension Moose
     but it does not yet utilize the optimizations 
     it makes available. Stay tuned for that ;)
     
-
 0.09_03 Fri. June 23, 2006
     ++ DEVELOPER RELEASE ++
     * Moose
diff --git a/lib/Moose/Meta/Role.pm b/lib/Moose/Meta/Role.pm
index 539df82..be6802e 100644
--- a/lib/Moose/Meta/Role.pm
+++ b/lib/Moose/Meta/Role.pm
@@ -323,6 +323,10 @@ sub _check_required_methods {
     # that maybe those are somehow exempt from 
     # the require methods stuff.  
     foreach my $required_method_name ($self->get_required_method_list) {
+        
+        # FIXME:
+        # This should not call has_method, instead it should
+        # call find_method_by_name (to be added to Class::MOP)
         unless ($other->has_method($required_method_name)) {
             if ($other->isa('Moose::Meta::Role')) {
                 $other->add_required_methods($required_method_name);
@@ -337,6 +341,9 @@ sub _check_required_methods {
             # we need to make sure that the method is 
             # not a method modifier, because those do 
             # not satisfy the requirements ...
+            
+            # FIXME:
+            # This should also call find_method_by_name
             my $method = $other->get_method($required_method_name);
             # check if it is an override or a generated accessor ..
             (!$method->isa('Moose::Meta::Method::Overriden') &&