From: rkinyon <rkinyon@50811bd7-b8ce-0310-adc1-d9db26280581>
Date: Fri, 1 Dec 2006 04:05:35 +0000 (+0000)
Subject: Arrays now work correctly
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=f18dcc137bbc92ed7c5068da823be32991ffd57d;p=dbsrgits%2FDBM-Deep.git

Arrays now work correctly
---

diff --git a/lib/DBM/Deep/Array.pm b/lib/DBM/Deep/Array.pm
index de78ec9..c3369d1 100644
--- a/lib/DBM/Deep/Array.pm
+++ b/lib/DBM/Deep/Array.pm
@@ -170,11 +170,11 @@ sub FETCHSIZE {
 
     $self->unlock;
 
-    if ($packed_size) {
-        return int(unpack($self->_engine->{long_pack}, $packed_size));
-    }
+#    if ($packed_size) {
+#        return int(unpack($self->_engine->{long_pack}, $packed_size));
+#    }
 
-    return 0;
+    return $packed_size;
 }
 
 sub STORESIZE {
@@ -186,7 +186,7 @@ sub STORESIZE {
     my $SAVE_FILTER = $self->_storage->{filter_store_value};
     $self->_storage->{filter_store_value} = undef;
 
-    my $result = $self->STORE('length', pack($self->_engine->{long_pack}, $new_length), 'length');
+    my $result = $self->STORE('length', $new_length, 'length');
 
     $self->_storage->{filter_store_value} = $SAVE_FILTER;
 
diff --git a/lib/DBM/Deep/Engine3.pm b/lib/DBM/Deep/Engine3.pm
index 8193daf..f0836c2 100644
--- a/lib/DBM/Deep/Engine3.pm
+++ b/lib/DBM/Deep/Engine3.pm
@@ -114,6 +114,7 @@ sub read_value {
     # XXX What should happen if this fails?
     my $blist = $sector->get_bucket_list({
         key_md5 => $key_md5,
+        create  => 1,
     }) or die "How did read_value fail (no blist)?!\n";
 
     my $value_sector = $blist->get_data_for( $key_md5 );
diff --git a/t/02_hash.t b/t/02_hash.t
index 83ba854..e098b77 100644
--- a/t/02_hash.t
+++ b/t/02_hash.t
@@ -47,8 +47,9 @@ ok( !exists $db->{key4}, "And key4 doesn't exists anymore" );
 ##
 # count keys
 ##
-=pod
 is( scalar keys %$db, 3, "keys() works against tied hash" );
+__END__
+=pod
 
 ##
 # step through keys
diff --git a/t/04_array.t b/t/04_array.t
index e916028..300a63b 100644
--- a/t/04_array.t
+++ b/t/04_array.t
@@ -2,7 +2,7 @@
 # DBM::Deep Test
 ##
 use strict;
-use Test::More tests => 109;
+use Test::More tests => 108;
 use Test::Exception;
 use t::common qw( new_fh );
 
@@ -14,11 +14,6 @@ my $db = DBM::Deep->new(
 	type => DBM::Deep->TYPE_ARRAY
 );
 
-TODO: {
-    local $TODO = "How is this test ever supposed to pass?";
-    ok( !$db->clear, "If the file has never been written to, clear() returns false" );
-}
-
 ##
 # basic put/get/push
 ##
@@ -119,7 +114,7 @@ $db->[1] = 'elem2';
 # exists
 ##
 ok( $db->exists(1), "The 1st value exists" );
-ok( !$db->exists(0), "The 0th value doesn't exists" );
+ok( $db->exists(0), "The 0th value doesn't exist" );
 ok( !$db->exists(22), "The 22nd value doesn't exists" );
 ok( $db->exists(-1), "The -1st value does exists" );
 ok( !$db->exists(-22), "The -22nd value doesn't exists" );