From: Alexander Hartmaier Date: Mon, 18 Jan 2010 15:04:34 +0000 (+0000) Subject: test and pod fixes X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=f0ac764e09fbcfe66b760747881fe76c5df779ad;p=dbsrgits%2FDBIx-Class-Historic.git test and pod fixes --- diff --git a/lib/SQL/Translator/Parser/DBIx/Class.pm b/lib/SQL/Translator/Parser/DBIx/Class.pm index 8b68e83..43bbfae 100644 --- a/lib/SQL/Translator/Parser/DBIx/Class.pm +++ b/lib/SQL/Translator/Parser/DBIx/Class.pm @@ -428,7 +428,7 @@ sensible thing to do. =over 4 -=item Arguments: @classes +=item Arguments: \@class_names =back diff --git a/t/99dbic_sqlt_parser.t b/t/99dbic_sqlt_parser.t index 1d86ef0..8ebae0d 100644 --- a/t/99dbic_sqlt_parser.t +++ b/t/99dbic_sqlt_parser.t @@ -35,6 +35,12 @@ my @sources = grep $schema->sources ; +my $idx_exceptions = { + 'Artwork' => -1, + 'ForceForeign' => -1, + 'LinerNotes' => -1, +}; + { my $sqlt_schema = create_schema({ schema => $schema, args => { parser_args => { } } }); @@ -42,6 +48,7 @@ my @sources = grep my $table = get_table($sqlt_schema, $schema, $source_name); my $fk_count = scalar(grep { $_->type eq 'FOREIGN KEY' } $table->get_constraints); + $fk_count += $idx_exceptions->{$source_name} || 0; my @indices = $table->get_indices; my $index_count = scalar(@indices); @@ -60,14 +67,15 @@ my @sources = grep { my $sqlt_schema = create_schema({ schema => $schema, args => { parser_args => { add_fk_index => 1 } } }); - foreach my $source (@sources) { - my $table = get_table($sqlt_schema, $schema, $source); + foreach my $source_name (@sources) { + my $table = get_table($sqlt_schema, $schema, $source_name); my $fk_count = scalar(grep { $_->type eq 'FOREIGN KEY' } $table->get_constraints); + $fk_count += $idx_exceptions->{$source_name} || 0; my @indices = $table->get_indices; my $index_count = scalar(@indices); - $index_count++ if ($source eq 'TwoKeys'); # TwoKeys has the index turned off on the rel def - is($index_count, $fk_count, "correct number of indices for $source with add_fk_index => 1"); + $index_count++ if ($source_name eq 'TwoKeys'); # TwoKeys has the index turned off on the rel def + is($index_count, $fk_count, "correct number of indices for $source_name with add_fk_index => 1"); } }