From: Brandon L Black <blblack@gmail.com>
Date: Mon, 16 Apr 2007 02:11:47 +0000 (+0000)
Subject: caching for calcMRO
X-Git-Tag: 0.02~15
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=f0294f1bf66008729a395262dc91d87ad6c9892d;p=gitmo%2FClass-C3-XS.git

caching for calcMRO
---

diff --git a/lib/Class/C3/XS.xs b/lib/Class/C3/XS.xs
index bdf3fa7..951a382 100644
--- a/lib/Class/C3/XS.xs
+++ b/lib/Class/C3/XS.xs
@@ -32,14 +32,13 @@ __mro_linear_isa_c3(pTHX_ HV* stash, HV* cache, I32 level)
               stashname);
 
     if(!cache) {
-        cache = sv_2mortal(newHV());
+        cache = (HV*)sv_2mortal((SV*)newHV());
     }
     else {
-/*
+        sv_dump(cache);
         SV** cache_entry = hv_fetch(cache, stashname, stashname_len, 0);
         if(cache_entry)
             return (AV*)SvREFCNT_inc(*cache_entry);
-*/
     }
 
     /* not in cache, make a new one */
@@ -144,7 +143,7 @@ __mro_linear_isa_c3(pTHX_ HV* stash, HV* cache, I32 level)
     SvREADONLY_on(retval);
     SvREFCNT_inc(retval); /* for cache storage */
     SvREFCNT_inc(retval); /* for return */
-    /* hv_store(cache, stashname, stashname_len, (SV*)retval, 0); */
+    hv_store(cache, stashname, stashname_len, (SV*)retval, 0);
     return retval;
 }
 
@@ -370,7 +369,7 @@ XS(XS_Class_C3_XS_calculateMRO)
         croak("Usage: calculateMRO(classname[, cache])");
 
     classname = ST(0);
-    if(items == 2) cache = (HV*)ST(1);
+    if(items == 2) cache = (HV*)SvRV(ST(1));
 
     class_stash = gv_stashsv(classname, 0);
     if(!class_stash) croak("No such class: '%s'!", SvPV_nolen(classname));