From: Tim Bunce <Tim.Bunce@pobox.com>
Date: Fri, 28 Sep 2012 01:51:20 +0000 (+0900)
Subject: Add logarea param via referer. add bytesToSize. Polish formatting of tooltip
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ee6e37bffaec6f37b696d43b010b2bf9bfdc8df6;p=p5sagit%2FDevel-Size.git

Add logarea param via referer. add bytesToSize. Polish formatting of tooltip
---

diff --git a/static/MemView.pl b/static/MemView.pl
index faf5753..c8ca2ca 100755
--- a/static/MemView.pl
+++ b/static/MemView.pl
@@ -7,6 +7,7 @@ use JSON::XS;
 use Mojolicious::Lite;
 use Getopt::Long;
 use Storable qw(dclone);
+use Devel::Dwarn;
 
 GetOptions(
     'db=s' => \(my $opt_db = '../memnodes.db'),
@@ -35,10 +36,14 @@ get '/' => sub {
 
 get '/jit_tree/:id/:depth' => sub {
     my $self = shift;
-    my $logarea = $self->param('logarea');
 
     my $id = $self->stash('id');
     my $depth = $self->stash('depth');
+
+    my $logarea = (defined $self->param('logarea'))
+        ? $self->param('logarea')
+        : Mojo::URL->new($self->req->headers->referrer)->query->param('logarea');
+
     my $node_tree = _fetch_node_tree($id, $depth);
     my $jit_tree = _transform_node_tree($node_tree, sub {
         my ($node) = @_;
@@ -53,12 +58,14 @@ get '/jit_tree/:id/:depth' => sub {
         $jit_node->{children} = $children if $children;
         return $jit_node;
     });
-if(1){
-    use Devel::Dwarn;
-    use Data::Dump qw(pp);
-    local $jit_tree->{children};
-    pp(dclone($jit_tree)); # dclone to avoid stringification
-}
+
+    if(1){
+        use Devel::Dwarn;
+        use Data::Dump qw(pp);
+        local $jit_tree->{children};
+        pp(dclone($jit_tree)); # dclone to avoid stringification
+    }
+
     $self->render_json($jit_tree);
 };
 
@@ -74,7 +81,9 @@ sub _fetch_node_tree {
     if ($node->{child_ids}) {
         my @child_ids = split /,/, $node->{child_ids};
         my $children;
-        if (@child_ids == 1 && $node->{type} == 2) {
+        if (@child_ids == 1
+            && $node->{type} == 2 # only collapse links
+        ) {
             my $child = _fetch_node_tree($child_ids[0], $depth); # same depth
             # merge node into child
             # XXX id, depth, parent_id
diff --git a/static/public/tm.js b/static/public/tm.js
index 770ff4b..e37d646 100644
--- a/static/public/tm.js
+++ b/static/public/tm.js
@@ -26,6 +26,26 @@ var Log = {
   }
 };
 
+/**
+ * Convert number of bytes into human readable format
+ *
+ * @param integer bytes     Number of bytes to convert
+ * @param integer precision Number of digits after the decimal separator
+ * @return string
+ * via http://codeaid.net/javascript/convert-size-in-bytes-to-human-readable-format-(javascript)
+ */
+function bytesToSize(bytes, precision) {
+    var sizes = ['Bytes', 'KB', 'MB', 'GB', 'TB'];
+    var posttxt = 0;
+    while( bytes >= 1024 ) {
+        posttxt++;
+        bytes = bytes / 1024;
+    }
+    var num = (posttxt) ? Number(bytes).toFixed(precision) : bytes;
+    return num + " " + sizes[posttxt];
+}
+
+
 // http://stackoverflow.com/questions/5199901/how-to-sort-an-associative-array-by-its-values-in-javascript
 function bySortedValue(obj, comparitor, callback, context) {
     var tuples = [];
@@ -47,7 +67,7 @@ function bySortedValue(obj, comparitor, callback, context) {
 
 
 function request_jit_tree(nodeId, level, depth, onComplete){
-    var params = { logarea: 0 };
+    var params = { };//logarea: 0 };
     jQuery.getJSON('jit_tree/'+nodeId+'/'+depth, params, onComplete);
 }
 
@@ -67,7 +87,7 @@ function init(){
     //box offsets
     offset: 1,
     //use canvas text
-    Label: {
+    XXX_Label: {
       type: labelType,
       size: 10,
       family: 'Tahoma, Verdana, Arial'
@@ -123,30 +143,37 @@ function init(){
       onShow: function(tip, node, isLeaf, domElement) {
         var data = node.data;
         var html = "<div class=\"tip-title\">"
-          + (data.title ? data.title : "")
+          + (data.title ? "\""+data.title+"\"" : "")
           + " " + data.name
           + "</div><div class=\"tip-text\">";
 
         html += "<br />";
-        html += sprintf("Size: %d (%d + %d)<br />", data.self_size+data.kids_size, data.self_size, data.kids_size);
-
+        html += sprintf("Memory use: %s<br />", bytesToSize(data.self_size+data.kids_size,2));
+        if (data.kids_size) {
+            html += sprintf("Child use:  %s<br />", bytesToSize(data.kids_size,2));
+        }
         if (data.self_size) {
-            html += sprintf("Memory usage:<br />");
+            html += sprintf("Own use:    %s<br />", bytesToSize(data.self_size,2));
+            html += sprintf("<div style=\"color:grey\">");
             bySortedValue(data.leaves,
                 function(a, b) { return a[1] - b[1] },
-                function(k, v) { html += sprintf(" %10s: %5d<br />", k, v);
+                function(k, v) { html += sprintf(" %9s: %s<br />", k, bytesToSize(v,2));
             });
-            html += "<br />";
+            html += sprintf("</div>");
         }
+        html += "<br />";
 
 
+    if (0) {
         html += sprintf("Attributes:<br />");
         bySortedValue(data.attr,
             function(a, b) { return a[0] > b[0] ? 1 : a[0] < b[0] ? -1 : 0 },
             function(k, v) { html += sprintf(" %10s: %5d<br />", k, v);
         });
         html += "<br />";
+    }
 
+        html += sprintf("<div style=\"color:grey\">");
         if (data.child_count) {
             html += sprintf("Children: %d of %d<br />", data.child_count, data.kids_node_count);
         }
@@ -154,8 +181,9 @@ function init(){
         html += sprintf("Depth: %d<br />", data.depth);
         html += sprintf("Parent: %d<br />", data.parent_id);
 
-        html += JSON.stringify(data.attr, undefined, 4);
+        //html += JSON.stringify(data.attr, undefined, 4);
         //html += JSON.stringify(data, undefined, 4);
+        html += sprintf("</div>");
 
         tip.innerHTML =  html; 
       }  
@@ -191,7 +219,8 @@ function init(){
             style.border = '1px solid transparent';  
         };  
 
-    }
+    },
+    onPlaceLabel: function(domElement, node){ },
   });
 
   request_jit_tree(1, 0, levelsToShow, function(data) {