From: Lupe Christoph <lupe@lupe-christoph.de>
Date: Fri, 10 Nov 2000 09:08:56 +0000 (+0100)
Subject: Explain better why certain regex tests are skipped.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ee595aa61f33e2c496a8bb874b2aa10ecd77c6cc;p=p5sagit%2Fp5-mst-13.2.git

Explain better why certain regex tests are skipped.

Subject: Re: tests skipped: unknown reason
Message-ID: <20001110090856.J785@alanya.lupe-christoph.de>

p4raw-id: //depot/perl@7637
---

diff --git a/t/op/regexp.t b/t/op/regexp.t
index 23ae576..239fa84 100755
--- a/t/op/regexp.t
+++ b/t/op/regexp.t
@@ -26,6 +26,9 @@ $ENV{PERL_DESTRUCT_LEVEL} = 0 unless $ENV{PERL_DESTRUCT_LEVEL} > 3;
 # Column 5 contains the expected result of double-quote
 # interpolating that string after the match, or start of error message.
 #
+# Column 6, if present, contains a reason why the test is skipped.
+# This is printed with "skipped", for harness to pick up.
+#
 # \n in the tests are interpolated, as are variables of the form ${\w+}.
 #
 # If you want to add a regular expression test that can't be expressed
@@ -56,7 +59,7 @@ TEST:
 while (<TESTS>) {
     chomp;
     s/\\n/\n/g;
-    ($pat, $subject, $result, $repl, $expect) = split(/\t/,$_);
+    ($pat, $subject, $result, $repl, $expect, $reason) = split(/\t/,$_,6);
     $input = join(':',$pat,$subject,$result,$repl,$expect);
     infty_subst(\$pat);
     infty_subst(\$expect);
@@ -70,7 +73,8 @@ while (<TESTS>) {
     $expect = $repl = '-' if $skip_amp and $input =~ /\$[&\`\']/;
     $skip = ($skip_amp ? ($result =~ s/B//i) : ($result =~ s/B//));
     # Certain tests don't work with utf8 (the re_test should be in UTF8)
-    $skip = 1 if ($^H &= ~0x00000008) && $pat =~ /\[:\^(alnum|print|word):\]/;
+    $skip = 1, $reason = 'utf8'
+      if ($^H &= ~0x00000008) && $pat =~ /\[:\^(alnum|print|word):\]/;
     $result =~ s/B//i unless $skip;
     for $study ('', 'study \$subject') {
  	$c = $iters;
@@ -81,7 +85,8 @@ while (<TESTS>) {
 	    last;  # no need to study a syntax error
 	}
 	elsif ( $skip ) {
-	    print "ok $. # skipped\n"; next TEST;
+	    print "ok $. # skipped", length($reason) ? " $reason" : '', "\n";
+	    next TEST;
 	}
 	elsif ($@) {
 	    print "not ok $. $input => error `$err'\n"; next TEST;