From: Andy Grundman <andy@hybridized.org>
Date: Fri, 5 Dec 2008 07:17:57 +0000 (+0000)
Subject: Add additional tests to make sure upload temp files are deleted
X-Git-Tag: 5.8000_04~13
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ed4ac83874e7be7d27f20e3ef7b1907dabe97bd7;hp=dbb2d5cd1b69209e53eb204e7451d688327b2e11;p=catagits%2FCatalyst-Runtime.git

Add additional tests to make sure upload temp files are deleted
---

diff --git a/t/aggregate/live_engine_request_uploads.t b/t/aggregate/live_engine_request_uploads.t
index c69dfae..cd57b03 100644
--- a/t/aggregate/live_engine_request_uploads.t
+++ b/t/aggregate/live_engine_request_uploads.t
@@ -6,7 +6,7 @@ use warnings;
 use FindBin;
 use lib "$FindBin::Bin/../lib";
 
-use Test::More tests => 96;
+use Test::More tests => 101;
 use Catalyst::Test 'TestApp';
 
 use Catalyst::Request;
@@ -146,6 +146,8 @@ use Path::Class::Dir;
     ok( $response->is_success, 'Response Successful 2xx' );
     is( $response->content_type, 'text/plain', 'Response Content-Type' );
     is( $response->content, ( $request->parts )[0]->content, 'Content' );
+    
+    # XXX: no way to test that temporary file for this test was deleted
 }
 
 {
@@ -183,6 +185,20 @@ use Path::Class::Dir;
     is( $response->content_type, 'text/plain', 'Response Content-Type' );
     like( $response->content, qr/file1 => bless/, 'Upload with name file1');
     like( $response->content, qr/file2 => bless/, 'Upload with name file2');
+    
+    my $creq;
+    {
+        no strict 'refs';
+        ok(
+            eval '$creq = ' . $response->content,
+            'Unserialize Catalyst::Request'
+        );
+    }
+    
+    for my $file ( $creq->upload ) {
+        my $upload = $creq->upload($file);
+        ok( !-e $upload->tempname, 'Upload temp file was deleted' );
+    }
 }
 
 {
@@ -240,7 +256,8 @@ use Path::Class::Dir;
 
         is( $upload->type, $part->content_type, 'Upload Content-Type' );
         is( $upload->size, length( $part->content ), 'Upload Content-Length' );
-        is( $upload->filename, 'catalyst_130pix.gif' );
+        is( $upload->filename, 'catalyst_130pix.gif', 'Upload Filename' );
+        ok( !-e $upload->tempname, 'Upload temp file was deleted' );
     }
 }
 
@@ -335,6 +352,8 @@ use Path::Class::Dir;
         is( $upload->size, length( $part->content ), 'Upload Content-Length' );
 
         like( $upload->tempname, qr{\Q$dir\E}, 'uploadtmp' );
+
+        ok( !-e $upload->tempname, 'Upload temp file was deleted' );
     }
 }