From: Rafael Kitover <rkitover@cpan.org>
Date: Sun, 26 Dec 2010 11:37:02 +0000 (-0500)
Subject: fix column info bug, all tests pass
X-Git-Tag: 0.07003~15
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ed18888ff8321c761bae36b744a015098374c616;p=dbsrgits%2FDBIx-Class-Schema-Loader.git

fix column info bug, all tests pass
---

diff --git a/lib/DBIx/Class/Schema/Loader/DBI.pm b/lib/DBIx/Class/Schema/Loader/DBI.pm
index 333eda2..8946c99 100644
--- a/lib/DBIx/Class/Schema/Loader/DBI.pm
+++ b/lib/DBIx/Class/Schema/Loader/DBI.pm
@@ -324,7 +324,7 @@ sub _columns_info_for {
     my $sth = $self->_sth_for($table, undef, \'1 = 0');
     $sth->execute;
 
-    my @columns = $sth->{NAME};
+    my @columns = @{ $sth->{NAME} };
 
     for my $i (0 .. $#columns) {
         my $column_info = {};
diff --git a/lib/DBIx/Class/Schema/Loader/DBI/Informix.pm b/lib/DBIx/Class/Schema/Loader/DBI/Informix.pm
index b2a685d..c005180 100644
--- a/lib/DBIx/Class/Schema/Loader/DBI/Informix.pm
+++ b/lib/DBIx/Class/Schema/Loader/DBI/Informix.pm
@@ -186,7 +186,6 @@ sub _columns_info_for {
     my $result = $self->next::method(@_);
 
     my $dbh = $self->schema->storage->dbh;
-    local $dbh->{FetchHashKeyName} = 'NAME_lc';
 
     my $sth = $dbh->prepare(<<'EOF');
 select c.colname, c.coltype, c.collength, c.colmin, d.type deflt_type, d.default deflt
diff --git a/t/lib/dbixcsl_common_tests.pm b/t/lib/dbixcsl_common_tests.pm
index af826f2..ac62a55 100644
--- a/t/lib/dbixcsl_common_tests.pm
+++ b/t/lib/dbixcsl_common_tests.pm
@@ -98,6 +98,7 @@ sub run_tests {
     my $num_rescans = 5;
     $num_rescans-- if $self->{vendor} =~ /^(?:sybase|mysql)\z/i;
     $num_rescans++ if $self->{vendor} eq 'mssql';
+    $num_rescans++ if $self->{vendor} eq 'Firebird';
 
     plan tests => @connect_info *
         (182 + $num_rescans * $column_accessor_map_tests + $extra_count + ($self->{data_type_tests}{test_count} || 0));