From: Nicholas Clark Date: Wed, 10 Mar 2004 20:38:49 +0000 (+0000) Subject: croaking for readonly SVs in Perl_sv_utf8_upgrade_flags was a mistake X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ebc91362714bda54cacd3ec2407cd23a2dc04902;p=p5sagit%2Fp5-mst-13.2.git croaking for readonly SVs in Perl_sv_utf8_upgrade_flags was a mistake back this out until we have a tangible policy p4raw-id: //depot/perl@22483 --- diff --git a/sv.c b/sv.c index ad9c33a..70e157d 100644 --- a/sv.c +++ b/sv.c @@ -3477,10 +3477,6 @@ Perl_sv_utf8_upgrade_flags(pTHX_ register SV *sv, I32 flags) sv_force_normal_flags(sv, 0); } - if (SvREADONLY(sv)) { - Perl_croak(aTHX_ PL_no_modify); - } - if (PL_encoding && !(flags & SV_UTF8_NO_ENCODING)) sv_recode_to_utf8(sv, PL_encoding); else { /* Assume Latin-1/EBCDIC */