From: Tyler Riddle <t.riddle@shadowcat.co.uk>
Date: Mon, 14 Jan 2013 22:18:43 +0000 (-0800)
Subject: make notes of things to fix before release
X-Git-Tag: v0.003001_01~19
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=eb351344773af82344bd550ffd5a8814b816cfeb;p=scpubgit%2FObject-Remote.git

make notes of things to fix before release
---

diff --git a/lib/Object/Remote/Connection.pm b/lib/Object/Remote/Connection.pm
index 136b065..307cde3 100644
--- a/lib/Object/Remote/Connection.pm
+++ b/lib/Object/Remote/Connection.pm
@@ -23,6 +23,9 @@ BEGIN { router()->exclude_forwarding }
 END {
   log_debug { "Killing all child processes in the process group" };
     
+  #FIXME update along with setpgrp() to not use a process
+  #group anymore
+  
   #send SIGINT to the process group for our children
   kill(1, -2);
 }
@@ -94,6 +97,8 @@ after BUILD => sub {
     
   log_trace { "Setting process group of child process '$pid'" };
   
+  #FIXME moving things into a process group has side effects for
+  #users of the library - move to a list
   setpgrp($self->child_pid, 1);
 };
 
diff --git a/lib/Object/Remote/FatNode.pm b/lib/Object/Remote/FatNode.pm
index 0d4ee05..b5f3437 100644
--- a/lib/Object/Remote/FatNode.pm
+++ b/lib/Object/Remote/FatNode.pm
@@ -68,12 +68,8 @@ my @core_non_arch = grep +(
     or /\Q$Config{archname}/ or /\Q$Config{myarchname}/)
 ), keys %mods;
 
-#print STDERR "non-core non-arch ", Dumper(\@non_core_non_arch);
-#print STDERR "core non-arch ", Dumper(\@core_non_arch);
-
-#TODO this is the wrong path to go down - fork() will bring
-#the env vars with it and the ssh connector can handle
-#forwarding the env vars
+#FIXME - encode the env vars in YAML or something similiar and make the
+#env vars that will be forwarded driven by a list
 my $env_pass = '';
 if (defined($ENV{OBJECT_REMOTE_LOG_LEVEL})) {
   my $level = $ENV{OBJECT_REMOTE_LOG_LEVEL};
diff --git a/lib/Object/Remote/Role/Connector/PerlInterpreter.pm b/lib/Object/Remote/Role/Connector/PerlInterpreter.pm
index 0964863..933924e 100644
--- a/lib/Object/Remote/Role/Connector/PerlInterpreter.pm
+++ b/lib/Object/Remote/Role/Connector/PerlInterpreter.pm
@@ -33,6 +33,7 @@ sub _build_module_sender {
   return $hook ? $hook->sender : Object::Remote::ModuleSender->new;
 }
 
+#FIXME by policy object-remote does not invoke a shell
 sub _build_perl_command {
   my ($self) = @_;
   my $nice = $self->nice;