From: Matt S Trout Date: Sat, 12 Oct 2013 16:00:52 +0000 (+0000) Subject: t/sqlmaker/quotes/quotes.t - ORDER BY parsing means we quote, but not misquote X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=eac74d05474090857395e3632ec2d53d5ebe5999;p=dbsrgits%2FDBIx-Class.git t/sqlmaker/quotes/quotes.t - ORDER BY parsing means we quote, but not misquote --- diff --git a/t/sqlmaker/quotes/quotes.t b/t/sqlmaker/quotes/quotes.t index 1566a7d..a4c14f4 100644 --- a/t/sqlmaker/quotes/quotes.t +++ b/t/sqlmaker/quotes/quotes.t @@ -39,7 +39,7 @@ like($sql, qr/ORDER BY `\Q${order}\E`/, 'quoted ORDER BY with DESC (should use a $rs = $schema->resultset('CD')->search({}, { 'order_by' => \$order }); eval { $rs->first }; -like($sql, qr/ORDER BY \Q${order}\E/, 'did not quote ORDER BY with scalarref'); +like($sql, qr/ORDER BY `year` DESC/, 'did not misquote ORDER BY with scalarref'); $schema->storage->sql_maker->quote_char([qw/[ ]/]); $schema->storage->sql_maker->name_sep('.');