From: Rafael Kitover <rkitover@cpan.org>
Date: Sat, 20 Feb 2010 05:17:06 +0000 (-0500)
Subject: fix relnames in _id strip warning
X-Git-Tag: 0.05003~1
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=e9c09ed914e7c5e8c504825f41100b930f32b8fc;p=dbsrgits%2FDBIx-Class-Schema-Loader.git

fix relnames in _id strip warning
---

diff --git a/lib/DBIx/Class/Schema/Loader/RelBuilder.pm b/lib/DBIx/Class/Schema/Loader/RelBuilder.pm
index d97ec0c..ef387bd 100644
--- a/lib/DBIx/Class/Schema/Loader/RelBuilder.pm
+++ b/lib/DBIx/Class/Schema/Loader/RelBuilder.pm
@@ -248,8 +248,12 @@ sub generate_code {
         if($counters{$remote_moniker} > 1) {
             my $colnames = q{_} . join(q{_}, @$local_cols);
             $remote_relname .= $colnames if keys %cond > 1;
-            $local_relname   = $self->_multi_rel_local_relname(
-                $remote_class, $local_table, $local_cols
+
+            my $is_singular =
+              ($self->_uniq_fk_rel($local_moniker, 'dummy', $local_cols, $uniqs))[0] ne 'has_many';
+
+            $local_relname = $self->_multi_rel_local_relname(
+                $remote_class, $local_table, $local_cols, $is_singular
             );
         } else {
             $local_relname = $self->_inflect_plural(lc $local_table);
@@ -291,16 +295,19 @@ sub generate_code {
 }
 
 sub _multi_rel_local_relname {
-    my ($self, $remote_class, $local_table, $local_cols) = @_;
+    my ($self, $remote_class, $local_table, $local_cols, $is_singular) = @_;
+
+    my $inflect = $is_singular ? '_inflect_singular' : '_inflect_plural';
+    $inflect    = $self->can($inflect);
 
     my $colnames = q{_} . join(q{_}, @$local_cols);
     my $old_relname = #< TODO: remove me after 0.05003 release
     my $local_relname = lc($local_table) . $colnames;
     my $stripped_id = $local_relname =~ s/_id$//; #< strip off any trailing _id
-    $local_relname = $self->_inflect_plural( $local_relname );
+    $local_relname = $self->$inflect( $local_relname );
 
     # TODO: remove me after 0.05003 release
-    $old_relname = $self->_inflect_plural( $old_relname );
+    $old_relname = $self->$inflect( $old_relname );
     warn __PACKAGE__." $VERSION: warning, stripping trailing _id from ${remote_class} relation '$old_relname', renaming to '$local_relname'.  This behavior is new as of 0.05003.\n"
         if $stripped_id;