From: Brandon L Black Date: Fri, 11 May 2007 13:32:34 +0000 (+0000) Subject: depend on Class::C3 and implement C with caveats X-Git-Tag: 0.02~7 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=e9b18837eb3285efef82f61b5a90908798a685f2;p=gitmo%2FMRO-Compat.git depend on Class::C3 and implement C with caveats --- diff --git a/Makefile.PL b/Makefile.PL index c1686a0..f82bf35 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -5,5 +5,9 @@ all_from 'lib/MRO/Compat.pm'; build_requires 'Test::More' => '0.47'; +if($] < 5.009_005) { + requires 'Class::C3' => '0.17'; +} + auto_install; WriteAll; diff --git a/lib/MRO/Compat.pm b/lib/MRO/Compat.pm index 81721ef..acdac69 100644 --- a/lib/MRO/Compat.pm +++ b/lib/MRO/Compat.pm @@ -1,21 +1,16 @@ package MRO::Compat; use strict; use warnings; +require 5.006_000; our $VERSION = '0.01'; -# Is Class::C3 installed locally? -our $C3_INSTALLED; - BEGIN { - # Don't do anything if 5.9.5+ + # Alias our private functions over to + # the mro:: namespace and load + # Class::C3 if Perl < 5.9.5 if($] < 5.009_005) { - # Find out if we have Class::C3 at all - eval { require Class::C3 }; - $C3_INSTALLED = 1 if !$@; - - # Alias our private functions over to - # the mro:: namespace + require Class::C3; *mro::import = \&__import; *mro::get_linear_isa = \&__get_linear_isa; *mro::set_mro = \&__set_mro; @@ -26,6 +21,14 @@ BEGIN { *mro::invalidate_all_method_caches = \&__invalidate_all_method_caches; } + + # Provide no-op Class::C3::.*initialize() funcs for 5.9.5+ + else { + no warnings 'redefine'; + *Class::C3::initialize = sub { 1 }; + *Class::C3::reinitialize = sub { 1 }; + *Class::C3::uninitialize = sub { 1 }; + } } =head1 NAME @@ -53,12 +56,13 @@ with method resolution order and method caching in general in Perl 5.9.5 and higher. This module provides a subset of those interfaces for -earlier versions of Perl. It is a harmless no-op to use -it on 5.9.5+. If you're writing a piece of software -that would like to use the parts of 5.9.5+'s mro:: -interfaces that are supported here, and you want -compatibility with older Perls, this is the module -for you. +earlier versions of Perl (back to 5.6.0 anyways). + +It is a harmless no-op to use it on 5.9.5+. If you're +writing a piece of software that would like to use the +parts of 5.9.5+'s mro:: interfaces that are supported +here, and you want compatibility with older Perls, this +is the module for you. This module never exports any functions. All calls must be fully qualified with the C prefix. @@ -76,11 +80,6 @@ classes that would be visited in the process of resolving a method on the given class, starting with itself. It does not include any duplicate entries. -On pre-5.9.5 Perls with MRO::Compat, explicitly asking for the C -MRO of a class will die if L is not installed. If -L is installed, it will detect C3 classes and return the -correct C3 MRO unless explicitly asked to return the C MRO. - Note that C (and any members of C's MRO) are not part of the MRO of a class, even though all classes implicitly inherit methods from C and its parents. @@ -121,37 +120,64 @@ sub __get_linear_isa { =head2 mro::import -Not supported, and hence 5.9.5's "use mro 'foo'" is also not supported. -These will die if used on pre-5.9.5 Perls. +This allows the C and +C syntaxes, providing you +L first. Please see the +L section for additional details. =cut sub __import { - die q{The "use mro 'foo'" is only supported on Perl 5.9.5+}; + if($_[1]) { + goto &Class::C3::import if $_[1] eq 'c3'; + __set_mro(scalar(caller), $_[1]); + } } =head2 mro::set_mro($classname, $type) -Not supported, will die if used on pre-5.9.5 Perls. +Sets the mro of C<$classname> to one of the types +C or C. Please see the L +section for additional details. =cut sub __set_mro { - die q{mro::set_mro() is only supported on Perl 5.9.5+}; + my ($classname, $type) = @_; + if(!$classname || !$type) { + die q{Usage: mro::set_mro($classname, $type)}; + } + if($type eq 'c3') { + eval "package $classname; use Class::C3"; + die $@ if $@; + } + if($type ne 'dfs') { + die q{Invalid mro type "$type"}; + } + + # In the dfs case, check whether we need to + # undo C3 + if(defined $Class::C3::MRO{$classname}) { + Class::C3::_remove_method_dispatch_table($classname); + } + delete $Class::C3::MRO{$classname}; + + return; } =head2 mro::get_mro($classname) Returns the MRO of the given class (either C or C). +It considers any Class::C3-using class to have C3 MRO +even before L is called. + =cut sub __get_mro { my $classname = shift; die "mro::get_mro requires a classname" if !$classname; - if($C3_INSTALLED && exists $Class::C3::MRO{$classname}) { - return 'c3'; - } + return 'c3' if exists $Class::C3::MRO{$classname}; return 'dfs'; } @@ -161,6 +187,9 @@ Not supported, will die if used on pre-5.9.5 Perls. =cut +# In theory this could be made to work, but it would +# be an insanely slow algorithm if any reasonably large +# number of modules were loaded. sub __get_isarev { die "mro::get_isarev() is only supported on Perl 5.9.5+"; } @@ -220,6 +249,24 @@ sub __method_changed_in { __invalidate_all_method_caches(); } +=head1 USING C3 + +While this module makes the 5.9.5+ syntaxes +C and C available +on older Perls, it does so merely by passing off the work +to L. + +It does not remove the need for you to call +L's C, C, and/or +C at the appropriate times +as documented in the L docs. + +Because L has L as a pre-requisite, +and requires it at C time, you can blindly call +those functions in code that uses L. +Under 5.9.5+ with L, your calls to those +functions will become a no-op and everything will work fine. + =head1 SEE ALSO L