From: Tim Bunce <Tim.Bunce@pobox.com>
Date: Thu, 4 Oct 2012 08:47:35 +0000 (+0100)
Subject: No longer chase CvSTART (dubious before 5.17 and broken with it)
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=e913c9413972d3953015850ce0bc914e49b7a78c;p=p5sagit%2FDevel-Size.git

No longer chase CvSTART (dubious before 5.17 and broken with it)
---

diff --git a/SizeMe.xs b/SizeMe.xs
index ddef672..3178176 100644
--- a/SizeMe.xs
+++ b/SizeMe.xs
@@ -831,6 +831,12 @@ op_size_class(pTHX_ const OP * const baseop, opclass op_class, bool skip_op_stru
 	if(!check_new(st, baseop))
 	    return;
 	TAG;
+
+/* segv on OPc_LISTOP op_size(baseop->op_last) is, I suspect, the first symptom of need to handle slabbed allocation of OPs */
+#if (PERL_BCDVERSION >= 0x5017000)
+if(0)do_op_dump(0, Perl_debug_log, baseop);
+#endif
+
 	op_size(aTHX_ baseop->op_next, st, NPathOpLink);
 #ifdef PELR_MAD
 	madprop_size(aTHX_ st, NPathOpLink, baseop->op_madprop);
@@ -1283,7 +1289,7 @@ else warn("skipped suspect HeVAL %p", HeVAL(cur_entry));
     if (CvISXSUB(thing)) {
 	sv_size(aTHX_ st, NPathLink("cv_const_sv"), cv_const_sv((CV *)thing), recurse);
     } else {
-	if(1)op_size(aTHX_ CvSTART(thing), st, NPathLinkAndNode("CvSTART", "OPs")); /* XXX ? */
+	/* Note that we don't chase CvSTART */
 	op_size(aTHX_ CvROOT(thing), st, NPathLinkAndNode("CvROOT", "OPs"));
     }
     goto freescalar;