From: Tim Bunce (via RT) <perlbug-followup@perl.org>
Date: Wed, 25 Nov 2009 11:02:24 +0000 (-0800)
Subject: perlbug reports "Message sent" even when it hasn't
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=e90b02b98382872bd43097b9b146a9b00ca3171b;p=p5sagit%2Fp5-mst-13.2.git

perlbug reports "Message sent" even when it hasn't

perlbug doesn't check the return status of Mail::Send and so reports
"Message sent" even if it hasn't:
---

diff --git a/utils/perlbug.PL b/utils/perlbug.PL
index 8862a94..c015e25 100644
--- a/utils/perlbug.PL
+++ b/utils/perlbug.PL
@@ -1134,7 +1134,7 @@ sub _send_message_mailsend {
     open(REP, "<$filename") or die "Couldn't open '$filename': $!\n";
     while (<REP>) { print $fh $_ }
     close(REP) or die "Error closing $filename: $!";
-    $fh->close;
+    $fh->close or die "Error sending mail: $!";
 
     print "\nMessage sent.\n";
 }