From: Hugo van der Sanden Date: Thu, 27 Jun 2002 11:58:57 +0000 (+0100) Subject: Re: [ID 20020626.011] wantarray() causes clobbering of unrelated vars outside the sub X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=e348be647728276e631aaeacbb83b6583aa52129;p=p5sagit%2Fp5-mst-13.2.git Re: [ID 20020626.011] wantarray() causes clobbering of unrelated vars outside the sub Message-ID: <200206271058.g5RAwvE29057@crypt.compulink.co.uk> p4raw-id: //depot/perl@17369 --- diff --git a/op.c b/op.c index 0038680..9a53f07 100644 --- a/op.c +++ b/op.c @@ -3900,6 +3900,8 @@ S_new_logop(pTHX_ I32 type, I32 flags, OP** firstp, OP** otherp) } } else if (first->op_type == OP_WANTARRAY) { + /* XXX true only if this result will be returned, else should + propagate outer context */ if (type == OP_AND) list(other); else @@ -3995,6 +3997,8 @@ Perl_newCONDOP(pTHX_ I32 flags, OP *first, OP *trueop, OP *falseop) } } else if (first->op_type == OP_WANTARRAY) { + /* XXX true only if this result will be returned, else should + propagate outer context */ list(trueop); scalar(falseop); }