From: Matt S Trout <mst@shadowcat.co.uk>
Date: Mon, 18 Mar 2013 19:04:28 +0000 (+0000)
Subject: need to detect lack of order at all, not lack of ident containing order
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=e0ed0a766aab4f6d7383da19b43badba5f5850ce;p=dbsrgits%2FDBIx-Class-Historic.git

need to detect lack of order at all, not lack of ident containing order
---

diff --git a/lib/DBIx/Class/Storage/DBIHacks.pm b/lib/DBIx/Class/Storage/DBIHacks.pm
index 8392fb3..a089867 100644
--- a/lib/DBIx/Class/Storage/DBIHacks.pm
+++ b/lib/DBIx/Class/Storage/DBIHacks.pm
@@ -653,10 +653,10 @@ sub _order_by_is_stable {
   my $conv = $self->sqla_converter;
 
   $self->_scan_identifiers(
-    sub { push @ident_dq, $_[0] }, $conv->_order_by_to_dq($order_by)
+    sub { push @ident_dq, $_[0] }, my $order_dq = $conv->_order_by_to_dq($order_by)
   );
 
-  return unless @ident_dq;
+  return unless $order_dq;
 
   if ($where) {
     # old _extract_fixed_condition_columns logic