From: Steve Hay <SteveHay@planit.com>
Date: Mon, 25 Jul 2005 11:53:44 +0000 (+0000)
Subject: Silence uninitialized value warnings in Net::Cmd
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=df76848ee32b55bf5d182b087f9159faa8bd33f8;p=p5sagit%2Fp5-mst-13.2.git

Silence uninitialized value warnings in Net::Cmd

(Suppresses 20 such warnings emitted by lib/Net/t/datasend.t)

p4raw-id: //depot/perl@25224
---

diff --git a/lib/Net/Cmd.pm b/lib/Net/Cmd.pm
index a84b4da..b39375f 100644
--- a/lib/Net/Cmd.pm
+++ b/lib/Net/Cmd.pm
@@ -21,7 +21,7 @@ BEGIN {
   }
 }
 
-$VERSION = "2.26";
+$VERSION = "2.26_01";
 @ISA     = qw(Exporter);
 @EXPORT  = qw(CMD_INFO CMD_OK CMD_MORE CMD_REJECT CMD_ERROR CMD_PENDING);
 
@@ -431,7 +431,8 @@ sub datasend
  while($len)
   {
    my $wout;
-   if (select(undef,$wout=$win, undef, $timeout) > 0 or -f $cmd) # -f for testing on win32
+   my $s = select(undef,$wout=$win, undef, $timeout);
+   if ((defined $s and $s > 0) or -f $cmd) # -f for testing on win32
     {
      my $w = syswrite($cmd, $line, $len, $offset);
      unless (defined($w))