From: Arthur Axel 'fREW' Schmidt <frioux@gmail.com>
Date: Sun, 28 Mar 2010 05:32:06 +0000 (-0500)
Subject: fix monotonic for error checking
X-Git-Tag: v0.001000_01~37
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=df0fcae90ce59913f26ae281ad8124952cf11542;p=dbsrgits%2FDBIx-Class-DeploymentHandler.git

fix monotonic for error checking
---

diff --git a/lib/DBIx/Class/DeploymentHandler/VersionHandler/Monotonic.pm b/lib/DBIx/Class/DeploymentHandler/VersionHandler/Monotonic.pm
index b3dcfac..707e9fe 100644
--- a/lib/DBIx/Class/DeploymentHandler/VersionHandler/Monotonic.pm
+++ b/lib/DBIx/Class/DeploymentHandler/VersionHandler/Monotonic.pm
@@ -37,7 +37,7 @@ sub _build__version { $_[0]->database_version }
 
 sub previous_version_set {
   my $self = shift;
-  if ($self->to_vesion > $self->_version) {
+  if ($self->to_version > $self->_version) {
     croak "you are trying to downgrade and your current version is less\n".
           "than the version you are trying to downgrade to.  Either upgrade\n".
           "or update your schema"
@@ -51,7 +51,7 @@ sub previous_version_set {
 
 sub next_version_set {
   my $self = shift;
-  if ($self->to_vesion < $self->_version) {
+  if ($self->to_version < $self->_version) {
     croak "you are trying to upgrade and your current version is greater\n".
           "than the version you are trying to upgrade to.  Either downgrade\n".
           "or update your schema"
diff --git a/t/version_handlers/monotonic.t b/t/version_handlers/monotonic.t
index a2e2e76..33cdfa8 100644
--- a/t/version_handlers/monotonic.t
+++ b/t/version_handlers/monotonic.t
@@ -53,14 +53,6 @@ use aliased
 	 'first version pair works'
   );
   ok(
-	 eq_array($vh->previous_version_set, [1,2]),
-	 'doing previous version works'
-  );
-  ok(
-	 eq_array($vh->next_version_set, [1,2]),
-	 'first version pair works again'
-  );
-  ok(
 	 eq_array($vh->next_version_set, [2,3]),
 	 'second version pair works'
   );
@@ -81,7 +73,7 @@ dies_ok {
 	 schema_version   => 2,
 	 database_version => '1.1',
   });
-  $vh->next_vesion_set
+  $vh->next_version_set
 } 'dies if database version not an Int';
 
 dies_ok {
@@ -90,7 +82,17 @@ dies_ok {
 	 schema_version   => 1,
 	 database_version => 1,
   });
-} 'cannot request a version before the current version';
+  $vh->next_version_set;
+} 'cannot request an upgrade version before the current version';
+
+dies_ok {
+  my $vh = Monotonic->new({
+	 to_version       => 2,
+	 schema_version   => 1,
+	 database_version => 1,
+  });
+  $vh->previous_version_set;
+} 'cannot request a downgrade version after the current version';
 
 done_testing;
 #vim: ts=2 sw=2 expandtab