From: Nicholas Clark Date: Sat, 6 Oct 2007 10:27:17 +0000 (+0000) Subject: Optimise the logic in isPRINT(), possible following Jarkko's bugfix X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=dc7a1c0287185201962596e8d86ebf149649d565;p=p5sagit%2Fp5-mst-13.2.git Optimise the logic in isPRINT(), possible following Jarkko's bugfix of change 10855. (to the implementation added in change 18) Nothing that a decent compiler optimiser would have missed. p4raw-id: //depot/perl@32041 --- diff --git a/handy.h b/handy.h index c0cd4c8..7bb4a63 100644 --- a/handy.h +++ b/handy.h @@ -443,7 +443,7 @@ Converts the specified character to lowercase. # define isASCII(c) ((c) <= 127) # define isCNTRL(c) ((c) < ' ' || (c) == 127) # define isGRAPH(c) (isALNUM(c) || isPUNCT(c)) -# define isPRINT(c) (((c) > 32 && (c) < 127) || (c) == ' ') +# define isPRINT(c) (((c) >= 32 && (c) < 127)) # define isPUNCT(c) (((c) >= 33 && (c) <= 47) || ((c) >= 58 && (c) <= 64) || ((c) >= 91 && (c) <= 96) || ((c) >= 123 && (c) <= 126)) # define isXDIGIT(c) (isDIGIT(c) || ((c) >= 'a' && (c) <= 'f') || ((c) >= 'A' && (c) <= 'F')) # define toUPPER(c) (isLOWER(c) ? (c) - ('a' - 'A') : (c))