From: Nicholas Clark Date: Fri, 10 Feb 2012 20:01:57 +0000 (+0000) Subject: Skip tests in t/magic.t that use formline on 5.8.1 and 5.8.2 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=dc1ab564693a4caf2a2f1c83c1ee1665c0705943;p=p5sagit%2FDevel-Size.git Skip tests in t/magic.t that use formline on 5.8.1 and 5.8.2 Those versions have a buggy formline that can trigger an assertion failure. --- diff --git a/CHANGES b/CHANGES index ef94d1c..444da7b 100644 --- a/CHANGES +++ b/CHANGES @@ -3,6 +3,8 @@ Revision history for Perl extension Devel::Size. 0.77_50 2012-02-10 nicholas * t/globs.t was failing on 5.15.6 and later due to side effects of a change to strict.pm [CPAN #73998] + * skip tests in t/magic.t that use formline on 5.8.1 and 5.8.2, as those + versions have a buggy formline that can trigger an assertion failure. 0.77 2011-05-16 nicholas [no changes] diff --git a/t/magic.t b/t/magic.t index 8dfb6de..97770ab 100644 --- a/t/magic.t +++ b/t/magic.t @@ -15,7 +15,12 @@ require Tie::Scalar; 'size increases due to magic'); } -{ +SKIP: { + # bug in perl added in blead by commit 815f25c6e302f84e, fixed in commit + # f5c235e79ea25787, merged to maint-5.8 as 0710cc63c26afd0c and + # 8298b2e171ce84cf respectively. + skip("This triggers a formline assertion on $]", 4) + if $] > 5.008000 && $] < 5.008003; my $string = 'Perl Rules'; my $before_size = total_size($string); formline $string;