From: Matt S Trout <mst@shadowcat.co.uk>
Date: Wed, 27 Mar 2019 04:00:08 +0000 (+0000)
Subject: remove $logic from maybe_list_expr
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=dbc10abd32c48b023b9ce3d2a0c458c27f48d503;p=scpubgit%2FQ-Branch.git

remove $logic from maybe_list_expr
---

diff --git a/lib/SQL/Abstract.pm b/lib/SQL/Abstract.pm
index d5e90ad..d10aeae 100644
--- a/lib/SQL/Abstract.pm
+++ b/lib/SQL/Abstract.pm
@@ -296,7 +296,7 @@ sub _returning {
   my $f = $options->{returning};
 
   my ($sql, @bind) = $self->render_aqt(
-    $self->_expand_maybe_list_expr($f, undef, -ident)
+    $self->_expand_maybe_list_expr($f, -ident)
   );
   return wantarray
     ? $self->_sqlcase(' returning ') . $sql
@@ -498,7 +498,7 @@ sub _select_fields {
   my ($self, $fields) = @_;
   return $fields unless ref($fields);
   return $self->render_aqt(
-    $self->_expand_maybe_list_expr($fields, undef, '-ident')
+    $self->_expand_maybe_list_expr($fields, '-ident')
   );
 }
 
@@ -1335,7 +1335,7 @@ sub _table  {
   my $self = shift;
   my $from = shift;
   ($self->render_aqt(
-    $self->_expand_maybe_list_expr($from, undef, -ident)
+    $self->_expand_maybe_list_expr($from, -ident)
   ))[0];
 }
 
@@ -1345,7 +1345,7 @@ sub _table  {
 #======================================================================
 
 sub _expand_maybe_list_expr {
-  my ($self, $expr, $logic, $default) = @_;
+  my ($self, $expr, $default) = @_;
   my $e = do {
     if (ref($expr) eq 'ARRAY') {
       return { -list => [