From: Matt S Trout <mst@shadowcat.co.uk>
Date: Mon, 4 Nov 2013 01:30:07 +0000 (+0000)
Subject: require explicit nulls first/last
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=db628d9ab39bf80f88432a1c2cc749152e5ff13d;p=dbsrgits%2FData-Query.git

require explicit nulls first/last
---

diff --git a/lib/Data/Query/Renderer/SQL/Naive.pm b/lib/Data/Query/Renderer/SQL/Naive.pm
index dbe4b80..a84981b 100644
--- a/lib/Data/Query/Renderer/SQL/Naive.pm
+++ b/lib/Data/Query/Renderer/SQL/Naive.pm
@@ -379,8 +379,8 @@ sub _order_chunk {
     ($dq->{reverse}
       ? $self->_format_keyword('DESC')
       : ()),
-    ($dq->{nulls}
-      ? $self->_format_keyword('NULLS '.('', qw(FIRST LAST))[$dq->{nulls}])
+    ($dq->{nulls} && $dq->{nulls} =~ /^(first|last)$/i
+      ? $self->_format_keyword('NULLS '.$dq->{nulls})
       : ()),
   );
 }