From: Tomas Doran Date: Sat, 18 Oct 2008 16:05:24 +0000 (+0000) Subject: Add plans to tests so that aggregate smoke results work correctly. Without a plan... X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=d9d890bc03f7f426533afc6295fc68a087c88712;p=catagits%2FCatalyst-Plugin-Authentication.git Add plans to tests so that aggregate smoke results work correctly. Without a plan, failing to compile the test apps (as happens if you run them against 5.80 trunk currently) doesn't look like a real fail. --- diff --git a/Changes b/Changes index facc8a8..ccad9d3 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,8 @@ Revision history for Perl extension Catalyst::Plugin::Authentication 0.1XXX XXXX - Update tests prereqs to include Test::Exception (RT #36339) + - Update live tests to have plans, so that smoke tests against + 5.80 don't give false positives (t0m) 0.10007_01 2008-06-05 - Some documentation fixes (including RT #36062) diff --git a/t/live_app.t b/t/live_app.t index af9042c..d3da817 100644 --- a/t/live_app.t +++ b/t/live_app.t @@ -1,11 +1,10 @@ use strict; use warnings; -use Test::More; +use Test::More tests => 1; BEGIN { plan skip_all => "Digest::SHA1 is required for this test" unless eval { require Digest::SHA1 }; - plan "no_plan"; } use lib 't/lib'; diff --git a/t/live_app_realms.t b/t/live_app_realms.t index db6efb2..0e1fbc6 100644 --- a/t/live_app_realms.t +++ b/t/live_app_realms.t @@ -1,11 +1,7 @@ use strict; use warnings; -use Test::More; - -BEGIN { - plan "no_plan"; -} +use Test::More tests => 1; use lib 't/lib'; use Catalyst::Test qw/AuthRealmTestApp/; diff --git a/t/live_app_realms_compat.t b/t/live_app_realms_compat.t index 5deccf1..a4bbbbb 100644 --- a/t/live_app_realms_compat.t +++ b/t/live_app_realms_compat.t @@ -1,11 +1,7 @@ use strict; use warnings; -use Test::More; - -BEGIN { - plan "no_plan"; -} +use Test::More tests => 1; use lib 't/lib'; use Catalyst::Test qw/AuthRealmTestAppCompat/;