From: Gurusamy Sarathy <gsar@engin.umich.edu>
Date: Fri, 10 Jan 1997 07:45:11 +0000 (-0500)
Subject: Fix for anon-lists with tied entries coredump
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=d976ac8220f8890bb7663152c4870f60e8e018c8;p=p5sagit%2Fp5-mst-13.2.git

Fix for anon-lists with tied entries coredump

[George Hartlieb, a MLDBM user reported this problem in private mail.]

The following hypothetical construct:

   for $k (keys %o) {
       foo([$o{$k}]);
   }

coredumps reliably when %o is a tied hash and the FETCH for the
value $o{$k} is substantial enough to cause a stack reallocation.

Patch against 3_19 attached.

 - Sarathy.
   gsar@engin.umich.edu

P.S: Whatever happened to the stack-of-stacks patch?  Even the first
version of that patch would have eliminated this problem.  There may
be many more places where such a fix may be necessary--it's impossible
to find them all.  Please, let's atleast include a #ifdef-ed version
of that patch!

p5p-msgid: <199701100745.CAA13057@aatma.engin.umich.edu>
---

diff --git a/pp.c b/pp.c
index 7a24843..e4e00ce 100644
--- a/pp.c
+++ b/pp.c
@@ -2110,10 +2110,11 @@ PP(pp_lslice)
 
 PP(pp_anonlist)
 {
-    dSP; dMARK;
+    dSP; dMARK; dORIGMARK;
     I32 items = SP - MARK;
-    SP = MARK;
-    XPUSHs((SV*)sv_2mortal((SV*)av_make(items, MARK+1)));
+    SV *av = sv_2mortal((SV*)av_make(items, MARK+1));
+    SP = ORIGMARK;		/* av_make() might realloc stack_sp */
+    XPUSHs(av);
     RETURN;
 }