From: Ilya Zakharevich <ilya@math.berkeley.edu>
Date: Sun, 3 Aug 2003 06:19:02 +0000 (-0700)
Subject: xsubpp: wrong code
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=d8e11c65f67f4b045739b3272eb9c26a8e2379e0;p=p5sagit%2Fp5-mst-13.2.git

xsubpp: wrong code
Message-ID: <20030803131902.GA5146@math.berkeley.edu>

p4raw-id: //depot/perl@20650
---

diff --git a/lib/ExtUtils/xsubpp b/lib/ExtUtils/xsubpp
index 647ffd7..7ae8020 100755
--- a/lib/ExtUtils/xsubpp
+++ b/lib/ExtUtils/xsubpp
@@ -1453,7 +1453,11 @@ EOF
 	$xsreturn = 1 if $ret_type ne "void";
 	my $num = $xsreturn;
 	my $c = @outlist;
-	print "\tXSprePUSH;" if $c and not $prepush_done;
+	# (PP)CODE set different values of SP; reset to PPCODE's with 0 output
+	print "\tXSprePUSH;"    if $c and not $prepush_done;
+	# Take into account stuff already put on stack
+	print "\t++SP;"         if $c and not $prepush_done and $xsreturn;
+	# Now SP corresponds to ST($xsreturn), so one can combine PUSH and ST()
 	print "\tEXTEND(SP,$c);\n" if $c;
 	$xsreturn += $c;
 	generate_output($var_types{$_}, $num++, $_, 0, 1) for @outlist;