From: Nicholas Clark <nick@ccl4.org>
Date: Mon, 18 Apr 2005 15:23:45 +0000 (+0000)
Subject: Refactor the odd-one-out code before a Renew(SvPVX(...)...)
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=d5b5861bfad2c5081a544610aa6f33c0ea24ea2b;p=p5sagit%2Fp5-mst-13.2.git

Refactor the odd-one-out code before a Renew(SvPVX(...)...)

p4raw-id: //depot/perl@24241
---

diff --git a/pp_hot.c b/pp_hot.c
index 9fa0e07..1a23c90 100644
--- a/pp_hot.c
+++ b/pp_hot.c
@@ -1632,10 +1632,9 @@ Perl_do_readline(pTHX)
 	}
 	else if (gimme == G_SCALAR && !tmplen && SvLEN(sv) - SvCUR(sv) > 80) {
 	    /* try to reclaim a bit of scalar space (only on 1st alloc) */
-	    if (SvCUR(sv) < 60)
-		SvLEN_set(sv, 80);
-	    else
-		SvLEN_set(sv, SvCUR(sv)+40);	/* allow some slop */
+	    const STRLEN new_len
+		= SvCUR(sv) < 60 ? 80 : SvCUR(sv)+40; /* allow some slop */
+	    SvLEN_set(sv, new_len);
 	    Renew(SvPVX(sv), SvLEN(sv), char);
 	}
 	RETURN;