From: Nicholas Clark <nick@ccl4.org>
Date: Fri, 15 Apr 2011 13:22:09 +0000 (+0100)
Subject: Use cmp_ok() when testing > 0, not isnt(..., 0);
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=cf1d079ffe387ffbe4dd412665f8dab9c2170e75;p=p5sagit%2FDevel-Size.git

Use cmp_ok() when testing > 0, not isnt(..., 0);
---

diff --git a/t/basic.t b/t/basic.t
index 5a052af..4dfed68 100644
--- a/t/basic.t
+++ b/t/basic.t
@@ -57,8 +57,8 @@ my($a,$b) = (1,2);
 my @ary1 = (\$a, \$a);
 my @ary2 = (\$a, \$b);
 
-isnt ( total_size(\@ary2) - total_size(\@ary1), 0,
-    'total_size(\@ary1) < total_size(\@ary2)');
+cmp_ok(total_size(\@ary1), '<', total_size(\@ary2),
+       'the tracking hash is working');
 
 #############################################################################
 # check that circular references don't mess things up
@@ -70,21 +70,22 @@ is (total_size($c1), total_size($c2), 'circular references');
 #############################################################################
 # GLOBS
 
-isnt (total_size(*foo), 0, 'total_size(*foo) > 0');
+cmp_ok(total_size(*foo), '>', 0, 'total_size(*foo) > 0');
 
 #############################################################################
 # CODE ref
 
 my $code = sub { '1' };
 
-isnt (total_size($code), 0, 'total_size($code) > 0');
+cmp_ok(total_size($code), '>', 0, 'total_size($code) > 0');
 
 ##########################################################
 # RT#14849 (& RT#26781 and possibly RT#29238?)
-isnt( total_size( sub{ do{ my $t=0 }; } ), 0, 'total_size( sub{ my $t=0 } ) > 0' );
+cmp_ok( total_size( sub{ do{ my $t=0 }; } ), '>', 0,
+	'total_size( sub{ my $t=0 } ) > 0' );
 
 # CPAN RT #58484 and #58485
-isnt (total_size(\&total_size), 0, 'total_size(\&total_size) > 0');
+cmp_ok(total_size(\&total_size), '>', 0, 'total_size(\&total_size) > 0');
 
 use constant LARGE => 'N' x 8192;