From: Gisle Aas Date: Sun, 18 Apr 2010 15:12:24 +0000 (+0200) Subject: Avoid "Use of uninitialized value $base" for the CPANPLUS .hidden file X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=cf14ed9bd246c76a9423a702a266c104120d0ae9;p=p5sagit%2Fp5-mst-13.2.git Avoid "Use of uninitialized value $base" for the CPANPLUS .hidden file --- diff --git a/Porting/check83.pl b/Porting/check83.pl index 56989fa..1bd863f 100644 --- a/Porting/check83.pl +++ b/Porting/check83.pl @@ -20,13 +20,16 @@ my $maxl = 30; # make up a limit for a maximum filename length sub eight_dot_three { return () if $seen{$_[0]}++; - my ($dir, $base, $ext) = ($_[0] =~ m{^(?:(.+)/)?([^/.]+)(?:\.([^/.]+))?$}); + my ($dir, $base, $ext) = ($_[0] =~ m{^(?:(.+)/)?([^/.]*)(?:\.([^/.]+))?$}); my $file = $base . ( defined $ext ? ".$ext" : "" ); $base = substr($base, 0, 8); $ext = substr($ext, 0, 3) if defined $ext; if (defined $dir && $dir =~ /\./) { print "directory name contains '.': $dir\n"; } + if ($base eq "") { + print "filename starts with dot: $_[0]\n"; + } if ($file =~ /[^A-Za-z0-9\._-]/) { print "filename contains non-portable characters: $_[0]\n"; }