From: Will Hawes <wdhawes@gmail.com>
Date: Thu, 23 Mar 2006 18:00:49 +0000 (+0000)
Subject: remove cache tests/docs incorrectly committed to branch
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ce65bba6aa64106758695dce4e1c0ccadad0d4c6;p=dbsrgits%2FDBIx-Class-Historic.git

remove cache tests/docs incorrectly committed to branch
---

diff --git a/lib/DBIx/Class/ResultSet.pm b/lib/DBIx/Class/ResultSet.pm
index 8647918..e03a16d 100644
--- a/lib/DBIx/Class/ResultSet.pm
+++ b/lib/DBIx/Class/ResultSet.pm
@@ -1252,21 +1252,6 @@ A arrayref of columns to group by. Can include columns of joined tables.
 
 Set to 1 to group by all columns.
 
-=head2 cache
-
-Set to 1 to cache search results. This prevents extra SQL queries if you
-revisit rows in your ResultSet:
-
-  my $resultset = $schema->resultset('Artist')->search( undef, { cache => 1 } );
-  
-  while( my $artist = $resultset->next ) {
-    ... do stuff ...
-  }
-
-  $rs->first; # without cache, this would issue a query 
-
-By default, searches are not cached.
-
 For more examples of using these attributes, see
 L<DBIx::Class::Manual::Cookbook>.
 
diff --git a/t/run/23cache.tl b/t/run/23cache.tl
index 4be8fbd..749ce81 100644
--- a/t/run/23cache.tl
+++ b/t/run/23cache.tl
@@ -3,7 +3,7 @@ my $schema = shift;
 
 eval "use DBD::SQLite";
 plan skip_all => 'needs DBD::SQLite for testing' if $@;
-plan tests => 23;
+plan tests => 17;
 
 my $rs = $schema->resultset("Artist")->search(
   { artistid => 1 }
@@ -13,54 +13,6 @@ my $artist = $rs->first;
 
 is( scalar @{ $rs->get_cache }, 0, 'cache is not populated without cache attribute' );
 
-$rs = $schema->resultset('Artist')->search( undef, { cache => 1 } );
-my $artists = [ $rs->all ];
-
-is( scalar @{$rs->get_cache}, 3, 'all() populates cache for search with cache attribute' );
-
-$rs->clear_cache;
-
-is( scalar @{$rs->get_cache}, 0, 'clear_cache is functional' );
-
-$rs->next;
-
-is( scalar @{$rs->get_cache}, 3, 'next() populates cache for search with cache attribute' );
-
-pop( @$artists );
-$rs->set_cache( $artists );
-
-is( scalar @{$rs->get_cache}, 2, 'set_cache() is functional' );
-
-$cd = $schema->resultset('CD')->find(1);
-
-$rs->clear_cache;
-
-eval {
-  $rs->set_cache( [ $cd ] );
-};
-
-is( scalar @{$rs->get_cache}, 0, 'set_cache() only accepts objects of correct type for the resultset' );
-
-unlink 't/var/dbic.trace' if -e 't/var/dbic.trace';
-DBI->trace(1, 't/var/dbic.trace');
-
-$rs = $schema->resultset('Artist')->search( undef, { cache => 1 } );
-while( $artist = $rs->next ) {}
-$artist = $rs->first();
-
-# count the SELECTs
-DBI->trace(0, undef);
-my $selects = 0;
-$trace = IO::File->new('t/var/dbic.trace', '<') 
-    or die "Unable to read trace file";
-while (<$trace>) {
-    $selects++ if /SELECT/;
-}
-$trace->close;
-unlink 't/var/dbic.trace';
-
-is( $selects, 1, 'revisiting a row does not issue a query when cache => 1' );
-
 my @a = $schema->resultset("Artist")->search(
   { },
   {
@@ -105,7 +57,7 @@ is( $artist->count_related('cds'), 3, 'artist->count_related returns correct val
 
 # count the SELECTs
 DBI->trace(0, undef);
-$selects = 0;
+my $selects = 0;
 my $trace = IO::File->new('t/var/dbic.trace', '<') 
     or die "Unable to read trace file";
 while (<$trace>) {