From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Sun, 10 Apr 2005 15:03:10 +0000 (+0000)
Subject: Fix [perl #34892] Segfault on &DB::sub declared but not defined
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ccafdc969fe8361303a07e7576d1af4e3e389a76;p=p5sagit%2Fp5-mst-13.2.git

Fix [perl #34892] Segfault on &DB::sub declared but not defined

p4raw-id: //depot/perl@24215
---

diff --git a/pod/perldiag.pod b/pod/perldiag.pod
index 675ac52..de1d496 100644
--- a/pod/perldiag.pod
+++ b/pod/perldiag.pod
@@ -2428,22 +2428,21 @@ doesn't know where you want to pipe the output from this command.
 =item No DB::DB routine defined
 
 (F) The currently executing code was compiled with the B<-d> switch, but
-for some reason the perl5db.pl file (or some facsimile thereof) didn't
-define a routine to be called at the beginning of each statement.  Which
-is odd, because the file should have been required automatically, and
-should have blown up the require if it didn't parse right.
+for some reason the  current debugger (e.g. F<perl5db.pl> or a C<Devel::>
+module) didn't define a routine to be called at the beginning of each
+statement.
 
 =item No dbm on this machine
 
 (P) This is counted as an internal error, because every machine should
 supply dbm nowadays, because Perl comes with SDBM.  See L<SDBM_File>.
 
-=item No DBsub routine
+=item No DB::sub routine defined
 
-(F) The currently executing code was compiled with the B<-d> switch,
-but for some reason the perl5db.pl file (or some facsimile thereof)
-didn't define a DB::sub routine to be called at the beginning of each
-ordinary subroutine call.
+(F) The currently executing code was compiled with the B<-d> switch, but
+for some reason the current debugger (e.g. F<perl5db.pl> or a C<Devel::>
+module) didn't define a C<DB::sub> routine to be called at the beginning
+of each ordinary subroutine call.
 
 =item No B<-e> allowed in setuid scripts
 
diff --git a/pp_hot.c b/pp_hot.c
index dcacf63..85b42aa 100644
--- a/pp_hot.c
+++ b/pp_hot.c
@@ -2672,8 +2672,8 @@ PP(pp_entersub)
 	    sv_setiv(PL_DBassertion, 1);
 	
 	cv = get_db_sub(&sv, cv);
-	if (!cv)
-	    DIE(aTHX_ "No DBsub routine");
+	if (!cv || (!CvXSUB(cv) && !CvSTART(cv)))
+	    DIE(aTHX_ "No DB::sub routine defined");
     }
 
     if (!(CvXSUB(cv))) {