From: Johannes Plunien <plu@cpan.org>
Date: Mon, 24 Nov 2008 15:08:18 +0000 (+0000)
Subject: Skip tests for buggy Spreadsheet::ParseExcel versions (rbo)
X-Git-Tag: v0.11008~276
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=cc48d354e4950e6ce3f32e6cac6623d64047383d;p=dbsrgits%2FSQL-Translator.git

Skip tests for buggy Spreadsheet::ParseExcel versions (rbo)
---

diff --git a/Build.PL b/Build.PL
index c3f85d6..bc1ef2c 100644
--- a/Build.PL
+++ b/Build.PL
@@ -39,7 +39,7 @@ my $builder = Module::Build->new(
         'Graph::Directed'         => 0,
         'IO::File'                => 0,
         'IO::Scalar'              => 0,
-        'Spreadsheet::ParseExcel' => 0.2602,
+        'Spreadsheet::ParseExcel' => '>= 0.2602, != 0.33',
         'Text::ParseWords'        => 0,
         'Text::RecordParser'      => 0.02,
         'XML::Writer'             => 0.500,
diff --git a/Changes b/Changes
index 246ca30..500f081 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,7 @@
 # ----------------------------------------------------------
 # 
 # ----------------------------------------------------------
+* Skip tests for buggy Spreadsheet::ParseExcel versions (rbo)
 * Add support for skip tables parser arg in Parser::DBI::MySQL (jgoulah)
 * Changed behaviour of ::Producer::Oracle when returning an array of statements to make it compatible to DBI->do()
 * Fixed a few bugs in ::Producer::Oracle
diff --git a/t/10excel.t b/t/10excel.t
index 4321af4..2074792 100644
--- a/t/10excel.t
+++ b/t/10excel.t
@@ -46,7 +46,7 @@ my $f4 = shift @fields;
 TODO: {
     eval { require Spreadsheet::ParseExcel };
        todo_skip "Bug in Spreadsheet::ParseExcel, http://rt.cpan.org/Public/Bug/Display.html?id=39892", 4 
-               if ($Spreadsheet::ParseExcel::VERSION > 0.32);
+               if ( $Spreadsheet::ParseExcel::VERSION > 0.32 and $Spreadsheet::ParseExcel::VERSION < 0.41 );
 
        is( $f4->name, 'math', 'Fourth field name is "math"' );
        is( lc $f4->data_type, 'float', 'Data type is "float"' );