From: Nigel Metheringham <nigelm@cpan.org>
Date: Tue, 8 Aug 2006 12:05:39 +0000 (+0000)
Subject: Test for search_rs destructive effects on attributes - see fix in [2674]
X-Git-Tag: v0.07002~47
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=cb3e35d2740817d0c5b8b52b77753f03c850708d;hp=888a0746debd73e3aa2bbff0592b8046b7161b94;p=dbsrgits%2FDBIx-Class.git

Test for search_rs destructive effects on attributes - see fix in [2674]
---

diff --git a/Changes b/Changes
index 5f687a3..4f1924b 100644
--- a/Changes
+++ b/Changes
@@ -11,6 +11,7 @@ Revision history for DBIx::Class
           https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196836
         - fix a pathological prefetch case
         - table case fix for Oracle in columns_info_for
+        - stopped search_rs deleting attributes from passed hash
 
 0.07000 2006-07-23 02:30:00
         - supress warnings for possibly non-unique queries, since
diff --git a/t/76joins.t b/t/76joins.t
index dff7046..1033b53 100644
--- a/t/76joins.t
+++ b/t/76joins.t
@@ -4,6 +4,7 @@ use warnings;
 use Test::More;
 use lib qw(t/lib);
 use DBICTest;
+use Data::Dumper;
 
 my $schema = DBICTest->init_schema();
 
@@ -15,7 +16,7 @@ BEGIN {
     eval "use DBD::SQLite";
     plan $@
         ? ( skip_all => 'needs DBD::SQLite for testing' )
-        : ( tests => 47 );
+        : ( tests => 49 );
 }
 
 # figure out if we've got a version of sqlite that is older than 3.2.6, in
@@ -133,11 +134,18 @@ cmp_ok( $rs->count, '==', 1, "Single record in resultset");
 
 is($rs->first->name, 'We Are Goth', 'Correct record returned');
 
-$rs = $schema->resultset("CD")->search(
-           { 'artist.name' => 'Caterwauler McCrae' },
-           { prefetch => [ qw/artist liner_notes/ ],
-             order_by => 'me.cdid' });
+# bug in 0.07000 caused attr (join/prefetch) to be modifed by search
+# so we check the search & attr arrays are not modified
+my $search = { 'artist.name' => 'Caterwauler McCrae' };
+my $attr = { prefetch => [ qw/artist liner_notes/ ],
+             order_by => 'me.cdid' };
+my $search_str = Dumper($search);
+my $attr_str = Dumper($attr);
+
+$rs = $schema->resultset("CD")->search($search, $attr);
 
+is(Dumper($search), $search_str, 'Search hash untouched after search()');
+is(Dumper($attr), $attr_str, 'Attribute hash untouched after search()');
 cmp_ok($rs + 0, '==', 3, 'Correct number of records returned');
 
 my $queries = 0;