From: Nicholas Clark <nick@ccl4.org>
Date: Thu, 17 Apr 2008 13:36:21 +0000 (+0000)
Subject: Remove a dead case from the error reporting in
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c9bf4021f2ca0ea941eae398f2988ab7096694c9;p=p5sagit%2Fp5-mst-13.2.git

Remove a dead case from the error reporting in
Perl_gv_fetchmethod_flags()

p4raw-id: //depot/perl@33707
---

diff --git a/gv.c b/gv.c
index 0b17aec..20eb17e 100644
--- a/gv.c
+++ b/gv.c
@@ -624,6 +624,11 @@ Perl_gv_fetchmethod_flags(pTHX_ HV *stash, const char *name, U32 flags)
 
     if (SvTYPE(stash) < SVt_PVHV)
 	stash = NULL;
+    else {
+	/* The only way stash can become NULL later on is if nsplit is set,
+	   which in turn means that there is no need for a SVt_PVHV case
+	   the error reporting code.  */
+    }
 
     for (nend = name; *nend; nend++) {
 	if (*nend == '\'') {
@@ -677,14 +682,9 @@ Perl_gv_fetchmethod_flags(pTHX_ HV *stash, const char *name, U32 flags)
 		STRLEN packlen;
 		const char *packname;
 
-		assert(error_report);
-
 		if (nsplit) {
 		    packlen = nsplit - origname;
 		    packname = origname;
-		} else if (SvTYPE(error_report) == SVt_PVHV) {
-		    packlen = HvNAMELEN_get(error_report);
-		    packname = HvNAME_get(error_report);
 		} else {
 		    packname = SvPV_const(error_report, packlen);
 		}