From: Michael G. Schwern <schwern@pobox.com>
Date: Sat, 11 Dec 2004 18:58:32 +0000 (-0500)
Subject: FileCache without import
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c9463f45fe9c03847ac7230d0248f3c25eb914e6;p=p5sagit%2Fp5-mst-13.2.git

FileCache without import
Message-ID: <20041211235832.GA13462@windhund.schwern.org>

p4raw-id: //depot/perl@23643
---

diff --git a/MANIFEST b/MANIFEST
index 51e601e..94e9203 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -1346,6 +1346,7 @@ lib/FileCache/t/03append.t	See if FileCache works
 lib/FileCache/t/04twoarg.t	See if FileCache works
 lib/FileCache/t/05override.t	See if FileCache works
 lib/FileCache/t/06export.t	See if FileCache exporting works
+lib/FileCache/t/07noimport.t	See if FileCache works without importing
 lib/File/CheckTree.pm		Perl module supporting wholesale file mode validation
 lib/File/CheckTree.t		See if File::CheckTree works
 lib/File/Compare.pm		Emulation of cmp command
diff --git a/lib/FileCache.pm b/lib/FileCache.pm
index a64ed9a..6157f57 100644
--- a/lib/FileCache.pm
+++ b/lib/FileCache.pm
@@ -81,33 +81,35 @@ use Carp;
 use Config;
 use strict;
 no strict 'refs';
+
 # These are not C<my> for legacy reasons.
 # Previous versions requested the user set $cacheout_maxopen by hand.
 # Some authors fiddled with %saw to overcome the clobber on initial open.
-use vars qw(%saw $cacheout_maxopen @EXPORT);
+use vars qw(%saw $cacheout_maxopen);
+$cacheout_maxopen = 16;
+
+use base 'Exporter';
+our @EXPORT = qw[cacheout cacheout_close];
+
+
 my %isopen;
 my $cacheout_seq = 0;
 
 sub import {
     my ($pkg,%args) = @_;
 
-    # Not using Exporter is naughty.
-    # Also, using caller(1) is just wrong.
-    #$pkg = caller(1);
-    #*{$pkg.'::cacheout'} = \&cacheout;
-    #*{$pkg.'::close'}    = \&cacheout_close;
-
     # Use Exporter. %args are for us, not Exporter.
     # Make sure to up export_to_level, or we will import into ourselves,
     # rather than our calling package;
-    use base 'Exporter';
-    @EXPORT = qw[cacheout cacheout_close];
 
     __PACKAGE__->export_to_level(1);
     Exporter::import( $pkg );
 
     # Truth is okay here because setting maxopen to 0 would be bad
     return $cacheout_maxopen = $args{maxopen} if $args{maxopen};
+
+    # XXX This code is crazy.  Why is it a one element foreach loop?
+    # Why is it using $param both as a filename and filehandle?
     foreach my $param ( '/usr/include/sys/param.h' ){
       if (open($param, '<', $param)) {
 	local ($_, $.);
@@ -153,7 +155,7 @@ sub cacheout {
     if( $isopen{$file} && ($mode||'>') ne $isopen{$file}->[1] ){
       &cacheout_close($file, 1);
     }
-    
+
     if( $isopen{$file}) {
       $ret = $file;
       $isopen{$file}->[0]++;
@@ -172,7 +174,7 @@ sub cacheout {
       }
       #XXX should we just return the value from cacheout_open, no croak?
       $ret = cacheout_open($mode, $file) or croak("Can't create $file: $!");
-      
+
       $isopen{$file} = [++$cacheout_seq, $mode];
     }
     return $ret;
diff --git a/lib/FileCache/t/07noimport.t b/lib/FileCache/t/07noimport.t
new file mode 100644
index 0000000..0f19ada
--- /dev/null
+++ b/lib/FileCache/t/07noimport.t
@@ -0,0 +1,25 @@
+#!./perl -w
+
+BEGIN {
+    chdir 't';
+    @INC = '../lib';
+}
+
+require './test.pl';
+plan( tests => 1 );
+
+# Try using FileCache without importing to make sure everything's 
+# initialized without it.
+{
+    package Y;
+    use FileCache ();
+
+    my $file = 'foo';
+    END { unlink $file }
+    FileCache::cacheout($file);
+    print $file "bar";
+    close $file;
+
+    FileCache::cacheout("<", $file);
+    ::ok( <$file> eq "bar" );
+}