From: Shawn M Moore <sartak@gmail.com>
Date: Wed, 3 Dec 2008 03:51:14 +0000 (+0000)
Subject: Assign the value of the parameter to a lexical so we don't have to continually look... 
X-Git-Tag: 0.19~136^2~71
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c91862e86b5fb86424cef0d43d0731aaf9662e8e;p=gitmo%2FMouse.git

Assign the value of the parameter to a lexical so we don't have to continually look it up in the args hash
---

diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm
index 433fc46..13c4ad0 100644
--- a/lib/Mouse/Meta/Method/Constructor.pm
+++ b/lib/Mouse/Meta/Method/Constructor.pm
@@ -36,23 +36,33 @@ sub _generate_processattrs {
         my $attr = $attrs->[$index];
         my $from = $attr->init_arg;
         my $key  = $attr->name;
+
         my $part1 = do {
             my @code;
+
+            push @code, "my \$value = \$args->{'$from'};";
+
             if ($attr->should_coerce) {
-                push @code, "\$args->{'$from'} = \$attr->coerce_constraint( \$args->{'$from'} );";
+                push @code, "\$value = \$attr->coerce_constraint( \$value );";
             }
+
             if ($attr->has_type_constraint) {
-                push @code, "\$attr->verify_type_constraint( \$args->{'$from'} );";
+                push @code, "\$attr->verify_type_constraint( \$value );";
             }
-            push @code, "\$instance->{'$key'} = \$args->{'$from'};";
+
+            push @code, "\$instance->{'$key'} = \$value;";
+
             if ($attr->is_weak_ref) {
-                push @code, "weaken( \$instance->{'$key'} ) if ref( \$instance->{'$key'} );";
+                push @code, "weaken( \$instance->{'$key'} ) if ref( \$value );";
             }
+
             if ( $attr->has_trigger ) {
-                push @code, "\$attr->trigger->( \$instance, \$args->{'$from'}, \$attr );";
+                push @code, "\$attr->trigger->( \$instance, \$value, \$attr );";
             }
+
             join "\n", @code;
         };
+
         my $part2 = do {
             my @code;
             if ( $attr->has_default || $attr->has_builder ) {