From: Nicholas Clark Date: Thu, 4 Jun 2009 13:06:58 +0000 (+0100) Subject: Assuming that $SIG{PIPE} is not set can be bogus when running in a cron job. X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c8be058c40ba584eaa1b32e8b2fe754f679df51d;p=p5sagit%2Fp5-mst-13.2.git Assuming that $SIG{PIPE} is not set can be bogus when running in a cron job. Use $SIG{KILL} instead, as no-one sane would set an untrappable signal. This should address failures some smokers are reporting. --- diff --git a/t/op/magic.t b/t/op/magic.t index fd2307b..95459bc 100755 --- a/t/op/magic.t +++ b/t/op/magic.t @@ -495,7 +495,7 @@ is $SIG{HUNGRY}, undef, "HUNGRY is now gone"; is delete $SIG{HUNGRY}, undef, "HUNGRY remains gone"; # Test deleting signals that we never set -foreach my $sig (qw(__DIE__ _BOGUS_HOOK PIPE THIRSTY)) { +foreach my $sig (qw(__DIE__ _BOGUS_HOOK KILL THIRSTY)) { is $SIG{$sig}, undef, "$sig is not present"; is delete $SIG{$sig}, undef, "delete of $sig returns undef"; }