From: Jesse Luehrs Date: Tue, 29 Nov 2011 20:51:39 +0000 (-0600) Subject: sync test suite X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c803b9210927bdf4a385070d386904a28e5f8540;p=gitmo%2FPackage-Stash-XS.git sync test suite --- diff --git a/t/anon-basic.t b/t/anon-basic.t new file mode 100644 index 0000000..fc26f12 --- /dev/null +++ b/t/anon-basic.t @@ -0,0 +1,387 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use lib 't/lib'; +use Test::More; +use Test::Fatal; + +use Test::Requires 'Package::Anon'; +use Package::Stash; +use Symbol; + +plan skip_all => "Anonymous stashes in PP need at least perl 5.14" + if $] < 5.014 + && $Package::Stash::IMPLEMENTATION eq 'PP'; + +my $Foo = Package::Anon->new('Foo'); +$Foo->{SOME_CONSTANT} = \1; + +# ---------------------------------------------------------------------- +## tests adding a HASH + +my $foo_stash = Package::Stash->new($Foo); +ok(!defined($Foo->{foo}), '... the %foo slot has not been created yet'); +ok(!$foo_stash->has_symbol('%foo'), '... the object agrees'); +ok(!defined($Foo->{foo}), '... checking doesn\'t vivify'); + +is(exception { + $foo_stash->add_symbol('%foo' => { one => 1 }); +}, undef, '... created %Foo::foo successfully'); + +# ... scalar should NOT be created here + +ok(!$foo_stash->has_symbol('$foo'), '... SCALAR shouldnt have been created too'); +ok(!$foo_stash->has_symbol('@foo'), '... ARRAY shouldnt have been created too'); +ok(!$foo_stash->has_symbol('&foo'), '... CODE shouldnt have been created too'); + +ok(defined($Foo->{foo}), '... the %foo slot was created successfully'); +ok($foo_stash->has_symbol('%foo'), '... the meta agrees'); + +# check the value ... + +ok(exists $Foo->{foo}{one}, '... our %foo was initialized correctly'); +is($Foo->{foo}{one}, 1, '... our %foo was initialized correctly'); + +my $foo = $foo_stash->get_symbol('%foo'); +is_deeply({ one => 1 }, $foo, '... got the right package variable back'); + +# ... make sure changes propogate up + +$foo->{two} = 2; + +is(\%{ $Foo->{foo} }, $foo_stash->get_symbol('%foo'), '... our %foo is the same as the metas'); + +ok(exists ${ $Foo->{foo} }{two}, '... our %foo was updated correctly'); +is(${ $Foo->{foo} }{two}, 2, '... our %foo was updated correctly'); + +# ---------------------------------------------------------------------- +## test adding an ARRAY + +ok(!defined($Foo->{bar}), '... the @bar slot has not been created yet'); + +is(exception { + $foo_stash->add_symbol('@bar' => [ 1, 2, 3 ]); +}, undef, '... created @Foo::bar successfully'); + +ok(defined($Foo->{bar}), '... the @bar slot was created successfully'); +ok($foo_stash->has_symbol('@bar'), '... the meta agrees'); + +# ... why does this not work ... + +ok(!$foo_stash->has_symbol('$bar'), '... SCALAR shouldnt have been created too'); +ok(!$foo_stash->has_symbol('%bar'), '... HASH shouldnt have been created too'); +ok(!$foo_stash->has_symbol('&bar'), '... CODE shouldnt have been created too'); + +# check the value itself + +is(scalar @{ $Foo->{bar} }, 3, '... our @bar was initialized correctly'); +is($Foo->{bar}[1], 2, '... our @bar was initialized correctly'); + +# ---------------------------------------------------------------------- +## test adding a SCALAR + +ok(!defined($Foo->{baz}), '... the $baz slot has not been created yet'); + +is(exception { + $foo_stash->add_symbol('$baz' => 10); +}, undef, '... created $Foo::baz successfully'); + +ok(defined($Foo->{baz}), '... the $baz slot was created successfully'); +ok($foo_stash->has_symbol('$baz'), '... the meta agrees'); + +ok(!$foo_stash->has_symbol('@baz'), '... ARRAY shouldnt have been created too'); +ok(!$foo_stash->has_symbol('%baz'), '... HASH shouldnt have been created too'); +ok(!$foo_stash->has_symbol('&baz'), '... CODE shouldnt have been created too'); + +is(${$foo_stash->get_symbol('$baz')}, 10, '... got the right value back'); + +${ $Foo->{baz} } = 1; + +is(${ $Foo->{baz} }, 1, '... our $baz was assigned to correctly'); +is(${$foo_stash->get_symbol('$baz')}, 1, '... the meta agrees'); + +# ---------------------------------------------------------------------- +## test adding a CODE + +ok(!defined($Foo->{funk}), '... the &funk slot has not been created yet'); + +is(exception { + $foo_stash->add_symbol('&funk' => sub { "Foo::funk" }); +}, undef, '... created &Foo::funk successfully'); + +ok(defined($Foo->{funk}), '... the &funk slot was created successfully'); +ok($foo_stash->has_symbol('&funk'), '... the meta agrees'); + +ok(!$foo_stash->has_symbol('$funk'), '... SCALAR shouldnt have been created too'); +ok(!$foo_stash->has_symbol('@funk'), '... ARRAY shouldnt have been created too'); +ok(!$foo_stash->has_symbol('%funk'), '... HASH shouldnt have been created too'); + +ok(defined &{ $Foo->{funk} }, '... our &funk exists'); + +is($Foo->bless({})->funk(), 'Foo::funk', '... got the right value from the function'); + +# ---------------------------------------------------------------------- +## test multiple slots in the glob + +my $ARRAY = [ 1, 2, 3 ]; +my $CODE = sub { "Foo::foo" }; + +is(exception { + $foo_stash->add_symbol('@foo' => $ARRAY); +}, undef, '... created @Foo::foo successfully'); + +ok($foo_stash->has_symbol('@foo'), '... the @foo slot was added successfully'); +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); + +is(exception { + $foo_stash->add_symbol('&foo' => $CODE); +}, undef, '... created &Foo::foo successfully'); + +ok($foo_stash->has_symbol('&foo'), '... the meta agrees'); +is($foo_stash->get_symbol('&foo'), $CODE, '... got the right value for &Foo::foo'); + +is(exception { + $foo_stash->add_symbol('$foo' => 'Foo::foo'); +}, undef, '... created $Foo::foo successfully'); + +ok($foo_stash->has_symbol('$foo'), '... the meta agrees'); +my $SCALAR = $foo_stash->get_symbol('$foo'); +is($$SCALAR, 'Foo::foo', '... got the right scalar value back'); + +is(${ $Foo->{foo} }, 'Foo::foo', '... got the right value from the scalar'); + +is(exception { + $foo_stash->remove_symbol('%foo'); +}, undef, '... removed %Foo::foo successfully'); + +ok(!$foo_stash->has_symbol('%foo'), '... the %foo slot was removed successfully'); +ok($foo_stash->has_symbol('@foo'), '... the @foo slot still exists'); +ok($foo_stash->has_symbol('&foo'), '... the &foo slot still exists'); +ok($foo_stash->has_symbol('$foo'), '... the $foo slot still exists'); + +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); +is($foo_stash->get_symbol('&foo'), $CODE, '... got the right value for &Foo::foo'); +is($foo_stash->get_symbol('$foo'), $SCALAR, '... got the right value for $Foo::foo'); + +ok(!defined(*{ $Foo->{foo} }{HASH}), '... the %foo slot has been removed successfully'); +ok(defined(*{ $Foo->{foo} }{ARRAY}), '... the @foo slot has NOT been removed'); +ok(defined(*{ $Foo->{foo} }{CODE}), '... the &foo slot has NOT been removed'); +ok(defined(${ $Foo->{foo} }), '... the $foo slot has NOT been removed'); + +is(exception { + $foo_stash->remove_symbol('&foo'); +}, undef, '... removed &Foo::foo successfully'); + +ok(!$foo_stash->has_symbol('&foo'), '... the &foo slot no longer exists'); + +ok($foo_stash->has_symbol('@foo'), '... the @foo slot still exists'); +ok($foo_stash->has_symbol('$foo'), '... the $foo slot still exists'); + +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); +is($foo_stash->get_symbol('$foo'), $SCALAR, '... got the right value for $Foo::foo'); + +ok(!defined(*{ $Foo->{foo} }{HASH}), '... the %foo slot has been removed successfully'); +ok(!defined(*{ $Foo->{foo} }{CODE}), '... the &foo slot has now been removed'); +ok(defined(*{ $Foo->{foo} }{ARRAY}), '... the @foo slot has NOT been removed'); +ok(defined(${ $Foo->{foo} }), '... the $foo slot has NOT been removed'); + +is(exception { + $foo_stash->remove_symbol('$foo'); +}, undef, '... removed $Foo::foo successfully'); + +ok(!$foo_stash->has_symbol('$foo'), '... the $foo slot no longer exists'); + +ok($foo_stash->has_symbol('@foo'), '... the @foo slot still exists'); + +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); + +ok(!defined(*{ $Foo->{foo} }{HASH}), '... the %foo slot has been removed successfully'); +ok(!defined(*{ $Foo->{foo} }{CODE}), '... the &foo slot has now been removed'); +ok(!defined(${ $Foo->{foo} }), '... the $foo slot has now been removed'); +ok(defined(*{ $Foo->{foo} }{ARRAY}), '... the @foo slot has NOT been removed'); + +{ + my $syms = $foo_stash->get_all_symbols; + is_deeply( + [ sort keys %{ $syms } ], + [ sort $foo_stash->list_all_symbols ], + '... the fetched symbols are the same as the listed ones' + ); +} + +{ + my $syms = $foo_stash->get_all_symbols('CODE'); + + is_deeply( + [ sort keys %{ $syms } ], + [ sort $foo_stash->list_all_symbols('CODE') ], + '... the fetched symbols are the same as the listed ones' + ); + + foreach my $symbol (keys %{ $syms }) { + is($syms->{$symbol}, $foo_stash->get_symbol('&' . $symbol), '... got the right symbol'); + } +} + +{ + $foo_stash->add_symbol('%bare'); + ok(!$foo_stash->has_symbol('$bare'), + "add_symbol with single argument doesn't vivify scalar slot"); +} + +{ + $foo_stash->add_symbol('%zork', {}); + + my $syms = $foo_stash->get_all_symbols('HASH'); + + is_deeply( + [ sort keys %{ $syms } ], + [ sort $foo_stash->list_all_symbols('HASH') ], + '... the fetched symbols are the same as the listed ones' + ); + + foreach my $symbol (keys %{ $syms }) { + is($syms->{$symbol}, $foo_stash->get_symbol('%' . $symbol), '... got the right symbol'); + } + + is_deeply( + $syms, + { zork => *{ $Foo->{zork} }{HASH} }, + "got the right ones", + ); +} + +# check some errors + +like(exception { + $foo_stash->add_symbol('@bar', {}) +}, qr/HASH.*is not of type ARRAY/, "can't initialize a slot with the wrong type of value"); + +like(exception { + $foo_stash->add_symbol('bar', []) +}, qr/ARRAY.*is not of type IO/, "can't initialize a slot with the wrong type of value"); + +like(exception { + $foo_stash->add_symbol('$bar', sub { }) +}, qr/CODE.*is not of type SCALAR/, "can't initialize a slot with the wrong type of value"); + +like(exception { + $foo_stash->add_symbol('$bar', *{ Symbol::geniosym() }{IO}) +}, qr/IO.*is not of type SCALAR/, "can't initialize a slot with the wrong type of value"); + +is_deeply([Package::Stash->new('Foo')->list_all_symbols], [], + "Foo:: isn't touched"); + +my $Quux = Package::Anon->new('Quux'); +$Quux->{foo} = *{ Symbol::gensym() }; +*{ $Quux->{foo} } = \23; +*{ $Quux->{foo} } = ["bar"]; +*{ $Quux->{foo} } = { baz => 1 }; +*{ $Quux->{foo} } = sub { }; +*{ $Quux->{foo} } = *{ Symbol::geniosym() }{IO}; + +{ + my $stash = Package::Stash->new($Quux); + + my %expect = ( + '$foo' => \23, + '@foo' => ["bar"], + '%foo' => { baz => 1 }, + '&foo' => \&{ $Quux->{foo} }, + 'foo' => *{ $Quux->{foo} }{IO}, + ); + + for my $sym ( sort keys %expect ) { + is_deeply( + $stash->get_symbol($sym), + $expect{$sym}, + "got expected value for $sym" + ); + } + + $stash->add_symbol('%bar' => {x => 42}); + + $expect{'%bar'} = {x => 42}; + + for my $sym ( sort keys %expect ) { + is_deeply( + $stash->get_symbol($sym), + $expect{$sym}, + "got expected value for $sym" + ); + } + + $stash->add_symbol('%bar' => {x => 43}); + + $expect{'%bar'} = {x => 43}; + + for my $sym ( sort keys %expect ) { + is_deeply( + $stash->get_symbol($sym), + $expect{$sym}, + "got expected value for $sym" + ); + } +} + +is_deeply([Package::Stash->new('Quux')->list_all_symbols], [], + "Quux:: isn't touched"); + +my $Quuux = Package::Anon->new('Quuux'); + +$Quuux->{foo} = *{ Symbol::gensym() }; +*{ $Quuux->{foo} } = \(my $scalar); +*{ $Quuux->{foo} } = []; + +$Quuux->{bar} = *{ Symbol::gensym() }; +*{ $Quuux->{bar} } = []; + +$Quuux->{baz} = *{ Symbol::gensym() }; +*{ $Quuux->{baz} } = {}; +*{ $Quuux->{baz} } = sub { }; + +$Quuux->{quux} = \1; + +$Quuux->{quuux} = \[]; + +$Quuux->{quuuux} = -1; + +{ + my $quuux = Package::Stash->new($Quuux); + is_deeply( + # Package::Anon adds a couple methods + [grep { $_ ne 'isa' && $_ ne 'can' } sort $quuux->list_all_symbols], + [qw(bar baz foo quuuux quuux quux)], + "list_all_symbols", + ); + { local $TODO = $] < 5.010 + ? "undef scalars aren't visible on 5.8" + : undef; + is_deeply( + [sort $quuux->list_all_symbols('SCALAR')], + [qw(foo)], + "list_all_symbols SCALAR", + ); + } + is_deeply( + [sort $quuux->list_all_symbols('ARRAY')], + [qw(bar foo)], + "list_all_symbols ARRAY", + ); + is_deeply( + [sort $quuux->list_all_symbols('HASH')], + [qw(baz)], + "list_all_symbols HASH", + ); + is_deeply( + # Package::Anon adds a couple methods + [grep { $_ ne 'isa' && $_ ne 'can' } sort $quuux->list_all_symbols('CODE')], + [qw(baz quuuux quuux quux)], + "list_all_symbols CODE", + ); +} + +is_deeply([Package::Stash->new('Quuux')->list_all_symbols], [], + "Quuux:: isn't touched"); + +done_testing; diff --git a/t/anon.t b/t/anon.t new file mode 100644 index 0000000..8b7f7aa --- /dev/null +++ b/t/anon.t @@ -0,0 +1,49 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use Test::More; +use Test::Fatal; +use lib 't/lib'; + +use Test::Requires 'Package::Anon'; + +use Package::Stash; +use Symbol; + +plan skip_all => "Anonymous stashes in PP need at least perl 5.14" + if $] < 5.014 + && $Package::Stash::IMPLEMENTATION eq 'PP'; + +my $anon = Package::Anon->new; +my $stash = Package::Stash->new($anon); +my $obj = $anon->bless({}); + +{ + my $code = sub { 'FOO' }; + $stash->add_symbol('&foo' => $code); + is($stash->get_symbol('&foo'), $code); + is($obj->foo, 'FOO'); +} + +{ + $anon->{bar} = \123; + + my $code = $stash->get_symbol('&bar'); + is(ref($code), 'CODE'); + is($code->(), 123); + + is($obj->bar, 123); +} + +{ + $anon->{baz} = -1; + + my $code = $stash->get_symbol('&baz'); + is(ref($code), 'CODE'); + like( + exception { $code->() }, + qr/Undefined subroutine \&__ANON__::baz called/ + ); +} + +done_testing; diff --git a/t/bare-anon-basic.t b/t/bare-anon-basic.t new file mode 100644 index 0000000..9cea31e --- /dev/null +++ b/t/bare-anon-basic.t @@ -0,0 +1,394 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use lib 't/lib'; +use Test::More; +use Test::Fatal; + +use Package::Stash; +use Symbol; + +plan skip_all => "Anonymous stashes in PP need at least perl 5.14" + if $] < 5.014 + && $Package::Stash::IMPLEMENTATION eq 'PP'; + +my $Foo = {}; +$Foo->{SOME_CONSTANT} = \1; + +# ---------------------------------------------------------------------- +## tests adding a HASH + +my $foo_stash = Package::Stash->new($Foo); +ok(!defined($Foo->{foo}), '... the %foo slot has not been created yet'); +ok(!$foo_stash->has_symbol('%foo'), '... the object agrees'); +ok(!defined($Foo->{foo}), '... checking doesn\'t vivify'); + +is(exception { + $foo_stash->add_symbol('%foo' => { one => 1 }); +}, undef, '... created %Foo::foo successfully'); + +# ... scalar should NOT be created here + +ok(!$foo_stash->has_symbol('$foo'), '... SCALAR shouldnt have been created too'); +ok(!$foo_stash->has_symbol('@foo'), '... ARRAY shouldnt have been created too'); +ok(!$foo_stash->has_symbol('&foo'), '... CODE shouldnt have been created too'); + +ok(defined($Foo->{foo}), '... the %foo slot was created successfully'); +ok($foo_stash->has_symbol('%foo'), '... the meta agrees'); + +# check the value ... + +ok(exists $Foo->{foo}{one}, '... our %foo was initialized correctly'); +is($Foo->{foo}{one}, 1, '... our %foo was initialized correctly'); + +my $foo = $foo_stash->get_symbol('%foo'); +is_deeply({ one => 1 }, $foo, '... got the right package variable back'); + +# ... make sure changes propogate up + +$foo->{two} = 2; + +is(\%{ $Foo->{foo} }, $foo_stash->get_symbol('%foo'), '... our %foo is the same as the metas'); + +ok(exists ${ $Foo->{foo} }{two}, '... our %foo was updated correctly'); +is(${ $Foo->{foo} }{two}, 2, '... our %foo was updated correctly'); + +# ---------------------------------------------------------------------- +## test adding an ARRAY + +ok(!defined($Foo->{bar}), '... the @bar slot has not been created yet'); + +is(exception { + $foo_stash->add_symbol('@bar' => [ 1, 2, 3 ]); +}, undef, '... created @Foo::bar successfully'); + +ok(defined($Foo->{bar}), '... the @bar slot was created successfully'); +ok($foo_stash->has_symbol('@bar'), '... the meta agrees'); + +# ... why does this not work ... + +ok(!$foo_stash->has_symbol('$bar'), '... SCALAR shouldnt have been created too'); +ok(!$foo_stash->has_symbol('%bar'), '... HASH shouldnt have been created too'); +ok(!$foo_stash->has_symbol('&bar'), '... CODE shouldnt have been created too'); + +# check the value itself + +is(scalar @{ $Foo->{bar} }, 3, '... our @bar was initialized correctly'); +is($Foo->{bar}[1], 2, '... our @bar was initialized correctly'); + +# ---------------------------------------------------------------------- +## test adding a SCALAR + +ok(!defined($Foo->{baz}), '... the $baz slot has not been created yet'); + +is(exception { + $foo_stash->add_symbol('$baz' => 10); +}, undef, '... created $Foo::baz successfully'); + +ok(defined($Foo->{baz}), '... the $baz slot was created successfully'); +ok($foo_stash->has_symbol('$baz'), '... the meta agrees'); + +ok(!$foo_stash->has_symbol('@baz'), '... ARRAY shouldnt have been created too'); +ok(!$foo_stash->has_symbol('%baz'), '... HASH shouldnt have been created too'); +ok(!$foo_stash->has_symbol('&baz'), '... CODE shouldnt have been created too'); + +is(${$foo_stash->get_symbol('$baz')}, 10, '... got the right value back'); + +${ $Foo->{baz} } = 1; + +is(${ $Foo->{baz} }, 1, '... our $baz was assigned to correctly'); +is(${$foo_stash->get_symbol('$baz')}, 1, '... the meta agrees'); + +# ---------------------------------------------------------------------- +## test adding a CODE + +ok(!defined($Foo->{funk}), '... the &funk slot has not been created yet'); + +is(exception { + $foo_stash->add_symbol('&funk' => sub { "Foo::funk" }); +}, undef, '... created &Foo::funk successfully'); + +ok(defined($Foo->{funk}), '... the &funk slot was created successfully'); +ok($foo_stash->has_symbol('&funk'), '... the meta agrees'); + +ok(!$foo_stash->has_symbol('$funk'), '... SCALAR shouldnt have been created too'); +ok(!$foo_stash->has_symbol('@funk'), '... ARRAY shouldnt have been created too'); +ok(!$foo_stash->has_symbol('%funk'), '... HASH shouldnt have been created too'); + +ok(defined &{ $Foo->{funk} }, '... our &funk exists'); + +# can't bless things into hashrefs yet +# is($Foo->bless({})->funk(), 'Foo::funk', '... got the right value from the function'); + +# ---------------------------------------------------------------------- +## test multiple slots in the glob + +my $ARRAY = [ 1, 2, 3 ]; +my $CODE = sub { "Foo::foo" }; + +is(exception { + $foo_stash->add_symbol('@foo' => $ARRAY); +}, undef, '... created @Foo::foo successfully'); + +ok($foo_stash->has_symbol('@foo'), '... the @foo slot was added successfully'); +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); + +is(exception { + $foo_stash->add_symbol('&foo' => $CODE); +}, undef, '... created &Foo::foo successfully'); + +ok($foo_stash->has_symbol('&foo'), '... the meta agrees'); +is($foo_stash->get_symbol('&foo'), $CODE, '... got the right value for &Foo::foo'); + +is(exception { + $foo_stash->add_symbol('$foo' => 'Foo::foo'); +}, undef, '... created $Foo::foo successfully'); + +ok($foo_stash->has_symbol('$foo'), '... the meta agrees'); +my $SCALAR = $foo_stash->get_symbol('$foo'); +is($$SCALAR, 'Foo::foo', '... got the right scalar value back'); + +is(${ $Foo->{foo} }, 'Foo::foo', '... got the right value from the scalar'); + +is(exception { + $foo_stash->remove_symbol('%foo'); +}, undef, '... removed %Foo::foo successfully'); + +ok(!$foo_stash->has_symbol('%foo'), '... the %foo slot was removed successfully'); +ok($foo_stash->has_symbol('@foo'), '... the @foo slot still exists'); +ok($foo_stash->has_symbol('&foo'), '... the &foo slot still exists'); +ok($foo_stash->has_symbol('$foo'), '... the $foo slot still exists'); + +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); +is($foo_stash->get_symbol('&foo'), $CODE, '... got the right value for &Foo::foo'); +is($foo_stash->get_symbol('$foo'), $SCALAR, '... got the right value for $Foo::foo'); + +ok(!defined(*{ $Foo->{foo} }{HASH}), '... the %foo slot has been removed successfully'); +ok(defined(*{ $Foo->{foo} }{ARRAY}), '... the @foo slot has NOT been removed'); +ok(defined(*{ $Foo->{foo} }{CODE}), '... the &foo slot has NOT been removed'); +ok(defined(${ $Foo->{foo} }), '... the $foo slot has NOT been removed'); + +is(exception { + $foo_stash->remove_symbol('&foo'); +}, undef, '... removed &Foo::foo successfully'); + +ok(!$foo_stash->has_symbol('&foo'), '... the &foo slot no longer exists'); + +ok($foo_stash->has_symbol('@foo'), '... the @foo slot still exists'); +ok($foo_stash->has_symbol('$foo'), '... the $foo slot still exists'); + +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); +is($foo_stash->get_symbol('$foo'), $SCALAR, '... got the right value for $Foo::foo'); + +ok(!defined(*{ $Foo->{foo} }{HASH}), '... the %foo slot has been removed successfully'); +ok(!defined(*{ $Foo->{foo} }{CODE}), '... the &foo slot has now been removed'); +ok(defined(*{ $Foo->{foo} }{ARRAY}), '... the @foo slot has NOT been removed'); +ok(defined(${ $Foo->{foo} }), '... the $foo slot has NOT been removed'); + +is(exception { + $foo_stash->remove_symbol('$foo'); +}, undef, '... removed $Foo::foo successfully'); + +ok(!$foo_stash->has_symbol('$foo'), '... the $foo slot no longer exists'); + +ok($foo_stash->has_symbol('@foo'), '... the @foo slot still exists'); + +is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::foo'); + +ok(!defined(*{ $Foo->{foo} }{HASH}), '... the %foo slot has been removed successfully'); +ok(!defined(*{ $Foo->{foo} }{CODE}), '... the &foo slot has now been removed'); +ok(!defined(${ $Foo->{foo} }), '... the $foo slot has now been removed'); +ok(defined(*{ $Foo->{foo} }{ARRAY}), '... the @foo slot has NOT been removed'); + +{ + my $syms = $foo_stash->get_all_symbols; + is_deeply( + [ sort keys %{ $syms } ], + [ sort $foo_stash->list_all_symbols ], + '... the fetched symbols are the same as the listed ones' + ); +} + +{ + local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP') + ? "can't inflate weird stash entries" + : undef; + + is( + exception { + my $syms = $foo_stash->get_all_symbols('CODE'); + + is_deeply( + [ sort keys %{ $syms } ], + [ sort $foo_stash->list_all_symbols('CODE') ], + '... the fetched symbols are the same as the listed ones' + ); + + foreach my $symbol (keys %{ $syms }) { + is($syms->{$symbol}, $foo_stash->get_symbol('&' . $symbol), '... got the right symbol'); + } + }, + undef + ); +} + +{ + $foo_stash->add_symbol('%bare'); + ok(!$foo_stash->has_symbol('$bare'), + "add_symbol with single argument doesn't vivify scalar slot"); +} + +{ + $foo_stash->add_symbol('%zork', {}); + + my $syms = $foo_stash->get_all_symbols('HASH'); + + is_deeply( + [ sort keys %{ $syms } ], + [ sort $foo_stash->list_all_symbols('HASH') ], + '... the fetched symbols are the same as the listed ones' + ); + + foreach my $symbol (keys %{ $syms }) { + is($syms->{$symbol}, $foo_stash->get_symbol('%' . $symbol), '... got the right symbol'); + } + + is_deeply( + $syms, + { zork => *{ $Foo->{zork} }{HASH} }, + "got the right ones", + ); +} + +# check some errors + +like(exception { + $foo_stash->add_symbol('@bar', {}) +}, qr/HASH.*is not of type ARRAY/, "can't initialize a slot with the wrong type of value"); + +like(exception { + $foo_stash->add_symbol('bar', []) +}, qr/ARRAY.*is not of type IO/, "can't initialize a slot with the wrong type of value"); + +like(exception { + $foo_stash->add_symbol('$bar', sub { }) +}, qr/CODE.*is not of type SCALAR/, "can't initialize a slot with the wrong type of value"); + +like(exception { + $foo_stash->add_symbol('$bar', *{ Symbol::geniosym() }{IO}) +}, qr/IO.*is not of type SCALAR/, "can't initialize a slot with the wrong type of value"); + +is_deeply([Package::Stash->new('Foo')->list_all_symbols], [], + "Foo:: isn't touched"); + +my $Quux = {}; +$Quux->{foo} = *{ Symbol::gensym() }; +*{ $Quux->{foo} } = \23; +*{ $Quux->{foo} } = ["bar"]; +*{ $Quux->{foo} } = { baz => 1 }; +*{ $Quux->{foo} } = sub { }; +*{ $Quux->{foo} } = *{ Symbol::geniosym() }{IO}; + +{ + my $stash = Package::Stash->new($Quux); + + my %expect = ( + '$foo' => \23, + '@foo' => ["bar"], + '%foo' => { baz => 1 }, + '&foo' => \&{ $Quux->{foo} }, + 'foo' => *{ $Quux->{foo} }{IO}, + ); + + for my $sym ( sort keys %expect ) { + is_deeply( + $stash->get_symbol($sym), + $expect{$sym}, + "got expected value for $sym" + ); + } + + $stash->add_symbol('%bar' => {x => 42}); + + $expect{'%bar'} = {x => 42}; + + for my $sym ( sort keys %expect ) { + is_deeply( + $stash->get_symbol($sym), + $expect{$sym}, + "got expected value for $sym" + ); + } + + $stash->add_symbol('%bar' => {x => 43}); + + $expect{'%bar'} = {x => 43}; + + for my $sym ( sort keys %expect ) { + is_deeply( + $stash->get_symbol($sym), + $expect{$sym}, + "got expected value for $sym" + ); + } +} + +is_deeply([Package::Stash->new('Quux')->list_all_symbols], [], + "Quux:: isn't touched"); + +my $Quuux = {}; + +$Quuux->{foo} = *{ Symbol::gensym() }; +*{ $Quuux->{foo} } = \(my $scalar); +*{ $Quuux->{foo} } = []; + +$Quuux->{bar} = *{ Symbol::gensym() }; +*{ $Quuux->{bar} } = []; + +$Quuux->{baz} = *{ Symbol::gensym() }; +*{ $Quuux->{baz} } = {}; +*{ $Quuux->{baz} } = sub { }; + +$Quuux->{quux} = \1; + +$Quuux->{quuux} = \[]; + +$Quuux->{quuuux} = -1; + +{ + my $quuux = Package::Stash->new($Quuux); + is_deeply( + [sort $quuux->list_all_symbols], + [qw(bar baz foo quuuux quuux quux)], + "list_all_symbols", + ); + { local $TODO = $] < 5.010 + ? "undef scalars aren't visible on 5.8" + : undef; + is_deeply( + [sort $quuux->list_all_symbols('SCALAR')], + [qw(foo)], + "list_all_symbols SCALAR", + ); + } + is_deeply( + [sort $quuux->list_all_symbols('ARRAY')], + [qw(bar foo)], + "list_all_symbols ARRAY", + ); + is_deeply( + [sort $quuux->list_all_symbols('HASH')], + [qw(baz)], + "list_all_symbols HASH", + ); + is_deeply( + [sort $quuux->list_all_symbols('CODE')], + [qw(baz quuuux quuux quux)], + "list_all_symbols CODE", + ); +} + +is_deeply([Package::Stash->new('Quuux')->list_all_symbols], [], + "Quuux:: isn't touched"); + +done_testing; diff --git a/t/bare-anon.t b/t/bare-anon.t new file mode 100644 index 0000000..34e234c --- /dev/null +++ b/t/bare-anon.t @@ -0,0 +1,64 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use Test::More; +use Test::Fatal; +use lib 't/lib'; + +use Package::Stash; +use Symbol; + +plan skip_all => "Anonymous stashes in PP need at least perl 5.14" + if $] < 5.014 + && $Package::Stash::IMPLEMENTATION eq 'PP'; + +my $anon = {}; +my $stash = Package::Stash->new($anon); +# no way to bless something into a hashref yet +# my $obj = $anon->bless({}); + +{ + my $code = sub { 'FOO' }; + $stash->add_symbol('&foo' => $code); + is($stash->get_symbol('&foo'), $code); + # is($obj->foo, 'FOO'); +} + +{ + local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP') + ? "can't inflate weird stash entries" + : undef; + $anon->{bar} = \123; + + is( + exception { + my $code = $stash->get_symbol('&bar'); + is(ref($code), 'CODE'); + is($code->(), 123); + + # is($obj->bar, 123); + }, + undef + ); +} + +{ + local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP') + ? "can't inflate weird stash entries" + : undef; + $anon->{baz} = -1; + + is( + exception { + my $code = $stash->get_symbol('&baz'); + is(ref($code), 'CODE'); + like( + exception { $code->() }, + qr/Undefined subroutine \&__ANON__::baz called/ + ); + }, + undef + ); +} + +done_testing; diff --git a/t/basic.t b/t/basic.t index f20e055..b0f9936 100644 --- a/t/basic.t +++ b/t/basic.t @@ -251,7 +251,13 @@ is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::f } { - $foo_stash->add_symbol('%zork'); + $foo_stash->add_symbol('%bare'); + ok(!$foo_stash->has_symbol('$bare'), + "add_symbol with single argument doesn't vivify scalar slot"); +} + +{ + $foo_stash->add_symbol('%zork', {}); my $syms = $foo_stash->get_all_symbols('HASH'); @@ -265,10 +271,9 @@ is($foo_stash->get_symbol('@foo'), $ARRAY, '... got the right values for @Foo::f is($syms->{$symbol}, $foo_stash->get_symbol('%' . $symbol), '... got the right symbol'); } - no warnings 'once'; is_deeply( $syms, - { zork => \%Foo::zork }, + { zork => *{ $Foo::{zork} }{HASH} }, "got the right ones", ); } diff --git a/t/edge-cases.t b/t/edge-cases.t index 04e2164..262c13b 100755 --- a/t/edge-cases.t +++ b/t/edge-cases.t @@ -53,4 +53,40 @@ is(ref($constant), 'CODE', "expanded a constant into a coderef"); is(ref($stash->get_symbol('$glob')), '', "nothing yet"); is(ref($stash->get_or_add_symbol('$glob')), 'SCALAR', "got an empty scalar"); +SKIP: { + skip "PP doesn't support anon stashes before 5.14", 4 + if $] < 5.014 && $Package::Stash::IMPLEMENTATION eq 'PP'; + local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP') + ? "don't know how to properly inflate a stash entry" + : undef; + + my $anon = {}; # not using Package::Anon + $anon->{foo} = -1; # stub + $anon->{bar} = '$&'; # stub with prototype + $anon->{baz} = \"foo"; # constant + + my $stash = Package::Stash->new($anon); + is( + exception { + is(ref($stash->get_symbol('&foo')), 'CODE', + "stub expanded into a glob"); + is(ref($stash->get_symbol('&bar')), 'CODE', + "stub with prototype expanded into a glob"); + is(ref($stash->get_symbol('&baz')), 'CODE', + "constant expanded into a glob"); + }, + undef, + "can call get_symbol on weird stash entries" + ); +} + +{ + my $warning; + local $SIG{__WARN__} = sub { $warning = $_[0] }; + my $stash = Package::Stash->new('Bar'); + $stash->add_symbol('&foo' => sub { }); + $stash->add_symbol('&foo' => sub { }); + is($warning, undef, "no redefinition warnings"); +} + done_testing; diff --git a/t/inc-hook.t b/t/inc-hook.t new file mode 100644 index 0000000..a8deabb --- /dev/null +++ b/t/inc-hook.t @@ -0,0 +1,12 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use Test::More; +use Test::Fatal; +use lib 't/lib'; + +unshift @INC, sub { "some regex" =~ /match/; undef }; + +is(exception { require Package::Stash }, undef, "works with an \@INC hook"); + +done_testing;