From: Peter Rabbitson <ribasushi@cpan.org>
Date: Fri, 18 Sep 2009 12:52:26 +0000 (+0000)
Subject: Nothing says the grouping column can not be nullable
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c59dfc82ec97f74d6bd484e5f600f8335335a2fc;p=dbsrgits%2FDBIx-Class-Historic.git

Nothing says the grouping column can not be nullable
---

diff --git a/lib/DBIx/Class/Ordered.pm b/lib/DBIx/Class/Ordered.pm
index 59162bb..6c7446f 100644
--- a/lib/DBIx/Class/Ordered.pm
+++ b/lib/DBIx/Class/Ordered.pm
@@ -434,10 +434,7 @@ if multiple grouping columns are in use.
 sub move_to_group {
     my( $self, $to_group, $to_position ) = @_;
 
-    $self->throw_exception ('move_to_group() expects a group specification')
-        unless defined $to_group;
-
-    # if we're given a string, turn it into a hashref
+    # if we're given a single value, turn it into a hashref
     unless (ref $to_group eq 'HASH') {
         my @gcols = $self->_grouping_columns;